Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e606e2c3df5d727a6c69b74a803d9f2c8e717b0.camel@xry111.site>
Subject: Re: [PATCH] LoongArch: Makefile: use "grep -E" instead of "egrep"
From:   Xi Ruoyao <xry111@xry111.site>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Date:   Tue, 15 Nov 2022 22:27:59 +0800
In-Reply-To: <1668506549-28261-1-git-send-email-yangtiezhu@loongson.cn>
References: <1668506549-28261-1-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.0 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-11-15 at 18:02 +0800, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the
> build
> now contains warnings that look like:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0egrep: warning: egrep is =
obsolescent; using grep -E
> fix this up by moving the LoongArch Makefile to use "grep -E" instead.

For future reference: this warning message is imprecise because on some
non-POSIX platforms grep does not support -E (see "Limitations of Usual
Tools" in autoconf info page).

However (1) we are already using -w, which is not guaranteed to be
supported as well; (2) I don't think anyone will build LoongArch kernel
on such an old non-POSIX system.

So LGTM.

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> =C2=A0arch/loongarch/Makefile | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> index a0fc1f9..5232d8c 100644
> --- a/arch/loongarch/Makefile
> +++ b/arch/loongarch/Makefile
> @@ -97,7 +97,7 @@ KBUILD_LDFLAGS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0+=3D -m $(ld-emul)
> =C2=A0
> =C2=A0ifdef CONFIG_LOONGARCH
> =C2=A0CHECKFLAGS +=3D $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/nul=
l |
> \
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0egrep -vw '__GNUC_(MINOR_|PATC=
HLEVEL_)?_' | \
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0grep -E -vw '__GNUC_(MINOR_|PA=
TCHLEVEL_)?_' | \
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sed -e "s/^\#define /-D'/=
" -e "s/ /'=3D'/" -e "s/$$/'/" -e
> 's/\$$/&&/g')
> =C2=A0endif
> =C2=A0

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University