Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Wei Yang <richard.weiyang@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] maple_tree: not necessary to filter MAPLE_PARENT_ROOT
 since it is not a root
Thread-Topic: [PATCH] maple_tree: not necessary to filter MAPLE_PARENT_ROOT
 since it is not a root
Thread-Index: AQHY9vrPxktSaU9LZEKczgR5mXVsla5AD08AgAAHioA=
Date:   Tue, 15 Nov 2022 14:56:20 +0000
Message-ID: <20221115145613.6wheb3gnsvparvki@revolver>
References: <20221113005618.29679-1-richard.weiyang@gmail.com>
 <20221115142914.x6d2q3qz4xurikrq@revolver>
In-Reply-To: <20221115142914.x6d2q3qz4xurikrq@revolver>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IdPLnl46NwZxcA+wGkfkEd2p1KCvZ6/wLRKTxnby2pojl05Z/Iy/0wJwD+fT?=
 =?us-ascii?Q?0C1Ohf9lz93fXrQupFoQZIjsFEyr0N4dVrUgxAzTEF5Fxze8xFqoDRK4UpsL?=
 =?us-ascii?Q?kb7ujBQ2b27Vanvp4Ty5WsNHSkXA6Wz819JM4W4I1ipwVH5qdguHAaDZDBV+?=
 =?us-ascii?Q?DHFHKM/2nByg3GO+WJ/tBbp09q4jx7cwGl4kqCcSQq5m8JRJl73+aQHwRw8/?=
 =?us-ascii?Q?nSjp19kCHCEMKCk3Ua6pFzMRIlyjn62bCDEZMvAR5TM+8XX7SBihyzpJXGuj?=
 =?us-ascii?Q?Sh2lQ9ITXEo5FFfDjlm6H3W9315jog8f3ctQjAvz7VoziUAd0qsGEyovN/3R?=
 =?us-ascii?Q?ZGVIlfHWA8Waqqdl4nVFnTERSq7rMapDYekVAZfQz7WJteCZJ0WmxMYLjbyv?=
 =?us-ascii?Q?IESJJQxpn+9mvWAIiCJPwWH2PTzmWwliajOQFrEyK7y2msoVfuWIQaxJlM0v?=
 =?us-ascii?Q?smn9mxRTinmEidzQM4cQgRQ0DxQr5rZrrENfxY51jAOffa8WiPPA2fDs3uFT?=
 =?us-ascii?Q?Vz0EXX/cSTkuDm73ZBwJI23Grl6xU8QnvE9DFqTmb4KsUqAieHdpMwgiUIuE?=
 =?us-ascii?Q?YRfckts4Fw9h5SuDOfFIbDig5ZKX1SpLJ7QapIpViGq3BYqaieYc+G/I+Rtn?=
 =?us-ascii?Q?Flqa8WvIdZ2xD997pw53F2Uvne/BIqwAExdPIq4twL6GNs8U6CrnS+Fo+LTz?=
 =?us-ascii?Q?oLGYTxXasRrcSCYqQOjclh3OXIrzuAvl4B99bof+gJIL9vf9Sc6S5e/nbP2e?=
 =?us-ascii?Q?pHWR/WmbkP9ifBK5nL/s8kKhIJfykxyrUA5bbNSehxWZNR9rwpaVzCUqrMVb?=
 =?us-ascii?Q?on9mrTObDB0qd7lPOUu72Bsk4buLAdfWeE+aOeFqJpsxdrBQOqOZ/hQskjV7?=
 =?us-ascii?Q?zZoT81USnRLlLQGtGvdid9SdLZbTEZKP2IBpoe/ZjXCgprYFnux7nTSVKAlM?=
 =?us-ascii?Q?r7I4/1qCWZe5Axnzkm1Kz2vu+igPfrtntx2bf+2W0rEbdokAmixqyOfhMdD1?=
 =?us-ascii?Q?cg4SG2/eK5JUdF4/D9+J0suUDI2j68JZ2SdCcUkBgQ/TDt93BpMHewWYfG2r?=
 =?us-ascii?Q?YlcidTy7/SAAp8owrRpncliyMHZDP4vmh7Koqb8Y69lDP1+LNppyzwsUYTv3?=
 =?us-ascii?Q?baHY2rvWvGqZFZazvFP/Nj1whZJcYf1MtTNoi0QPBiY6UDkuAnQ8IE5sXF+M?=
 =?us-ascii?Q?hogkPFISMKrugKWykJt8sFBz2sogLd8nJ6fMJtDxmOVfu2kjikZLqnRKFnJP?=
 =?us-ascii?Q?19zn92oJh8UchW0ehbTVTdgOIxubLFfhMbJtVbhPFhB5MBz/kKfja7WRBFch?=
 =?us-ascii?Q?NYGHQB2gVmw1x/DwVZuc7j2FpOOUih3zHxHWpCFY9dSo20x6DLa2k2w8kBJ9?=
 =?us-ascii?Q?C5xvQur0SQDuvR8REvkDisGKyKIRLUoLsDf9Iq4LUEyn3QhVn62rLh/D1wZy?=
 =?us-ascii?Q?SURBXrJyhwJZl3+tvmvfHh0QuNPeHwfZQRlTj25/yTAt7Y9gUiwvaCz2n+45?=
 =?us-ascii?Q?toHcLi7yGY0zancYNCy4wEbcAMUeVnHmKZ5Yxm1gzyNwZLXYfDySvAIEM9TA?=
 =?us-ascii?Q?HrP8/rDVcqwFvWy4q7c5Sz2fWlVFCILE9WeJx9njobTOm4Lku2vBG3NGWam6?=
 =?us-ascii?Q?QQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D1583AF6F938284B9D263C6AB4BEFC2C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WKAST/5p/aP6OjoOWT7n8V9YbUt9abMpBYtbP7+vKH0zP6DOFGYpjzCz2/rfMZD06+hr/iTPr8Xpz76rtFYCyicnjrFtP4frH3mnKOwaOENw1hv4ij+DiNaqo2RcBJnvxAo0mwXKkNApCi0pjaWGiUAyfcgGWgz/HT/+PojOe3tTGH155Bl3gt5iuEPZ3CBtm1s2SIF6oT8OmaDs0GgaXceeV2yGThIrhBYJ+VQCbqOAv0O9bvo9yvb+TwTjms3Kg++QcqmdCV5/1dq9YONEMjWeUP4mXFWrQ5lzN6OnC2mAXwf68TCaWYtcCHrDyK+ocsgQYuvbmAkWHTQDEg3MyswsSjejwG/hpjp5J5dSiWxrKsmgKxAqpmb/Q1IHAwpubl3ghOVLj3b6ww9OSxs+gTUCyrP5XBvO943BW9WYcAMhrMdb6NVKxJV0prDAOJWJgLb6rvV7jp/xMovl01Hd6iUc2bm5XjmXa5wiJC2cfG5bHNMMpknhjaIHtuSNqemVnKT90n6NUYt2TbSUAETTUpQqC+S+SQbQvNDpWanId8L8cnGt+QYeRM4bt+dy4k+cLumUw3gqIZC3jJLmhXpkjF5QWICQU3I/sO//4F2GojlqQaO9GIJz7vEka+EBRfC2Z6gFLT9aSgQzjfRAxv6GI3dQVApUo6/lQMKEdY3OyW7e93GbhTAjGqY3t4tB5Ra+P9Gl/Q9URWQUC04i681WLL6tLyAYgdjHFwgcMuJWX4EB7WHGiczHFxpTq9z3JqlJzgJ12UAkoeuf3m/RqRXrD60R19i5tU1fpjGzmlCwnKhn16+WRC5f86KxaojkkN07
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a461b07b-d87d-46c1-7384-08dac7198e85
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 14:56:20.5410
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mXwZmqVMNr4+pg838OAlWBjFzHF7fR9oNWgSLzsvtVRMnFjzTGe7XATH/o+80dmHcG9AkqqKyx6EtuwN0v5L3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5154
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-15_08,2022-11-15_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211150100
X-Proofpoint-ORIG-GUID: 3KVoowWOxc2eQUr_xAbhLIrjAKkAeZec
X-Proofpoint-GUID: 3KVoowWOxc2eQUr_xAbhLIrjAKkAeZec
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [221115 09:29]:
> * Wei Yang <richard.weiyang@gmail.com> [221112 19:56]:
> > Root node is return at the beginning, so we are sure bit 0 is not set.
> >=20
> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> > CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > ---
> >  lib/maple_tree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> > index 9aad98c24f3e..f8c4755e7c75 100644
> > --- a/lib/maple_tree.c
> > +++ b/lib/maple_tree.c
> > @@ -436,7 +436,7 @@ enum maple_type mte_parent_enum(struct maple_enode =
*p_enode,
> >  		return 0; /* Validated in the caller. */
> > =20
> >  	p_type &=3D MAPLE_NODE_MASK;
> > -	p_type =3D p_type & ~(MAPLE_PARENT_ROOT | mte_parent_slot_mask(p_type=
));
> > +	p_type =3D p_type & ~mte_parent_slot_mask(p_type);
>=20
> I think there is a larger cleanup that can be done here.  It looks like
> mte_parent_enum() is called from one location and that location is a
> wrapper.
>=20
> The check for the root bit should also probably trigger a WARN_ON() and
> still return 0.  I don't think the callers are doing enough to validate
> it - although they should never reach this function with a root node.
> And, in fact, I am not doing enough in the test code since I didn't
> guard this correctly in the verification of the parent slot before
> calling this function.
>=20
> Thanks for pointing this out.  I will send out a patch to clean this up
> shortly.

On second thought, I will hold off for the 6.2 merge window for this to
go upstream.

Thanks,
Liam=