Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936377AbXHHVGr (ORCPT ); Wed, 8 Aug 2007 17:06:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763806AbXHHVGk (ORCPT ); Wed, 8 Aug 2007 17:06:40 -0400 Received: from gir.skynet.ie ([193.1.99.77]:38204 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763049AbXHHVGj (ORCPT ); Wed, 8 Aug 2007 17:06:39 -0400 Date: Wed, 8 Aug 2007 22:06:37 +0100 To: Christoph Lameter Cc: Lee.Schermerhorn@hp.com, pj@sgi.com, ak@suse.de, kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] Use zonelists instead of zones when direct reclaiming pages Message-ID: <20070808210637.GA2441@skynet.ie> References: <20070808161504.32320.79576.sendpatchset@skynet.skynet.ie> <20070808161524.32320.87008.sendpatchset@skynet.skynet.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 22 On (08/08/07 10:38), Christoph Lameter didst pronounce: > Good idea. Maybe it could be taken further by passing the zonelist also > into shrink_zones()? > Yeah, it could. It's a cleanup even though it doesn't simplify the iterator. When the patch was done first, it was because multiple iterators were needed to go through the zones in the zonelist. With this cleanup, only one iterator was needed but it could be carried through for consistency. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/