Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221115053920.65318-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20221115053920.65318-1-jiapeng.chong@linux.alibaba.com>
From:   Roderick Colenbrander <thunderbird2k@gmail.com>
Date:   Tue, 15 Nov 2022 07:41:02 -0800
Message-ID: <CAEc3jaBVw40YU9DTFY0nr_bqBSHdvbqFZBgyXwTGKLOQkuzxEw@mail.gmail.com>
Subject: Re: [PATCH] HID: playstation: remove unreachable code
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     roderick.colenbrander@sony.com, jikos@kernel.org,
        benjamin.tissoires@redhat.com, rydberg@bitmath.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 14, 2022 at 9:40 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The function dualshock4_get_calibration_data cannot execute hid_err,
> delete the invalid code.
>
> drivers/hid/hid-playstation.c:1766 dualshock4_get_calibration_data() warn: ignoring unreachable code.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3073
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/hid/hid-playstation.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
> index bae3e712a562..a4106f760d1f 100644
> --- a/drivers/hid/hid-playstation.c
> +++ b/drivers/hid/hid-playstation.c
> @@ -1763,8 +1763,6 @@ static int dualshock4_get_calibration_data(struct dualshock4 *ds4)
>                                         ret = -EILSEQ;
>                                         goto err_free;
>                                 }
> -                               hid_err(hdev, "Failed to retrieve DualShock4 calibration info: %d\n", ret);
> -                               goto err_free;
>                         } else {
>                                 break;
>                         }
> --
> 2.20.1.7.g153144c
>

Thanks for pointing this out. The error message is actually needed and
should be moved either in the else statement or we just take the else
statement.

Thanks,
Roderick