Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7235136rwb; Tue, 15 Nov 2022 09:19:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf6EkH0s2d0xSjxZIoBIyJUWzLmHXB6Y3F4JKHeKfwMCygtCvmeaGNOO8IBBzqjEw2GBp3hB X-Received: by 2002:a63:190a:0:b0:460:9fe9:d325 with SMTP id z10-20020a63190a000000b004609fe9d325mr16540509pgl.608.1668532768254; Tue, 15 Nov 2022 09:19:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668532768; cv=none; d=google.com; s=arc-20160816; b=NYDTzXAcTB/8pTnL6W0R5S0WBkKMxu7/6BP2OH7uruW6k66PyKpnFCwoec9C0JyDQw Mllxa/ltdZw9saTWvoFI/G7PHyWBjP95iV+/U2WhSD6vN8DvPTWSlGfphGEzOA8riYjd 5Mw52kCaXMA2lkqe7Ptb7KPNqmyoy9hbFeq69dgvAjJApd/mmcJlrZ7VZNz8XCMkym7m RIprEa+7HUKACpTxyBD/+glQ8FsQFD2nMlQD1Bhjpq/4MWBg0uvozn9S4NwxOp4ls1tx uVzZ4zTkIall13lMnNo14yaXDjXyqQQPhZTD4kEGd/bSt1Do0Zl2MuTlOHtwF5fBN/vL nUFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=HrunAVDEDm+yyiX3Yrk2zJt4p2vGEeG8d0hq/GRhpwY=; b=e2B8Eubz2xdJDmbHRWGSiIZ+6gXTMC7EuzUK/2hbIxD6vTqKzY324Hj5NUzldNppUP +pmmRqWk8TfsLLidIsNBSntUp4jvLiFWxX4b4MMkzva5QbT3uRWGuy4Zgz2Y06VQrWgw CD5pJS31zXJA1JHbSFyE6/8G1JdVwnW9EhKAo5ec1E6SiFvbECWrxeV4lr/S+Cm4dhW+ 8UG5F/ifkfd1+vTiMSMHp0CUfIRoek+mRH23juDzZk0wA2tML/9vaHHMUUXZaSOjbyQj UV9Xv9acakrhM8dSPRR3+ktxe/8T0BH/ajQePY92fLxZM7sSxoOS7pUaOPftHPJVRzIG KMLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=EKZTb0Fq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h184-20020a6383c1000000b00476d250039fsi870542pge.513.2022.11.15.09.19.15; Tue, 15 Nov 2022 09:19:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=EKZTb0Fq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbiKORHq (ORCPT + 91 others); Tue, 15 Nov 2022 12:07:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbiKORHn (ORCPT ); Tue, 15 Nov 2022 12:07:43 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DDCF3D77 for ; Tue, 15 Nov 2022 09:07:42 -0800 (PST) Received: from kbox (unknown [76.135.50.127]) by linux.microsoft.com (Postfix) with ESMTPSA id 89F7020B717A; Tue, 15 Nov 2022 09:07:42 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 89F7020B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1668532062; bh=HrunAVDEDm+yyiX3Yrk2zJt4p2vGEeG8d0hq/GRhpwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKZTb0FqpRT9LHP5yW1FbduWK9uCd/imA3SR+R48ODOBYSadn6CmE5oeUbNW/44cM FNAw5lDUWmTivEToNzYo4sKlQ9ENtjn+ROr/Kn2xejJ+JYkt2TcSf3llaRKiHEMJB+ yN1Lc9a+CxubHQXHVrwgYuRhfMdrt98LhZ2yUp3M= Date: Tue, 15 Nov 2022 09:07:35 -0800 From: Beau Belgrave To: Masami Hiramatsu Cc: Xiu Jianfeng , rostedt@goodmis.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing/user_events: Fix memory leak in user_event_create() Message-ID: <20221115170735.GA1794@kbox> References: <20221115014445.158419-1-xiujianfeng@huawei.com> <20221116000717.4b62513eeaf0b2296b399bda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116000717.4b62513eeaf0b2296b399bda@kernel.org> X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16, 2022 at 12:07:17AM +0900, Masami Hiramatsu wrote: > On Tue, 15 Nov 2022 09:44:45 +0800 > Xiu Jianfeng wrote: > > > Before current_user_event_group(), it has allocated memory and save it > > in @name, this should freed before return error. > > Nice catch! Acked-by: Beau Belgrave Thanks, -Beau > > Fixes: e5d271812e7a ("tracing/user_events: Move pages/locks into groups to prepare for namespaces") > > Signed-off-by: Xiu Jianfeng > > This looks good to me. > > Acked-by: Masami Hiramatsu (Google) > > Thanks, > > > --- > > kernel/trace/trace_events_user.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c > > index ae78c2d53c8a..539b08ae7020 100644 > > --- a/kernel/trace/trace_events_user.c > > +++ b/kernel/trace/trace_events_user.c > > @@ -1100,8 +1100,10 @@ static int user_event_create(const char *raw_command) > > > > group = current_user_event_group(); > > > > - if (!group) > > + if (!group) { > > + kfree(name); > > return -ENOENT; > > + } > > > > mutex_lock(&group->reg_mutex); > > > > -- > > 2.17.1 > > > > > -- > Masami Hiramatsu (Google)