Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jiri Olsa <olsajiri@gmail.com>
Date:   Tue, 15 Nov 2022 18:01:15 +0100
To:     Hao Sun <sunhao.th@gmail.com>
Cc:     Jiri Olsa <olsajiri@gmail.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Hao Luo <haoluo@google.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Stanislav Fomichev <sdf@google.com>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>
Subject: Re: WARNING in bpf_bprintf_prepare
Message-ID: <Y3PF22jvCUSJA7uK@krava>
References: <Y2j6ivTwFmA0FtvY@krava>
 <CAADnVQKXcdVa-gDj2_QTrBuVea+KMuFUdabR--HCf7x6Vo6uXg@mail.gmail.com>
 <Y2uv/GjnSdr/ujOj@krava>
 <CAADnVQJp0ZrodRu8ZtvvtXk6KAbjxmwqD-nXgFAxNpNxN6JM=g@mail.gmail.com>
 <Y2w9bNhVlAs/PcNV@krava>
 <Y25gFdliV7XqdUnN@krava>
 <CACkBjsaCsTovQHFfkqJKto6S4Z8d02ud1D7MPESrHa1cVNNTrw@mail.gmail.com>
 <Y3H2qayW0hKlzBkK@krava>
 <Y3LFgI6mmC0SKiFw@krava>
 <CACkBjsZpz9WqHgPY3oMj4BKuDPwU_QNkkCh2OeHL+nersyrQQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACkBjsZpz9WqHgPY3oMj4BKuDPwU_QNkkCh2OeHL+nersyrQQw@mail.gmail.com>
Precedence: bulk

On Tue, Nov 15, 2022 at 09:48:27AM +0800, Hao Sun wrote:

SNIP

> > > > Hi Jirka,
> > > >
> > > > I've tested the proposed patch, the warning from bpf_bprintf_prepare will not
> > > > be triggered with the patch, but the reproducer can still trigger the following
> > > > warning. My test was conducted on:
> > > >
> > > > commit:  f67dd6ce0723 Merge tag 'slab-for-6.1-rc4-fixes'
> > > > git tree:   upstream
> > > > kernel config: https://pastebin.com/raw/sE5QK5HL
> > > > C reproducer: https://pastebin.com/raw/X96ASi27
> > > > console log *before* the patch: https://pastebin.com/raw/eSCUNFrd
> > > > console log *after* the patch: https://pastebin.com/raw/tzcmdWZt
> > >
> > > thanks for testing.. I can't reproduce this for some reason
> > >
> > > I'll check some more and perhaps go with denying bpf attachment
> > > for this tracepoint as Alexei suggeste
> >
> > the change below won't allow to attach bpf program with any printk
> > helper in contention_begin and bpf_trace_printk tracepoints
> >
> > I still need to test it on the machine that reproduced the issue
> > for me.. meanwhile any feedback is appreciated
> >
> 
> Hi,
> 
> Tested on my machine, the C reproducer won't trigger any issue
> this time with the patch. The test was conducted on:
> 
> commit:  f67dd6ce0723 Merge tag 'slab-for-6.1-rc4-fixes'
> git tree:   upstream
> kernel config: https://pastebin.com/raw/sE5QK5HL
> C reproducer: https://pastebin.com/raw/X96ASi27
> full console log *before* the patch: https://pastebin.com/raw/n3x55RDr
> full console log *after* the patch: https://pastebin.com/raw/7HdxnCnL

thanks, looks good on my end as well

jirka