Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Nov 2022 10:01:42 -0700
From:   Jack Rosenthal <jrosenth@chromium.org>
To:     Peng Wu <wupeng58@huawei.com>
Cc:     jwerner@chromium.org, gregkh@linuxfoundation.org,
        groeck@chromium.org, linux-kernel@vger.kernel.org,
        liwei391@huawei.com
Subject: Re: [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in
 cbmem_entry_probe()
Message-ID: <Y3PF9k8/ofe8EatQ@chromium.org>
References: <20221115091138.51614-1-wupeng58@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221115091138.51614-1-wupeng58@huawei.com>
Precedence: bulk

On 2022-11-15 at 09:11 +0000, Peng Wu wrote:
> The devm_memremap() function returns error pointers on error,
> it doesn't return NULL.
> 
> Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
> Signed-off-by: Peng Wu <wupeng58@huawei.com>

Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>

> ---
>  drivers/firmware/google/cbmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
> index 685f3070ce9d..88e587ba1e0d 100644
> --- a/drivers/firmware/google/cbmem.c
> +++ b/drivers/firmware/google/cbmem.c
> @@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
>  	entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
>  					    dev->cbmem_entry.entry_size,
>  					    MEMREMAP_WB);
> -	if (!entry->mem_file_buf)
> -		return -ENOMEM;
> +	if (IS_ERR(entry->mem_file_buf))
> +		return PTR_ERR(entry->mem_file_buf);
>  
>  	entry->size = dev->cbmem_entry.entry_size;
>  
> -- 
> 2.17.1
>