Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Nov 2022 17:57:18 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Wei Yongjun <weiyongjun@huaweicloud.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>, openbmc@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] irqchip/wpcm450: fix memory leak in
 wpcm450_aic_of_init()
Message-ID: <Y3PE7vU6nfe4fqHU@probook>
References: <20221115092532.1704032-1-weiyongjun@huaweicloud.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CRF5/JpvIrJ8HkWI"
Content-Disposition: inline
In-Reply-To: <20221115092532.1704032-1-weiyongjun@huaweicloud.com>
UI-OutboundReport: notjunk:1;M01:P0:WKGNLr0BtDE=;/XdxevZdyrjTKJjxoYlnZJZV06A
 8LaQNsYZzY3aajOhAbx5wG/9lFXiJkEU6wc/MyoohTJ+FML1jwBqS8q0sD63OlLR/MZHAcGgW
 WVI40yLcKaczM2OU1SzbpE89zfTcaEkV9xrRbdkgU9weuY0c4rOKHRxW32vXXVa091VpC6jRX
 PPlnDccGZJsH/hF0wfv4YbgWZfpmt7kwQxSuoG8r82WV+CBPtw44tXGVRnBb0eHvuo4KPZGfz
 IesZiJFU/DUv9ufDuC33NeGMCrWCWE14mKR7J0VB22UIEDs4OqujhkYqMPNHX8wIkk2spxPg1
 4LgC5mZGyTUkvzPejehyTPgdHkSxhV01PCms76M9EXrX5+WmlR67YnCWWMW6seRTpZS7Bxg6A
 ZFzVmWLo7yfy61fp51/CPOpQMGtotC1nv7z39Fss0eLOwuQ/Bwfb/TrQUxoNSiGcWuGHzr5O6
 CLByK/KUYc6wG1FKfNnPN92tvBdaGkGtthZjPkAaax1VRpkxaix9xVFDKiRIqupPP0d9Stb24
 5B/hXHsqaLLHtDwVUj3MCAinchb1+HYODxAa+ZloGZKwUrLK6sbQTXqqVK1/LB0JWOTzim54D
 3AEZ7HdlUjABuB4ZNsgYVBR3afBivi7YQ/qy8XDwurR7y86l7ql4fBkDKQeH8v18RZiZ/m6L9
 5M+W2FtZ7+E6n57S/7AS4BRmopBKs/x+to+qnyvCybdERJWueYB+Wcc5PcLkUA8IxEDo+OAqp
 l/AONCZDKJgkHky1XRFY/5aU9MtZoI2VjRqoN2FZphpIJIBojbCRkZdU7lj39AiQ7mgf41hSg
 LtH9F5pWZG8A2mXxIH8EBArbnDczyKoSr0wpHt+HdZc6z+EGUSNhvM8R6IgAN95YKzM/9cOYB
 QQgqm6VxuiMy5zhI5bHBvRnCciLfrhFEMiSti6FGVVE3PWrNCFQvy6qlXn6w7nl3ZEzN49Yet
 Ddzlmw==
Precedence: bulk


--CRF5/JpvIrJ8HkWI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 15, 2022 at 09:25:32AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>=20
> If of_iomap() failed, 'aic' should be freed before return. Otherwise
> there is a memory leak.
>=20
> Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controlle=
r")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>


Thanks.

> ---
> v1 -> v2: fix function name in subject
>=20
>  drivers/irqchip/irq-wpcm450-aic.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm=
450-aic.c
> index 0dcbeb1a05a1..91df62a64cd9 100644
> --- a/drivers/irqchip/irq-wpcm450-aic.c
> +++ b/drivers/irqchip/irq-wpcm450-aic.c
> @@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_n=
ode *node,
>  	aic->regs =3D of_iomap(node, 0);
>  	if (!aic->regs) {
>  		pr_err("Failed to map WPCM450 AIC registers\n");
> +		kfree(aic);
>  		return -ENOMEM;
>  	}
> =20
> --=20
> 2.34.1
>=20

--CRF5/JpvIrJ8HkWI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmNzxMsACgkQCDBEmo7z
X9vfJA//UEjUxljWwWoootQ5VqT+v8/148V/tb4cCscqxrIb/JtdO7sxMoSeLoCP
mrFbyzdcRYQb3eP96Xor5DwNmR/kpgqE2qeNRaAXndmIwydz53fCEsWLvIrPTtM7
w2xbsreQsXnLv6D/V/qxUy6IWiO0d0de3Yorus3TY/aDz3HnMMaONpBU0hhZofsZ
ugMkcomXVOD8PQ794JpfGtxkDQZDH1Wr/cqnVM9/w3fMemZWddUNGf3yeYjJx7WF
MDMGLZSWUL7VPbIrQsXgGmAF9BKfUcFTnArMnbIExZSIMA+LEbHksEpIrFaLhiei
r1DeX1MbXB+LAsImByCp4HGWDFO9kUSw7/uKUcaDyhOTR2o3w/MzeNOHFk8AhXtW
yVh/lIFcgvks9PcdLicihmrPl/dOAEwQ9cMHldpqQ9PTI1qUqNo0b3twt1pUiozS
OlfQBDfgySjNLzvFYY1WNw+DPs1jFAcUps09y+PV0//POiyVX0JbrbySS1vuW5JU
HanHv2NtxqxZCrDD2XCHtWTJiUtBWvV8HmTPpzuWNqUcc+ZSC3Ew51mWmA9+FD8f
/kvS3VLzS72XAqgFkJFI7+Z3GGszfNV8HSa+J7k0euJLtHR9SWluVR165xClGCGF
iURewKEz6m2uq0S/IztE/cHvK3QeTEWugLKj91YJvocXumvU8ms=
=6d8q
-----END PGP SIGNATURE-----

--CRF5/JpvIrJ8HkWI--