Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Nov 2022 17:14:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, michael@walle.cc
Subject: Re: [PATCH v2 2/4] regmap-irq: Add handle_mask_sync() callback
Message-ID: <Y3PI5n8FXxOtGhzP@sirena.org.uk>
References: <cover.1668129763.git.william.gray@linaro.org>
 <53e9e89cc9d7e9c20cbdfc13b360dcb43d07f832.1668129763.git.william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6WJY0q1LVzw+BIMY"
Content-Disposition: inline
In-Reply-To: <53e9e89cc9d7e9c20cbdfc13b360dcb43d07f832.1668129763.git.william.gray@linaro.org>
Precedence: bulk


--6WJY0q1LVzw+BIMY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 10, 2022 at 08:55:51PM -0500, William Breathitt Gray wrote:

> Provide a public callback handle_mask_sync() that drivers can use when
> they have more complex IRQ masking logic. The default implementation is
> regmap_irq_handle_mask_sync(), used if the chip doesn't provide its own
> callback.

Can you provide examples of something that would make sense to
open code in a driver rather than factoring out?  It looks like
this has been added due to one of the devices you're looking at
for some reason disabling it's upstream interrupt when all of the
downstream interrupts are masked, while weird that doesn't seem
especally device specific.

--6WJY0q1LVzw+BIMY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNzyOYACgkQJNaLcl1U
h9DI5wf/ReemeRWA1bhQND00SnN8oMnU5R0oinaAM9yFZymGxqvEVbBf8kf5wcCV
N8HjYk9DASKbW9kU/n7g3KbTt9f88bXcniJTKdSaDl8IaunGHgc9n/lpZuhkZmhT
UaMfu9YmHqc83Qle9cixfbc49kP2j5pfS8gLwkUd6PShZflYfg8P6RxVpb7SoI73
qCPhdx9Q2WvNLW4jmSxyqC/VuYUV7iU8AC2bQ33TpkC46F1NM9+HdSLBoM5pHap4
GEFOxh+/6hmYGZiVK8D2HD6Bbjy9xWGZyhNdZm7kVsifUlnUp0cE+aehsZX0CrBf
CCwLm4KtyjwBZjY/m2U1YNl0Sbzezw==
=dw0O
-----END PGP SIGNATURE-----

--6WJY0q1LVzw+BIMY--