Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7250334rwb; Tue, 15 Nov 2022 09:31:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf4trpMRs/BS/84hiQSpTAMkzyYICPs16HX26eXQHryV6TLVtFxwRwW6EZCAqULqqcK7ZkzB X-Received: by 2002:a17:907:838d:b0:7aa:ffd0:cbec with SMTP id mv13-20020a170907838d00b007aaffd0cbecmr14419718ejc.758.1668533480115; Tue, 15 Nov 2022 09:31:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668533480; cv=none; d=google.com; s=arc-20160816; b=hDqOL2jJElJA3dFKYLSbDi5Rx2ZI0PPWMsmbkZsyxCRgRP/JAvA6YLfLGiB4keVjMC YkhwgJ9rEnA0FxljaH4qjJEghyfkhETg6r0Ni/3VHb44x8+bhlWI1PzsGTZxfv/hCzsn KINMcZlH4E8CZPOmqu8XBpzY4bSdsZ7LNrt439IjV1tdCSqUW48Pd7ywJPnZEdt6AcUS mTdYVcH71SIrkjAkvST+BMp+lpORXcCSRKD6BBQDlyr0MrLPRuphrFr0yFaugwIKeR9M tUhY2FoM5FfERFUBZWnPRZv6hWNZciZPshfVbykLUV4JqwntI+hz0Evhw6muQn+hVQYq tk/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=47gHpz6Fga3+YBhnBAdWwAeQKQAfCfajJwJi/5T0nt0=; b=xT8fAUo7i8iaruhJ6mnXUtIZ0GU/VgLp1XzY1xiOwyMu8UizfEjcVPN5vJvREqBo+9 s/bf6D+feoV1pHLOntrrn6zQgZbxuft22q7B4DuQ1ZSA7Vgkssj//SHsWngRNOufpU6+ pkNUJxyy4hr4iQ+XlXxmUPaeHYuSPnaOwVY0cd+e7oonfvjPIABRDX8+NcXgJeGpFdE4 OgKP5oed6kHyuwCxvdr+hMN2N4kd6Nw/6L+mVXzmDAWbaM2c/nBdN2CvD/3WfBR6zA5i w5+dIs9glFQSgfzLRuiVfq4RdhTy4q2Vk78Ddin8HHJ0LFVs97QDsRaUe+N4XZgujryk J+pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ks2Z9l6Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020a170906285100b00781df71dbc1si9458613ejc.174.2022.11.15.09.30.57; Tue, 15 Nov 2022 09:31:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ks2Z9l6Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231588AbiKOQig (ORCPT + 90 others); Tue, 15 Nov 2022 11:38:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbiKOQic (ORCPT ); Tue, 15 Nov 2022 11:38:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C4D01A068; Tue, 15 Nov 2022 08:38:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB506618EA; Tue, 15 Nov 2022 16:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA828C433C1; Tue, 15 Nov 2022 16:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668530310; bh=PsKz0EwnOL+DBT0MFmKu4L0TmsnsvB7Jr/ekWkAjNxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ks2Z9l6QYQt199L9alM5h8Hau57hpmt8G7ISHXSVqrQWTkX3n6CzUdrn+sXFcYNeX Znzr6o6ukDOZV2/V9ei2TaixFDYzpPAuLUP2OTIvARKV4K4nQAo1968PrhKBgg0Pnw ub8M+4fir6nL+LlSdqFnI8eBDB4eaTvCyTQsJwgTiF86NvMXgd1OeUFc8hKhIZrq5I hWCaIYe2s0G1rfCRqrjHCDbZCYYWSRu5x6MALALo994Khgo23X43nKygs3smJHi/74 m4a/1m5+GeuECE8YYO3nLXVT2fXCf/WJAGo24dp3xR/PXxMPmBsThB4zUS/EZ+tekW /Ajv+NChXuz2A== Date: Tue, 15 Nov 2022 08:38:28 -0800 From: Jakub Kicinski To: Rasmus Villemoes Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports Message-ID: <20221115083828.06cebab1@kernel.org> In-Reply-To: <20221115074356.998747-1-linux@rasmusvillemoes.dk> References: <20221111161729.915233-1-linux@rasmusvillemoes.dk> <20221115074356.998747-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2022 08:43:55 +0100 Rasmus Villemoes wrote: > + if (port->name) { > + name = port->name; > + assign_type = NET_NAME_PREDICTABLE; > + } else { > + name = "eth%d"; > + assign_type = NET_NAME_ENUM; Per Andrew's comment lets make the change in two steps. Which one should come first is a judgment call :)