Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Nov 2022 10:09:57 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v3 4/9] cxl/mem: Skip intermediate port enumeration of
 restricted endpoints (RCDs)
Message-ID: <6373d5f5bed39_12cdff29444@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221109104059.766720-1-rrichter@amd.com>
 <20221109104059.766720-5-rrichter@amd.com>
 <6372dc26c8f2f_12cdff294e4@dwillia2-xfh.jf.intel.com.notmuch>
 <Y3OT4oz6aR6hyvSt@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y3OT4oz6aR6hyvSt@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zhM/36LF8V3W/1wTPNZellyvHgQUHNKODjmNPTPxlv+NJobXWEUYMxl6z+VZ?=
 =?us-ascii?Q?ii5kQiCtCefwruoCbHt5A43ixIYJQPa2AN5dhvT40iUV3lF/xAUDMrBf/rc9?=
 =?us-ascii?Q?hm0XwLiciZAJWIiaEhz+sJ+0nboPWlydPNpKxIGYc0abfoQgz7EhFLPzkQYU?=
 =?us-ascii?Q?paJsHYFQjchkQoybaEGtOXuCjlBdgAZyAg9wRlx2+XgKbo0XbnGoMqarG3QF?=
 =?us-ascii?Q?eFvkByTl0HZ+NXWwihf7g81eeAo58VhARZ07UwDG8WDEG8J1p99NrMONoYQT?=
 =?us-ascii?Q?ngvXlKOy3lptPR3MbdShqNs2P2S6qQp3CeDb5Ec2uZbOmxS0JJAaoFvFuDrT?=
 =?us-ascii?Q?mDvHV2k8gLYz/SV5+HiqS1zRBqyKQVB/S6SJi44/dC0YgEYfmIL9PgDdDf17?=
 =?us-ascii?Q?2ZUIOIRxQGY2TIoIN7lr6e9AyI4Y9UBjvGKqf6OwcU0PEPa2ZakGiHdSsDX0?=
 =?us-ascii?Q?c1DdhZ4hisdwxsn11hFeDUmGMCpXROIekIlwZyaxHDmOh8L0KdiWi8qCW2FO?=
 =?us-ascii?Q?lWseThsuX6YCTawBsMSljbrOWWcEwuuFu71Rrx3D+DA5mhBRz4AtVKNNI3GE?=
 =?us-ascii?Q?qND2NeH51HCOp24do4cyK7gatFFfKS4iAtbyFdc+w+nmoN5NNX6Nbtledfao?=
 =?us-ascii?Q?eFemzpbLt/K2HSdjvSiy8x2p8XxUoLhsoOyrTrnnFLI9KvME0mCmW8aFfTQZ?=
 =?us-ascii?Q?+mmOhWzo0xrp6C+fe6DvTOOKuvUoqw3Kb0S2IVqEZolW7C8EKs02rC+Ra+CU?=
 =?us-ascii?Q?MwS+TNUC5Kgv7M91a2LJIhqrJNIFusgty8m3QtoYWwIZYFJC7zicMVDsyewC?=
 =?us-ascii?Q?LI84y+23Ii8V3LB/7ctLXHJZYmkMsPh2tLIetO64KoP9Ud2YyciIAWNIDPWu?=
 =?us-ascii?Q?gaXko/8Lkx1PgsariVCpSvso3nDQGsfvvZg7n7n8kTyPIcLZrs+ynkYX5SY6?=
 =?us-ascii?Q?qqilDbKKnplVyW+/GD7o+WFYg+ZEGBcdHz6o9mC/a44zSUrrlGE/5lKXeUZK?=
 =?us-ascii?Q?XJGvan9czNnTjqEr3/Vwgpp57hBNTxZfVMgzcHkN49FzXlCRoB4UaESNmXzS?=
 =?us-ascii?Q?1CmRnyVUngejmbxmRo2VXldkHGGI6x4kDKYRmbrB5C5WublHbFsY5Efa426e?=
 =?us-ascii?Q?BPADvB9wKBUNxPE18w2ANov/85ZGuge4zJuCwlS35pLIw42uw+whL8VemCrz?=
 =?us-ascii?Q?IZbFfWvyjiEXBUAUj4Gz7t+iDvFqPop/aGVOrNApJPpH3j8fXl0FnNRNGmmk?=
 =?us-ascii?Q?cJ0t1Nu3DvLFnnBvzNqdGSLm605dV476x2DSLSjTeAvtEW0fBIhgl7QzqpYQ?=
 =?us-ascii?Q?i7MVCcW41rLOWh4ZPIAeQ83T9KSQnEZeosgoue/TfzA/No50m6ePcy0BD713?=
 =?us-ascii?Q?12iz/1XxjLf0gJSQUeUtqYTrvEO2sub7Hf/KqGjDX6IZDeOud5CDMBUFNYSb?=
 =?us-ascii?Q?QPYcfIg9PmW5GqLWaZBCCVQwCVnbN0dCNEZ2Z4GMZ1rOG2aEf0W70WrYT1hs?=
 =?us-ascii?Q?0eBZhGZoFbNN/Tzc+LppfJfmFZS0hU8V5N36jk/aPlKPpzCzBAJC0Iu8+KUp?=
 =?us-ascii?Q?nDLGyuGxThm49DlQx5VB5j601DaMvjRZnznhq7Xv2XKFJ/Undrv8VyQ8wDjd?=
 =?us-ascii?Q?Iw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed47746-db83-4f03-1b29-08dac7349c48
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 18:10:00.1950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AfPrMzHRb7Sd6o7PBctXhE80ey8Z4ydmYhP6KBBoV2q5+UpTdzDVGDkaVfgtOLBWXSBoRsLBBwTcLClFCNEZyTr5PGRtZr9raDm7xHzcSqM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6266
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> On 14.11.22 16:24:06, Dan Williams wrote:
> > Robert Richter wrote:
> > > When an endpoint is found, all ports in beetween the endpoint and the
> > > CXL host bridge need to be created. In the RCH case there are no ports
> > > in between a host bridge and the endpoint. Skip the enumeration of
> > > intermediate ports.
> > > 
> > > The port enumeration does not only create all ports, it also
> > > initializes the endpoint chain by adding the endpoint to every
> > > downstream port up to the root bridge. This must be done also in RCD
> > > mode, but is much more simple as the endpoint only needs to be added
> > > to the host bridge's dport.
> > > 
> > > Note: For endpoint removal the cxl_detach_ep() is not needed as it is
> > > released in cxl_port_release().
> > > 
> > > Signed-off-by: Robert Richter <rrichter@amd.com>
> > > ---
> > >  drivers/cxl/core/port.c | 18 ++++++++++++++++--
> > >  1 file changed, 16 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> > > index d10c3580719b..e21a9c3fe4da 100644
> > > --- a/drivers/cxl/core/port.c
> > > +++ b/drivers/cxl/core/port.c
> > > @@ -1366,8 +1366,24 @@ int devm_cxl_enumerate_ports(struct cxl_memdev *cxlmd)
> > >  {
> > >  	struct device *dev = &cxlmd->dev;
> > >  	struct device *iter;
> > > +	struct cxl_dport *dport;
> > > +	struct cxl_port *port;
> > >  	int rc;
> > >  
> > > +	/*
> > > +	 * Skip intermediate port enumeration in the RCH case, there
> > > +	 * are no ports in between a host bridge and an endpoint. Only
> > > +	 * initialize the EP chain.
> > > +	 */
> > > +	if (is_cxl_restricted(cxlmd)) {
> > > +		port = cxl_mem_find_port(cxlmd, &dport);
> > > +		if (!port)
> > > +			return -ENXIO;
> > > +		rc = cxl_add_ep(dport, &cxlmd->dev);
> > 
> > On second look, this seems problematic. While yes it will be deleted
> > when the root CXL port dies, it will not be deleted if the cxl_pci
> > driver is reloaded. I will code up a unit test to double check.
> > 
> > I note that cxl_add_ep() for the VH case is skipped for the root CXL
> > port, so I do not suspect it is needed here either. Did you add it for a
> > specific reason?
> 
> Yes, all endpoint iterators need to be reworked. Also true, the first
> endpoint is skipped in the chain. So only intermediate EP structs are
> touched by the loops actually.
> 
> In particular, cxl_ep_load() returned NULL for the first lookup if the
> ep is missing. We could stop the iteration then. I tried to avoid a
> rework here, but maybe it is not too extensive as I expected first.

Hmm, ok, let me get the unit test topology working for this to make sure
my assumptions are correct about when an @ep reference is used / needed.