Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221115142701.27074-1-abelova@astralinux.ru>
In-Reply-To: <20221115142701.27074-1-abelova@astralinux.ru>
From:   Steve French <smfrench@gmail.com>
Date:   Tue, 15 Nov 2022 12:59:04 -0600
Message-ID: <CAH2r5mtaTSih9X6Xzc0HTqRYSTx47vNzStMkXeWYzyXPMqzEFg@mail.gmail.com>
Subject: Re: [PATCH] cifs: add check for returning value of SMB2_close_init
To:     Anastasia Belova <abelova@astralinux.ru>
Cc:     Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>, Aurelien Aptel <aaptel@suse.com>,
        linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

good catch.

merged into cifs-2.6.git for-next

On Tue, Nov 15, 2022 at 8:41 AM Anastasia Belova <abelova@astralinux.ru> wrote:
>
> If the returning value of SMB2_close_init is an error-value,
> exit the function.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 352d96f3acc6 ("cifs: multichannel: move channel selection above transport layer")
>
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
>  fs/cifs/smb2ops.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 880cd494afea..9737296c0fbc 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -1126,6 +1126,8 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
>         rqst[2].rq_nvec = 1;
>         rc = SMB2_close_init(tcon, server,
>                              &rqst[2], COMPOUND_FID, COMPOUND_FID, false);
> +       if (rc)
> +               goto sea_exit;
>         smb2_set_related(&rqst[2]);
>
>         rc = compound_send_recv(xid, ses, server,
> --
> 2.30.2
>


-- 
Thanks,

Steve