Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932123AbXHHXOJ (ORCPT ); Wed, 8 Aug 2007 19:14:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757296AbXHHXNz (ORCPT ); Wed, 8 Aug 2007 19:13:55 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:33816 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466AbXHHXNy (ORCPT ); Wed, 8 Aug 2007 19:13:54 -0400 Date: Wed, 8 Aug 2007 16:13:45 -0700 From: Andrew Morton To: Andres Salomon Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: turn serial console suspend a boot rather than compile time option Message-Id: <20070808161345.4733b656.akpm@linux-foundation.org> In-Reply-To: <20070808190713.b59c9b00.dilinger@queued.net> References: <20070808183535.2a2c6edf.dilinger@queued.net> <20070808154130.9cc3a30e.akpm@linux-foundation.org> <20070808190713.b59c9b00.dilinger@queued.net> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 32 On Wed, 8 Aug 2007 19:07:13 -0400 Andres Salomon wrote: > On Wed, 8 Aug 2007 15:41:30 -0700 > Andrew Morton wrote: > > > On Wed, 8 Aug 2007 18:35:35 -0400 > > Andres Salomon wrote: > > > [...] > > > --- a/include/linux/kernel.h > > > +++ b/include/linux/kernel.h > > > @@ -172,6 +172,8 @@ extern int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst); > > > extern bool printk_timed_ratelimit(unsigned long *caller_jiffies, > > > unsigned int interval_msec); > > > > > > +extern int console_suspend; > > > + > > > > That's a somewhat vague-sounding identifier. Could we call it > > console_suspend_enabled or something? > > > > Hm, how about serial_console_suspend_enabled or enable_serial_console_suspend? I can send an updated patch later. > I prefer the big-endian version (serial_console_suspend_enabled) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/