Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7613964rwb; Tue, 15 Nov 2022 15:13:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf4V11XHVoUMiAOZCqYOqO4q2leuq0+E43OpkdphaA6XuMXz630KRJSuHkc4T/TzRjkNxEMH X-Received: by 2002:a17:903:228a:b0:17d:c0e3:fde with SMTP id b10-20020a170903228a00b0017dc0e30fdemr6429416plh.29.1668554026808; Tue, 15 Nov 2022 15:13:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668554026; cv=none; d=google.com; s=arc-20160816; b=dmcvNC6sNKLeI4hE5IFSvzeBK/yPYLsfgtsRDD8hnuW7K2fQEGyIoGClW1zl3y6W4p xAtnTs33NWGyW6V+1XfdnVUkN1VCj2kUMlzfyOW5cDaSZuCNu+Admv9O1fk4iQUvptC7 3JcOoR9smx9SKPdrxPG7DSRCi9DmGi14XufOrB73BG3pKOnx1QKqGi6tiz/FSAdzVAnf VciwnsZ3BpbVkXJBuV8DSkHMzFSc/Znjh0zzAquG2sWqk2k0+XRU8i4rNEh6kc4UtDzU ILJ6MzxaAtnXZU7Z5eEjime9HfLk4BD5B6resaSOPNBvZkJM9MQbeyb4U3wUpp7uyWu8 nCkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=i1bi2KgOik0BJgrqTOkLO626dlyRqNG/k0Pt8yh+GI8=; b=f5sr/T9zpNhMBZeb9nYYwolMrrSbJsOI5vEqtWB0OiZlkKaGg1mSo9rusxm4BNIjRh J7KVuTkm4yQM+BFOpywo9UOOnxRKKEbv5EQuZjfZ8WICGpR5MxpymHC8aKwinSomKler uH0iweD5YpbRSXEZ8OmikCjdjXKAeiZFeB8AJuZH6m8Dm7DeoBz8GizkAu868soSqoNv z6aglGIqrMYfri8MDGwxGSMSSmKN57QRDMyjzP3/cU8ZTpdpWGOQzNLTAR0BpsY5OyZ7 Sob56UooTmXKIUbthjqetLWw6/NFSSyg/25VF2tTfDsGFgM4hREZZJt5JR4hQLUVe6Ql lg1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c7hinHZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a190-20020a6390c7000000b0046b043d221csi13504265pge.55.2022.11.15.15.13.33; Tue, 15 Nov 2022 15:13:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c7hinHZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbiKOXCr (ORCPT + 90 others); Tue, 15 Nov 2022 18:02:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231580AbiKOXCO (ORCPT ); Tue, 15 Nov 2022 18:02:14 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62B512C67B; Tue, 15 Nov 2022 15:02:11 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id i10so31281867ejg.6; Tue, 15 Nov 2022 15:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i1bi2KgOik0BJgrqTOkLO626dlyRqNG/k0Pt8yh+GI8=; b=c7hinHZD13uIeXD27stsQQGXPwFZhVLI48+Zy3BvZRiNxOzold4KncLYVDUC7PyVqU D/aiFKPiryug78Cf7+bhbkrK1GXs10x+FkfrryLTT9ORfRixyyaWAd002zhMBntDIJv9 /VY8dq7c8UPOUnp+d+OuCbokWQj69rxJ141BruXSiwIqm/6J10I74PAX07TzgahA8imh N46smD8qJrxEzvEQHaCOF+Wy1q8BWrmsHLysuasahWTi+LCVOQgKjjT28ER5OWHMw658 fGbyxuzqDBXFe5Z75e0Ms5+lREciyWTEHC399z8GY3O+6DpFvjDRl6dt3MC4mmN/40eC 8VEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i1bi2KgOik0BJgrqTOkLO626dlyRqNG/k0Pt8yh+GI8=; b=3PV6Gy9eIM3pW2feKvoSKHepM4M6eEpDfhfqOtbCp6LuIyj4YUzK/1tgQjSmtEjXpO FsvOOD8Ny5i3ihqJ4H5Y0csQGtxQx3lMqylm2ntA5kf6cqntHXNGoxUWoIFElfLa1Miw APyvmrHFgsy7kLinZeabzweoaGRj/tZU8dFXeGTlDMyLpenViLLNVh19rkyBbj5rcMdp aRouu8sAC9b0yb1hiI/mhoJ+CPexzBQwVoN8n2Wg0fSL+Fsd6fYjYIQFhnT79XmW1eIm LKOZvHcGq6lEEo0L2+Zo0pCfYPUov+r+kEUYgX+Kprt35ySi+ji2HE6oB38nX7qZriqa nODQ== X-Gm-Message-State: ANoB5plgNLrQgNM8Paxnz5tCmAiWApbeTs6rmfVeFo3gjVTBgsX5jeYb 2087HfZ9uWU2ewEtHUBCs/0= X-Received: by 2002:a17:906:4456:b0:7b2:7e7a:11c1 with SMTP id i22-20020a170906445600b007b27e7a11c1mr1436499ejp.684.1668553329925; Tue, 15 Nov 2022 15:02:09 -0800 (PST) Received: from skbuf ([188.26.57.19]) by smtp.gmail.com with ESMTPSA id f24-20020a17090631d800b0073d81b0882asm6127366ejf.7.2022.11.15.15.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 15:02:09 -0800 (PST) Date: Wed, 16 Nov 2022 01:02:07 +0200 From: Vladimir Oltean To: Sean Anderson Cc: Andrew Lunn , Heiner Kallweit , Russell King , netdev@vger.kernel.org, Eric Dumazet , Tim Harvey , "David S . Miller" , linux-kernel@vger.kernel.org, Paolo Abeni , Jakub Kicinski Subject: Re: [PATCH] phy: aquantia: Configure SERDES mode by default Message-ID: <20221115230207.2e77pifwruzkexbr@skbuf> References: <20221114210740.3332937-1-sean.anderson@seco.com> <20221114210740.3332937-1-sean.anderson@seco.com> <20221115223732.ctvzjbpeaxulnm5l@skbuf> <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2022 at 05:46:54PM -0500, Sean Anderson wrote: > On 11/15/22 17:37, Vladimir Oltean wrote: > > Was this patch tested and confirmed to do something sane on any platform > > at all? > > This was mainly intended for Tim to test and see if it fixed his problem. And that is stated where? Does Tim know he should test it? If you don't have the certainty that it works, do maintainers know not to apply it, as many times unfortunately happens when there is no review comment and the change looks innocuous? Even if the change works, why would it be a good idea to overwrite some random registers which are supposed to be configured correctly by the firmware provided for the board? If the Linux fixup works for one board with one firmware, how do we know it also works for another board with the same PHY, but different firmware? Are you willing to take the risk to break someone's system to find out? As long as the Aquantia PHY driver doesn't contain all the necessary steps for bringing the PHY up from a clean slate, but works on top of what the firmware has done, changes like this make me very uncomfortable to add any PHY ID to the Aquantia driver. I'd rather leave them with the Generic C45 driver, even if that means I'll lose interrupt support, rate matching and things like that.