Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com>
Date:   Tue, 15 Nov 2022 17:46:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] phy: aquantia: Configure SERDES mode by default
Content-Language: en-US
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        Tim Harvey <tharvey@gateworks.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>
References: <20221114210740.3332937-1-sean.anderson@seco.com>
 <20221114210740.3332937-1-sean.anderson@seco.com>
 <20221115223732.ctvzjbpeaxulnm5l@skbuf>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20221115223732.ctvzjbpeaxulnm5l@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2dyZk5CNGZ0WWgyRk4veldidmlDWU9Jcjl6SVdab0hiSE9WdytEbXBiejZQ?=
 =?utf-8?B?MzdYWnZENjBZeFE4dTBVUWFURDR5L0liSXE0NVJweUtvYzVTSWJZYVM5a3N6?=
 =?utf-8?B?UWpobmxXRkZYQ2l1T3M3OVd0TEJ0VFFoU1dnWGRrc0lhVDlyZVgzTTAvZWIr?=
 =?utf-8?B?eEFIQkN3MnBUUHBOVXhrcVlkOFhhSllYT3kwMG9iQXdPRUc5TjJXYmZJc1oy?=
 =?utf-8?B?MCtndGZTejdZQmlRL2xSZFcrNTVRWFVlTmUxYnFJMTBtZisvQkR2RDc5SzZp?=
 =?utf-8?B?Y2R2V3BQM3pHNWUwbVpCVjdQUWRNQVlRSVZYT0thL29TRzNNM3hjWjNJcG14?=
 =?utf-8?B?UzJrK3JTblhaeHo0WkwzZ3J5aEhWaXlDa0JSZWxSbjRUNGZHOExpNE8yL0U5?=
 =?utf-8?B?bUhabWVYMS9HMkhOZGtWVVh3ZCtMbzlESHVUckdzSGUrRWZxWUhOQ1liYlFp?=
 =?utf-8?B?T2JzMzlRQjh4aDNsNFpSeDM2LzZ0djNNcjRhOTVkR0tJOUh3VTlrdFFqekFm?=
 =?utf-8?B?ejJ4YVRSSnpjVHZ0a1V0Y2xmMHBGc3hYd0l0TW1HbE5rZnVJTGg3SjRUem92?=
 =?utf-8?B?TC9JMVByeTFiWkJLL2RudktMaG8zVGQ4TnBmRjZOcUJaWmZzcjJBdUlaUjdH?=
 =?utf-8?B?N2d6QlQxUktvOVZWRzNBT2FkNEhVSUVDeUxuemJpLzlqYWlRY3dvaG1hT1Nz?=
 =?utf-8?B?T29kMzBRK3JuT1ZGVVlaNEE1OU9vbTFRVVVVOGVRM040bThsNUVNUTVyajZs?=
 =?utf-8?B?d2s1SEQ5bDFqOXlDRGNkOWdWNlhzZ2NGV3FucVJEM215YlNtZHExWkNGbFE2?=
 =?utf-8?B?OS9SZUZiL0hiZGtjQ2hmSHhONW5TdlFOaTQrMVZrUUNHMWRPeHRBUWlSTEhh?=
 =?utf-8?B?SmFQOTNKLzl2d2hYaVRWVHk1OUk5WjZYRDBidVFvKzNtOUVjWitCN01XRlJx?=
 =?utf-8?B?MVhhZldZd0kyclZpSk5ka2JFL0NFUCtGenluRFVPTTdCdGlqMittdE9NMTBo?=
 =?utf-8?B?anUwN2RkRVpoK2Z6bXdNR2k3WjU2STgvUjBaWkVUSjNoTHZIUWM2amQzckZN?=
 =?utf-8?B?UEpMU29PclZkVm1XZEpLeDQwQlBZRWlYUjdES0ZrakpNSDR1OTdJWTAzdUJZ?=
 =?utf-8?B?ZTVTc0FseTIwaTBjMGZLdEwwWUpnV2hidHNYQVhzT2JoUmtyeTQ1R2krMk1z?=
 =?utf-8?B?c1Vqd1pJVlhSQ0xRNTFKdjZLWENNZmlTREE0WTNxMjJXY2pTN1dtRENxUFcw?=
 =?utf-8?B?dG1DeUxuTHc0VlY1bC9ob0pZZ1dDa0U1U1NUMDBkMmtUOVNOckRRWklBRnpt?=
 =?utf-8?B?TlRtbEhOZmhYRXNXOFRLSDR5alRxQTBkWTBJSHdlY21nN3VsTXE0eDAwT1pO?=
 =?utf-8?B?eUowQUl0dXJZNTRhN05QYmgrbi95a2JQN3dReTZQQmhWb3NjQ1R0NmcyVlIz?=
 =?utf-8?B?V0g0eHRPVC9paHBQTDdDZEFNaHFiWW8yblF3bEF1QTd6MEdwVU94T1NCbWcv?=
 =?utf-8?B?cUFuL1VlR2Fyamc0ZlM4MldxeVdGdUZRWGorSGJSMFdWVWlvVktwZXpodWVj?=
 =?utf-8?B?SkJRaUlVdlYrVFQ1akJ6NFBFVy9uRStjL0RaOGxxR2huK0t6UGVNYUNxdlZX?=
 =?utf-8?B?Nlh1TjNiSFRNL1NveXE2dEs5UTc0MGUvWnI3aVNQTDBEZkkxcTg3MlQ4UmRB?=
 =?utf-8?B?RG8vRVZaVjdTZFp3MVFtRnBmMWNtWEFoMS9LZFJiWDhJRWJuTUpGb0FYMW9R?=
 =?utf-8?B?MXdrY3BJWm1zcHg0THRwVlIxbFFPS2NxU3ZVb1gxL04ram5qUVpxby81bm9o?=
 =?utf-8?B?eVUyNE1kVnppNU41OGxXTTFUNXhybE0xM3ZUeHJvdE4yT3FNLzVHWStYRFlM?=
 =?utf-8?B?bUQ0bmFublhzWlh4M0wwRmR5bmhsMnpXTEJBcUo0V3NrNHdPQUFhQW13dFJ1?=
 =?utf-8?B?NDd0cE9tZjIrem1CKy9MNmFpb0FVNUh4ZkM0YVVFVkpOQVltOHJmTmhENWhD?=
 =?utf-8?B?QkdXcGt5WG5OcDlpWGFzY3V1RUlDN29Famtqc0hNMWRibkRSWlBxUk1uTDlr?=
 =?utf-8?B?ZVdlcmVIVnZNeGZic3hPN25FcUZhem1NMTNwb3g0bmFOS3pneW1qYnRJMDFZ?=
 =?utf-8?B?eVp4LzRUdzVJVzFaajF4Qmx1SE85Tmd6ekFGVnU5TXB2WEp6Z3JIVWNtTTQw?=
 =?utf-8?B?K2c9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df95cb65-bc6a-4ed8-b263-08dac75b4dc7
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 22:46:58.9261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OKyS/l+26KbWmXhjIsw6QasQQZmh2sYFQNZBNhbRHWAFyMngDiLUyYn5p1Xy+IN4yVYpB6LXpvJJj6XTNsHRtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR03MB9347
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/15/22 17:37, Vladimir Oltean wrote:
> On Mon, Nov 14, 2022 at 04:07:39PM -0500, Sean Anderson wrote:
>> When autonegotiation completes, the phy interface will be set based on
>> the global config register for that speed. If the SERDES mode is set to
>> something which the MAC does not support, then the link will not come
>> up. The register reference says that the SERDES mode should default to
>> XFI, but for some phys lower speeds default to XFI/2 (5G XFI). To ensure
>> the link comes up correctly, configure the SERDES mode.
>> 
>> We use the same configuration for all interfaces. We don't advertise
>> any speeds faster than the interface mode, so they won't be selected.
>> We default to pause-based rate adaptation, but enable USXGMII rate
>> adaptation for USXGMII. I'm not sure if this is correct for
>> SGMII; it might need USXGMII adaptation instead.
>> 
>> This effectively disables switching interface mode depending on the
>> speed, in favor of using rate adaptation. If this is not desired, we
>> would need some kind of API to configure things.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
> 
> Was this patch tested and confirmed to do something sane on any platform
> at all?

This was mainly intended for Tim to test and see if it fixed his problem.

--Sean