Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7677413rwb; Tue, 15 Nov 2022 16:15:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf6wM1C7ld8vKZmy6GJh57AJWfIS1lkttrOdL098CZbaoWHPMSQwqJTWP9H8LnOf/I91ABl9 X-Received: by 2002:a17:906:b855:b0:7ac:f8e3:d547 with SMTP id ga21-20020a170906b85500b007acf8e3d547mr15780196ejb.53.1668557747128; Tue, 15 Nov 2022 16:15:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668557747; cv=none; d=google.com; s=arc-20160816; b=xaX7/udFclH7K5227qSRheMnAaVz50eRGp2zHsaDlD24DQkhh2c2icSBKQjDI3ofDI lfgtL2/RifTOPtrNxRgf0wMyq1SYn2ftjAkXNutDJJk2cZ1xKK3StS7L+46HrldiSh98 TK3RTRcZY0oEDIMk/NSa/KSZ1eAgarybSnY2OzoYpf7mz1CMOMvZXzm4Bh3dyajYzwZF mD3t1yteNTYORmVUREuD0cixXjsLIakEp8D8AEWV5caN/j+5PFDNtwl+hF0iQX6WO5Vj 7HLfgMIkb6TobnlSGKKThX0WLAyDAuO6g9Hj8uBZfGSHAQZujMCyodaxnfgvZmGf8lDs TQqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=sgz5o5DfbV3xr4Xq9yVshHOHM8PL4ue2OQGWIUkyU1s=; b=OsNjRT3ZBO800k0oIf3njGHK/OEa0Itv1q3qOumoPn7a+PnwQZKH4rkv8vrNGezN2b k8u2G0l/+fPlWg/yBg81W6ximUlSzaxu3dhMNljlzlwmiR/C4E0d2CVMEaEsja4v8ntW JKrAb1JWPEoNKNBxcQbrwn3UZ6dOP8WVDlj1oPlFBn64EY9tc/hfvjC8tLC2KrxSF6Rp p4ONpfGnDhQe5cE0ty74atxa5ozdcxiv3aSk1x8b2f/eRsPO1BUTM/+c3h9HSaQax3rI c1cbUePFxhEzeaYY5oK6BXkatm8eLofp6zosZ04CfHwDnYm2Q0DLw67daUci2jN3sFyU TFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bvYH+xNX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf16-20020a1709077f1000b0078dad659776si15325254ejc.320.2022.11.15.16.15.25; Tue, 15 Nov 2022 16:15:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bvYH+xNX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbiKOXcw (ORCPT + 90 others); Tue, 15 Nov 2022 18:32:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiKOXcu (ORCPT ); Tue, 15 Nov 2022 18:32:50 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF8E959E; Tue, 15 Nov 2022 15:32:49 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id m14-20020a17090a3f8e00b00212dab39bcdso705918pjc.0; Tue, 15 Nov 2022 15:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=sgz5o5DfbV3xr4Xq9yVshHOHM8PL4ue2OQGWIUkyU1s=; b=bvYH+xNXVvSAx6vKiudIS7G2gSJ2PXBec57nPAoCI7pb8hJJVorTvTe5Db4rDHP767 0n9W2FIPaIYlx5/n/E3ALoMcbBc75QD7im8Xau1UITFiysk7f05bXYx7pfJRtEkec3SP Ho5R/aC2Yi7x7mnwtf7e7SFceKI5SJupC16pBGjlJvfrtnt5eYRs054Aqas/cB9A7Sbo ePWdhJaWPzkbfp49I9NvV3T6DypSO/ZcLa3fHE/ThfoMKidxs6M9DagoDpaVVtyyfsUl AgwZLLk3me+xp+Zqi2wWku4Yq10ZEGdRkjPCv34ylfieTD+GFlM+SxcHEk3E2wW2wwvm +wGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sgz5o5DfbV3xr4Xq9yVshHOHM8PL4ue2OQGWIUkyU1s=; b=J/qfq3RqCpgGKtU4h6tH/TFlbRaf2wBCSUhLWqcG2aZpiskqBwjLTzU0qPJw9VF7jj czDCaUdpLkR1TPfouRF16L1YQktLa6gOOZof7o/n5MhQYBMbqDQL5F1Vx7qBOIqlzR+1 feJUaoI0vT3ZKkRC+B7E4mNe1ZA9pxQLR72VwBJ4zmBQxjVNkNSj4Hx9rXcNxYiGRo7Q hCvw/oBGCi1g5sBaYkPUjkGiDteP9Io9tdMECkChRcJj6FqZTYZJjQtBpcHE8xbSbOEi OIv9RjCIYcnci3uDzFpZlSwKHLDQFeT1Eo0i9sZ/uHTgnTvuNhQPNQQMAysWxR9UXjBS klKw== X-Gm-Message-State: ANoB5plaSqgfvgQpNxW2c0s9qsY3F3CUIMble2LbSWwUDO5mld+g0T7S kyNXebECjYF5RtP05ZGE3vs= X-Received: by 2002:a17:90b:3756:b0:20a:92d2:226a with SMTP id ne22-20020a17090b375600b0020a92d2226amr746946pjb.155.1668555168942; Tue, 15 Nov 2022 15:32:48 -0800 (PST) Received: from google.com ([2620:15c:211:201:6ff2:4caf:5d97:1932]) by smtp.gmail.com with ESMTPSA id b193-20020a621bca000000b0056ddd2ac8f1sm9351873pfb.211.2022.11.15.15.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 15:32:48 -0800 (PST) Sender: Minchan Kim Date: Tue, 15 Nov 2022 15:32:46 -0800 From: Minchan Kim To: yang.yang29@zte.com.cn Cc: ngupta@vflare.org, senozhatsky@chromium.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xu.panda@zte.com.cn Subject: Re: [PATCH linux-next v2] zram: use sysfs_emit() to instead of scnprintf() Message-ID: References: <202211152004478289568@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202211152004478289568@zte.com.cn> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Nov 15, 2022 at 08:04:47PM +0800, yang.yang29@zte.com.cn wrote: > From: Xu Panda > > Replace the open-code with sysfs_emit() to simplify the code. > --- > change for v2 > - realign params of sysfs_emit(). > --- > > Signed-off-by: Xu Panda > Signed-off-by: Yang Yang Recently, we added one more stat is using the scnprintf in mm-unstable tree? recomp_algorithm_show Could you also change it? Thanks!