Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Wu <wupeng58@huawei.com>
To:     <zhuyinbo@loongson.cn>, <arnd@arndb.de>,
        <loongarch@lists.linux.dev>
CC:     <linux-kernel@vger.kernel.org>, <liwei391@huawei.com>,
        Peng Wu <wupeng58@huawei.com>
Subject: [PATCH -next] soc: loongson: Fix an IS_ERR() vs NULL bug in loongson2_guts_probe()
Date:   Wed, 16 Nov 2022 00:51:23 +0000
Message-ID: <20221116005123.81140-1-wupeng58@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

The ioremap() function returns NULL on error, it doesn't return
error pointers.

Fixes: b82621ac8450 ("soc: loongson: add GUTS driver for loongson-2 platforms")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
 drivers/soc/loongson/loongson2_guts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson/loongson2_guts.c
index bace4bc8e03b..52c222b1e6ef 100644
--- a/drivers/soc/loongson/loongson2_guts.c
+++ b/drivers/soc/loongson/loongson2_guts.c
@@ -108,8 +108,8 @@ static int loongson2_guts_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	guts->regs = ioremap(res->start, res->end - res->start + 1);
-	if (IS_ERR(guts->regs))
-		return PTR_ERR(guts->regs);
+	if (!guts->regs)
+		return -ENOMEM;
 
 	/* Register soc device */
 	root = of_find_node_by_path("/");
-- 
2.17.1