Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yinjun Zhang <yinjun.zhang@corigine.com>
To:     arefev@swemel.ru
Cc:     davem@davemloft.net, kuba@kernel.org, ldv-project@linuxtesting.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        oss-drivers@netronome.com, simon.horman@netronome.com,
        trufanov@swemel.ru, vfh@swemel.ru
Subject: Re: [PATCH] lag_conf: Added pointer
Date:   Wed, 16 Nov 2022 09:55:28 +0800
Message-Id: <20221116015528.25334-1-yinjun.zhang@corigine.com>
In-Reply-To: <20221115085637.72193-1-arefev@swemel.ru>
References: <20221115085637.72193-1-arefev@swemel.ru>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zQrKm6IhxmGLCyL2jA8Nflvm5i5scalOVe2SwHqlm0fLzA7l5DdERCS0xElo?=
 =?us-ascii?Q?UQcpnIQsEjqUp8yNVo8PZahz5KiielWnIsua5m51E4EmeXOjFkdUdsFn2AcI?=
 =?us-ascii?Q?qLiqbRu/hDMyJ0VsIWteKGNw0Zhii7blZk1ilHX6FHc0ME1/ZTr8ONGLfffG?=
 =?us-ascii?Q?MCCB7DCp93g6d8xlqaW4+UTCdX5lB/AWUCoolz9Lxl08I7F1iNBsBTkXGmXK?=
 =?us-ascii?Q?KTb/PCc0gKlokSigcLzp0E3xRkNN+AZ0wK1h62zKVYMQ85Xkf32dvN0XJhXG?=
 =?us-ascii?Q?TUm+umI4FsW17gkODIrjr65z+CjxScY4N04sQBrhjpKL6iihjprjXr5GfT+B?=
 =?us-ascii?Q?Hjmtcc7jYuqP1EoMCxdHnXbfpzTBHGsVr28P5hyMG/EmlXIwAyuU7Q3FOynd?=
 =?us-ascii?Q?J/b2w4rqyVQeqJvv/c2qtsR58o2C56zv9xksXtMIl+600xXt8698Fnl0VcMM?=
 =?us-ascii?Q?19q47QMy0qafKtGQzbJSXuo7CmU5bzBIZjj5f00hJHzz9gBooQeyC6F00jww?=
 =?us-ascii?Q?voMIOXKDDTfSuZEEj8irbKuuE92+EI8p6bVoo12+8HjOps/HK65iMYiRZudG?=
 =?us-ascii?Q?C5rxrG8k+8tZeSG70K/iMO/ZeOX/sw6mYMqbtYlp9xj3v6v4h8DphRl6aBS2?=
 =?us-ascii?Q?NtwYJOWuy2xBvHHecSzekYpKDzF5Fo9AIZWCE0Fj+KIoBUacDRZj3y+xMEJt?=
 =?us-ascii?Q?FazJUxk+5ulYp3J0idDQycDd7wYe8SD8qoHu/R0UrJxO8RACC/6/e4OR52J7?=
 =?us-ascii?Q?9EqLXMadZp4Gd5I9q9+wYRl27mLCqo1Q3MHKmY1uhBB8RV9F/h8AbSM5WhpP?=
 =?us-ascii?Q?DYccpWcNqPLcevQUhd+Xm4EoB7rk7IG2lVM+Ky4Sjv6GDGeuYSCnVKvlNXcb?=
 =?us-ascii?Q?nBivvxViBloNYN8y9/ZwiMrNNG39xhh3ERr9x5cmZn3z7qgxV/8k3QSJxaQm?=
 =?us-ascii?Q?XKM7fmPkQJklQdtsm8+IHqLUfnkou34cR/bIhoz2/8ZDD+JHa20A9aiBD53r?=
 =?us-ascii?Q?uu1abjMHafgWRaQmseLdCEcz7jxqQiImzqR6XhZ5CrGqhLzit5IAlAcaXcSH?=
 =?us-ascii?Q?F9rC+4ogJ59C8qFtt8el1743w0YsE3vd48ihKIJEHhCwCQtBI1d0ECiEc4CP?=
 =?us-ascii?Q?TUaPTfKZbuK6HE+5+cvHpdCcF8ythAYlVfT+aJBQEWBKEj12empJFMGNOVJX?=
 =?us-ascii?Q?1LV/EMWtYKE6HLt0xVJkeiOaFw6Fc0C0jgglIc7cZGbdmz/Q2qKlvPKJMZhm?=
 =?us-ascii?Q?seMTPLaf07Lm7JeehttbkiqzljNC04QUX87XQ7Fih8nrjnH2rgnPRDmEkqA6?=
 =?us-ascii?Q?yXtEtF8+PJzWXyMiGjqV7eNW6C5s9IUSeSt9xYHQb79Otq/B3xYCCWwuEd1u?=
 =?us-ascii?Q?rq0uqpQegWCAz0EhmYYPdn947zaNOfEAqMntSP3Sh6Px80JETJ2bS/JQmANW?=
 =?us-ascii?Q?fFqVNrop5W8FHr7feC11rI5VE+rqLVLBkk0q+VA1PSkF1ugq5U/LQnfzXMgy?=
 =?us-ascii?Q?P8vj8dRjYDzfmE1+YlH708sQndJ5Gmqft97CwndH5QSthb4ToBeUP3+HjAph?=
 =?us-ascii?Q?pUL6/7D87sJHW+qzIr6uJi6TOjyuFd4u+BrnkqApjRAkjBczVuPojnmYGP2w?=
 =?us-ascii?Q?Kw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b928969a-9070-478e-b584-08dac775a78f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB3705.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 01:55:36.3755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uCy8N2OVTrlk6z5d+LTFOX5cfx9BelHh9TI0d9o4XcUGbQrKW/tByXEIodQdjNsbBf1BxmG4BoXTgOtr8gHeEquWFALOYtp6SB65iZd+xUA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3729
X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SORTED_RECIPS,
        SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 15 Nov 2022 11:56:37 +0300, Denis Arefev wrote:
> <...>
> @@ -308,6 +308,8 @@ static void nfp_fl_lag_do_work(struct work_struct *work)
>  
>  		acti_netdevs = kmalloc_array(entry->slave_cnt,
>  					     sizeof(*acti_netdevs), GFP_KERNEL);
> +		if (!acti_netdevs)
> +		 break;

I think we need give other entries and this entry itself one more chance by:
```
if (!acti_netdevs) {
	schedule_delayed_work(&lag->work, NFP_FL_LAG_DELAY);
	continue:
}
```

>  
>  		/* Include sanity check in the loop. It may be that a bond has
>  		 * changed between processing the last notification and the