Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp25925rwb; Tue, 15 Nov 2022 18:28:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Qu8c7u/0fudLXf5vIp0LXMxY900q7XlchrGbNWfy1J67KGna9NzYP13+oJ/Mqk/h0pU1c X-Received: by 2002:a63:cd09:0:b0:46f:f911:eee with SMTP id i9-20020a63cd09000000b0046ff9110eeemr18847001pgg.432.1668565700316; Tue, 15 Nov 2022 18:28:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668565700; cv=none; d=google.com; s=arc-20160816; b=WV8qx5L0aMlRDHYUz2xU1Gkt+l3IXKMZRhkj0MibaR+Z+Cd4+ssed2xVDljYijBnr2 xlhE6O/H726+5LR8/+Q8dqqFERzTfo3qORCHuWoMI1bg+PdbA+/Ta4SmXom3LMCW8eJm XG9nFQ4SsjPd66g1k91AYKvaT2wW4K1SDixXx0TGlzHWqwf7KjkQYW+x+EORMsYNTGoA stI57AUjl5oJ4bXNsfJcu37noI//mH1oMzuqCOgejKInQJ8xuOqkrT+y8fAekixlvufO Xtd9Q5arUVwOPr0Rde+VbjjVO/4Hk/dgV7GYSlkpk49Me03VclpKcNzORtJij1031J7X BNAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=3gbgW/mF3J+HySRfesQyRT+kCtF3aU4PVWLR4rJXKAo=; b=Do5K65CcAyAd2WxkalY3vaFbxk4pyVVvnPRiDeCoEh3c5ImKs3ppk49pg3NELEHeNU rbKUyxLrbENB4q/JJRFxMghYxL/i47p4ZQCyCjzgOgovNZDZT3PgX2Jypm1h1zko/461 RB3uOn0gI8pRne7YXkMcG1Z68eYIuE5qKXxUnjfuBtdmJDg0u5PJOr3npnZ3fs6m0aGf 3/a7C3AYQNl0m1t9Hvyx9jhuLoGsedTLIyGEX3Md5m5tYBAnaqMLNaAEAOL3koOOkD+u /YDw4YmHv15t7meFykl4WP+Ic2rt5gDnMv35YtfOf0j6kjwG5EpjdZO+uygodq+HSMRo +0xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uGjS/ZhH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a17090ab38d00b0020ae29877besi629395pjr.20.2022.11.15.18.27.17; Tue, 15 Nov 2022 18:28:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uGjS/ZhH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiKPB7i (ORCPT + 90 others); Tue, 15 Nov 2022 20:59:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiKPB7g (ORCPT ); Tue, 15 Nov 2022 20:59:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D4D2A729; Tue, 15 Nov 2022 17:59:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 919CFB81BAD; Wed, 16 Nov 2022 01:59:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF045C433D6; Wed, 16 Nov 2022 01:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668563970; bh=3gbgW/mF3J+HySRfesQyRT+kCtF3aU4PVWLR4rJXKAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uGjS/ZhH2tdtr33vigSv782c/yVm0NjtspgLOl1M4z66HKgmu3iCsBcy5c8q3Ouqs SyVHKXhemtsWkGTFfAyI1Bn9P/ikATL4YKo1GXNMRsmIKewHlMJ5NiPDjLNhzE3PQx NEAFB9l7MMdtwrkjvmrHvOTuF8j+Gp6TOL1iThVs3skIkBzVr5wJD8wboVr5VNCwNL QP81dYsivOPpMND5qtN+IbQ9Lb1EldXdlq25M83kb2ZXYUSv1glL22CE5DOrzq2K+M oyuiu7Wjs4Jj6RgfgQq/IakJHmuOcUY78o9pWCNChru5agch+kMLvqzeh+O64tSPX9 uM8pdNSYRAUKQ== Date: Tue, 15 Nov 2022 17:59:29 -0800 From: Jakub Kicinski To: Rasmus Villemoes Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports Message-ID: <20221115175929.7ba1e566@kernel.org> In-Reply-To: <708663f3-8e48-5e0d-a988-8d66ede02543@rasmusvillemoes.dk> References: <20221111161729.915233-1-linux@rasmusvillemoes.dk> <20221115074356.998747-1-linux@rasmusvillemoes.dk> <20221115083828.06cebab1@kernel.org> <708663f3-8e48-5e0d-a988-8d66ede02543@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2022 19:55:24 +0100 Rasmus Villemoes wrote: > OK. I think I'll actually do it in three steps, with the first being > this patch but with NET_NAME_UNKNOWN kept in both places (i.e. pure > refactoring), and the latter two just changing one assign_type at a > time, so they can be reverted independently. Even better :)