Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V5 07/12] arm64: dts: imx8mn-evk: update vdd_soc dvs
 voltage
Thread-Topic: [PATCH V5 07/12] arm64: dts: imx8mn-evk: update vdd_soc dvs
 voltage
Thread-Index: AQHY+NLkMsIJTWCTDE+Rd0hYrBnN864/wTKAgAETwlA=
Date:   Wed, 16 Nov 2022 02:31:49 +0000
Message-ID: <DU0PR04MB941782A4B6323FB9405808B588079@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20221115091709.2865997-1-peng.fan@oss.nxp.com>
 <20221115091709.2865997-8-peng.fan@oss.nxp.com>
 <20221115100251.7hwpnodgxzirgpw6@pengutronix.de>
In-Reply-To: <20221115100251.7hwpnodgxzirgpw6@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tWGUR7++aULAmHU4vjXR/TaqW8EqlLnHy+5cSHvjo4fXtkTgcFudm+k0mBdS?=
 =?us-ascii?Q?0R2rgl5+yG8QEffXvRRjuoWQEV95HT7zxSxNKhHVpyYuLdXc9ojywIvU/ulF?=
 =?us-ascii?Q?S/ITVQ2QJNonH/4qdiw5IepSOrV/2WFnDtriwaUwwKkOITIUIh6sgJiT/OmQ?=
 =?us-ascii?Q?4bYLTw8MpasUMwKkHJiGOpIx/KiD5hPY8hmeQmgk4oyZkSxrfJDVCDsWXbIO?=
 =?us-ascii?Q?izz2FByksUB+/y1LslgMoCV0lbfPuaS35bMyFJpylEHhQUEvfQ0QXOQUdpie?=
 =?us-ascii?Q?xZg69LEkv4C+a7UzzpgdrDr0HKsf4spEOtqTP8glECrX01pmEM9wpEqL8/KA?=
 =?us-ascii?Q?qJsT4o7bwQX9yk2ueYrsGmab/23ClOyTxu0VBzGUqChM1TfO6so7fGQObVGO?=
 =?us-ascii?Q?tqXcvYQaHtc2RLU70VVBI8VD3kA9zYFKMRFiaDwfkAMFlq4k8JqEZfqw68CT?=
 =?us-ascii?Q?wRQwd/IwCtl6T14fS167JTGE9aenOYx/trva8QNCerlh7OvnzRHmypxioy1a?=
 =?us-ascii?Q?DjwJftL1p00Q42toj+SX2LS0yOaiKd2dywoKyRw0QlfiDbe+LjfWS1T/sP5T?=
 =?us-ascii?Q?oMMnD2TVy8gD6u5YbsM3aAwX0kouoePKV2cPowGKv2H3ANkYGN3KR9R3mPmv?=
 =?us-ascii?Q?tWSfoLWglPqCqC6Je1yo+6iQZ8A/BezGJA7rTl9F1PDBLo8idZZMBm4gIsxJ?=
 =?us-ascii?Q?6YCZT3ey0VANMYH3Ae72idMi+JgTeclL2zNJP0ZMp6okfdW+DPhAbP71xv7r?=
 =?us-ascii?Q?ncAcyO9vU67NgKCxa4T93u47qn7a4lhNPHxZNCrPcRHIs+i0+1OiTh2klKlf?=
 =?us-ascii?Q?7VikY9IAHDlDYIzfYiPRJGDG4QRENP8uxGZy49F5oo62aiRtTxHjCIzRC9kF?=
 =?us-ascii?Q?2EQJ+IKOcwkqg6V+4xBzo9yANoF05D/Uo+HV4sQWM9FUynxUHlYwYTYNvXXJ?=
 =?us-ascii?Q?LkPbV0jx/TD4aftFcEvAKp74ZVyEbxZA19lF8QN7Fm7hF7seTb2oNvntaSAM?=
 =?us-ascii?Q?GViEVVPdtQtZngvpiQS4SpcCt5iywsK54eqod0IS1ddvzlVoXEat8+bO7gL0?=
 =?us-ascii?Q?6JSZZ3At99avgpfe4+ToJB0PxW0w2VVzO2XE81fSKCHVgesAquOpHwGgs7ha?=
 =?us-ascii?Q?3cEJrQLtSYWFQGom71Wlfk+g3OwsmsL3PpWm11W57u0h8MmfQinfX6lpkFIw?=
 =?us-ascii?Q?ipRTdWdWwcuxfI97aeHrlR9CnJidnDu0dkjaPkMgktBU1k4MEqSbz0+tHpar?=
 =?us-ascii?Q?642Fx4HLhOFEz02SyNughFTMr2Jn+veF+VUtTCuZdCy6CdE+NTv+tL7E9buH?=
 =?us-ascii?Q?S4PUDIYzMfM5NI50DyypcVFXudK6qS6K6oBAlNkGGccpP7lKyP+IwC6YBlbH?=
 =?us-ascii?Q?mI2gAqJUm2Dwgn+jt0teCvMJi2Y4+ZMOjGLwdg7dnlj71eXhon7orlPY9l25?=
 =?us-ascii?Q?5/+LaCdoripD5L3Gy9hYARzdwWGRwmHgOrbLMJTyY/sOMjjxKyqQtRCfLVqV?=
 =?us-ascii?Q?ksqGEl/aXuIUa7zCrnDX2UtDijM/5oGF22Yh7WFtlObYz/EMF/rdvP0OMGoh?=
 =?us-ascii?Q?Lfwo9BN3GBMHaxigIxM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed43bd97-f14e-4b7e-74ec-08dac77ab718
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 02:31:49.7492
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jMdyVmhINwZYiWbsg7TuWxEr6S8QZEpFCNq42r9OG+RWBPzV0QI8be+lZSYk/BJCHYr8AgM+a3zhEUXi9D87PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7535
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V5 07/12] arm64: dts: imx8mn-evk: update vdd_soc dvs
> voltage
>=20
> Hi Peng,
>=20
> On 22-11-15, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Per schematic, BUCK1 is for VDD_SOC&DRAM&PU_0V9. The
> > nxp,dvs-run-voltage and nxp,dvs-standby-voltage need set for BUCK1, not
> BUCK2.
> > BUCK2 is for A53, which is handled by DVFS, so no need dvs property.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > index 4eb467df5ba7..a5a7d74ec1d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > @@ -47,6 +47,8 @@ buck1: BUCK1{
> >  				regulator-boot-on;
> >  				regulator-always-on;
> >  				regulator-ramp-delay =3D <3125>;
> > +				nxp,dvs-run-voltage =3D <950000>;
>=20
> One last question on this. According the schematic the max should be
> 0.88/0.945V and you are going to set it to 0.950V.

No, my schematic shows the TYP voltage is 0.85/0.95V.
>=20
> According the driver the nxp,dvs-run-voltage is just the same as the norm=
al
> regulator voltage. So I would suggest to just use the nxp,dvs-standby-
> voltage property to enable the DVS feature since the run voltage is alrea=
dy
> handled by the regulator-min-microvolt/regulator-max-microvolt. So it
> would be just:
It should be fine to not set nxp,dvs-run-voltage, because bootloader alread=
y
set that.

Thanks,
Peng.
>=20
> > +				nxp,dvs-standby-voltage =3D <750000>;
>=20
> Regards,
>   Marco
>=20
> >  			};
> >
> >  			buck2: BUCK2 {
> > @@ -56,8 +58,6 @@ buck2: BUCK2 {
> >  				regulator-boot-on;
> >  				regulator-always-on;
> >  				regulator-ramp-delay =3D <3125>;
> > -				nxp,dvs-run-voltage =3D <950000>;
> > -				nxp,dvs-standby-voltage =3D <850000>;
> >  			};
> >
> >  			buck4: BUCK4{
> > --
> > 2.37.1
> >
> >
> >