Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: Introducing paravirt_ops for x86_64
Date: Wed, 8 Aug 2007 17:28:57 -0700
Message-ID: <97D612E30E1F88419025B06CB4CF1BE10326E924@scsmsx412.amr.corp.intel.com>
In-Reply-To: <5d6222a80708080758t1b937d0ej14c5e60ac23a20c5@mail.gmail.com>
Thread-Topic: Introducing paravirt_ops for x86_64
thread-index: AcfZzI4SjKcz6XZHRsGPDKfz8b/HyAAAV/rw
From: "Nakajima, Jun" <jun.nakajima@intel.com>
To: "Glauber de Oliveira Costa" <glommer@gmail.com>
Cc: "Glauber de Oliveira Costa" <gcosta@redhat.com>,
       <linux-kernel@vger.kernel.org>, <lguest@ozlabs.org>,
       <virtualization@lists.linux-foundation.org>, <chrisw@sous-sol.org>,
       <anthony@codemonkey.ws>, <akpm@linux-foundation.org>, <mingo@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1675
Lines: 44

Glauber de Oliveira Costa wrote:
> On 8/8/07, Nakajima, Jun <jun.nakajima@intel.com> wrote:
> > Glauber de Oliveira Costa wrote:
> > > Hi folks,
> > > 
> > > After some time away from it, and a big rebase as a consequence,
here is
> > > the updated version of paravirt_ops for x86_64, heading to
inclusion.
> > > 
> > > Your criticism is of course, very welcome.
> > > 
> > > Have fun
> > 
> > Do you assume that the kernel ougtht to use 2MB pages for its
mappings
> > (e.g. initilal text/data,  direct mapping of physical memory) under
your
> > paravirt_ops?  As far as I look at the patches, I don't find one.
> 
> I don't think how it could be relevant here. lguest kernel does use
> 2MB pages, and it goes smootly. For 2MB pages, we will update the page
> tables in the very same way, and in the very places we did before.
> Just that the operations can now be overwritten.
> 
> So, unless I'm very wrong,  it only makes sense to talk about not
> supporting large pages in the guest level. But it is not a
> paravirt_ops problem.

Some MMU-related PV techiniques (including Xen, and direct paging mode
for Xen/KVM) need to write-protect page tables, avoiding to use 2MB
pages when mapping page tables. Looks like you did not, and that
exaplains why the patches are missing the relevant (many) paravirt_ops
in include/asm-x86_64/pgalloc.h, for example, compared with the i386
tree. 

Jun
---
Intel Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/