Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 12:47:19 +0900
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
        lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
Message-ID: <Y3RdR+9QSVPWyae3@rocinante>
References: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com>
 <Y3NpjbXkcb3wfZcQ@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Y3NpjbXkcb3wfZcQ@infradead.org>
Precedence: bulk

Hello,

> > +	if (vmd->irq_domain)
> > +		vmd_set_msi_remapping(vmd, true);
> > +	else
> > +		vmd_set_msi_remapping(vmd, false);
> 
> Why not go one step further:
> 
> 	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.

	Krzysztof