Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp112792rwb; Tue, 15 Nov 2022 20:14:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf6dPyYaEnZWPGxJm8IknTS7O6Ijf7RcNoxzE2wK4UN0niLfCzLU5zIDtjEQ5fF6lhuLUosz X-Received: by 2002:a17:90a:4207:b0:209:46fe:871b with SMTP id o7-20020a17090a420700b0020946fe871bmr1762274pjg.163.1668572093848; Tue, 15 Nov 2022 20:14:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668572093; cv=none; d=google.com; s=arc-20160816; b=ktqp1wKw9ENzGvdbrUNT7sYPmHRIbRvbqh8Bqo8peUnpCOvBZ6zFKWKyH6K89OayQz sHlPsgUZQSYT138fxYFpw4y8QVWP43CEEZGhsKr70xVviAe3PBlKiq2RP9b2oVKjnMYr cMA5GDGrLeGpRSCMeWu2HLLrtTGt9T95zN6Ne3kPXmovAryS4OLXRZFjOdI9Mpint9sR 3RpZyNGALGiw5K+N2IxL7DXB4EkYBN3lsOAxBkLpDonT26Z0IR9usv2eTEyjiQq33zdo Rcf9VrdRKPPihpPRiyuMs0sDLPXz3IKLxLO/vdSPWh9/lYHmp1LJLBV60Eo5CAM/lP0L VsMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=woM2iJQVuvVwlbfVHcxGfAeMYRl2d8ctBY6yZytfaZM=; b=XJ9vXOCo7nFxlhm/Ie0aq7w29j+IaytbPSKJnCr9gfzvVJaU9U0VUCSQ/nDv9KlXKL Q3AKLxZFgLMVYgw+SToEDUgYbkd76MfG3PG/l+WqS02wxepnCEdbSHbQ/DcrzkfHre4F Rp5F2Gqyrd/5PxyxLkLDaQuUXQ+J0KqT2YGD1PKUD/0uwwR8USCWZHmvKptEl2KZIvWm 9ipqhdJXsL4rRWRIaewciZaRyG3NJWkLnwYNCu5yU2KfGAhefZB/KbGg99PQXtDR1IVZ D4YaD/ljheCC7VP079JNHHX78ofqs3yYBO4oh+Tx/LJrpW7gbQdi00Q2hUSJBMF5oa4e 2oww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id om3-20020a17090b3a8300b0020bc071d30csi898051pjb.97.2022.11.15.20.14.42; Tue, 15 Nov 2022 20:14:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiKPDr1 (ORCPT + 90 others); Tue, 15 Nov 2022 22:47:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbiKPDr0 (ORCPT ); Tue, 15 Nov 2022 22:47:26 -0500 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D274C27DDA; Tue, 15 Nov 2022 19:47:25 -0800 (PST) Received: by mail-pf1-f181.google.com with SMTP id g62so16278186pfb.10; Tue, 15 Nov 2022 19:47:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=woM2iJQVuvVwlbfVHcxGfAeMYRl2d8ctBY6yZytfaZM=; b=N0SM8URRQh4ysMY+3nLL1QZwX0F3wqJKxvv7hhaIrlXrmd8yv28vOmW9mUMPk+7eOX wqYowl+7D649PWififBxpmtuhDuHIoMfJ40WWZJchnd7FkLzubfg9cxy4zpXw5DSTMcm zjHYZOo/D4kyKEd18OwMqUrVsXwT1Gil7G9QM4PB1P5t9NgLQilyGiJ+Jo7iBBNOGJIz U7zs8eYrutg7oWOiUyQHSeEwxTCabn+4o09RqLegcAV3O5JtVq+qRWKXDBrpjm2J9yQ5 IwJqCTn3HAh1ODyVWSZu9bRaaCWKI/4hq89nxnMPqccFI8sF98GrUtq9TTWGvJQNt3oi Jf8Q== X-Gm-Message-State: ANoB5pn7gyfQvrcg6U/oP3bQVTEIkUJ/vFSfjh3ShTE5Yx4VSsxlV6zx /u/qMxezmecUiABQtOZl1bM= X-Received: by 2002:a62:4e06:0:b0:56d:4d37:89dc with SMTP id c6-20020a624e06000000b0056d4d3789dcmr21554381pfb.81.1668570444935; Tue, 15 Nov 2022 19:47:24 -0800 (PST) Received: from rocinante (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id n1-20020a654cc1000000b0046ae5cfc3d5sm8416770pgt.61.2022.11.15.19.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 19:47:23 -0800 (PST) Date: Wed, 16 Nov 2022 12:47:19 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Christoph Hellwig Cc: Jiapeng Chong , nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev, lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting Message-ID: References: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > > + if (vmd->irq_domain) > > + vmd_set_msi_remapping(vmd, true); > > + else > > + vmd_set_msi_remapping(vmd, false); > > Why not go one step further: > > vmd_set_msi_remapping(vmd, !!vmd->irq_domain); Jiapeng, if you want to get this patch merged, and it's a nice clean-up, then apply suggestion from Christoph and send a v2, if possible. Krzysztof