Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d839086b-826d-3642-5be2-a62714457b62@amd.com>
Date:   Wed, 16 Nov 2022 11:15:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] perf/amd/ibs: Make IBS a core pmu
Content-Language: en-US
To:     peterz@infradead.org, Ian Rogers <irogers@google.com>
Cc:     acme@kernel.org, mark.rutland@arm.com, jolsa@redhat.com,
        namhyung@kernel.org, eranian@google.com, kan.liang@linux.intel.com,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20221115093904.1799-1-ravi.bangoria@amd.com>
 <CAP-5=fXq-YNKogH4DYQuf7rz8TZhu8=QnEsA2pvzj6YS_DQO7g@mail.gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAP-5=fXq-YNKogH4DYQuf7rz8TZhu8=QnEsA2pvzj6YS_DQO7g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmZOMzlhbUFxL2E3dGE4dlFhazFEYnJ1anVXVjNqc3dBZ1JETG5Jdm5qQ3VM?=
 =?utf-8?B?b082UXhZMDBMQkFwSHdDeVVyWjBIY3E1UlBqbUZuTkVvQWR5WXJoOGRvRDU4?=
 =?utf-8?B?SGVQaXZDWGhhemx4enlPMG5sdmJtZXFwOUlXYWt2Z3Z1U1NMWjkxcjc3eGVl?=
 =?utf-8?B?WEdHUkdIYnRhbWxPZDl5Yng0WDYraTNxUDBKTnkzVnROUU84bi8zOU4wdGE0?=
 =?utf-8?B?MjR3M3BETkZBYytDMC9RQzVrVitCbk9xS0lBdmU4UGk1TjNQZTRwZFh2b3or?=
 =?utf-8?B?cjFtdE1XVVBodnFybGlEd3VFcW8xMFdaREc5dFRSOU5aVGljSkkwVWtWS01l?=
 =?utf-8?B?L2ZpTVI3VUFscTdsN3JkeDkzWGZSclhDRGpGVnZ6VjI3eHhGNlBOaUJ4bUM0?=
 =?utf-8?B?cG5PbFE1KzZrN2xmbGIrRXZVQWpzRW45Q2JVbzFOVUFHZ2NWSjFIcFZjenZL?=
 =?utf-8?B?NVhTcW9QUk92Q1hwQlNWUWdvWHVVdFR5ejIxYlpYV3V6QzNhN0k5S1Y3ZW5R?=
 =?utf-8?B?MyttSHV0RkVNaWNpc0ZMSlcyaDZnR0ozdHFVY2RxOFVvQnFjdU8yZ0o5b2pj?=
 =?utf-8?B?bEdhQUg1ZjI1NmhnNGJRbjNmNkI2TlpGd01OUmUyU1FsMDZKbHFNMHJVNkFt?=
 =?utf-8?B?cEI0V0hvUzc3dEh2Y09CWHAxMTJWT2xBL3lBei9CWlRrMWZKMjREUkFHQjVt?=
 =?utf-8?B?SEoraE01aHJRQ3lsUHUwS0N6NmI4UUVYQTliZjFYSUloMDZkZmtEVDlOTENQ?=
 =?utf-8?B?b0xSbHdxZkR0amRUWDh5NXdrODQ1M3hhKzZoVUtESTBWT2E1NS9XZ2MycUNp?=
 =?utf-8?B?c1ZGNjZ2R3lLNEpkYW1EdVFPSzJpd3I3aVRXMnljZ0hqTThjbW54MVJRdUEr?=
 =?utf-8?B?TlF0cGxWRXltelJ6RzBaV2I1Qi9CWE55NFNkZmhKdm9WeERiUCtOaWRGZEQw?=
 =?utf-8?B?Y3ZkYnhYbDJQVm9tUzE3eUd2UXRRbmE0N21QZUhRakZxd0VOMnlZdzdnb2Jp?=
 =?utf-8?B?cDlraHZiVVVRTVVTdkRSOGNLVDVvRUtPYnl3MS82THpXNXRFSEJxWnBkbE9C?=
 =?utf-8?B?WFFIbmlLM3B6ZW9WQmVqRFIvVXJkMlUyeGJyR29iMG9QdlVCQk5Rb0ZQNWF0?=
 =?utf-8?B?dk9YZzVJSDlBMTRhTzRReFZWdU9mQjlINGRjUWtxRDNITzlPL2RaUnlQejlV?=
 =?utf-8?B?U1NXVCtQQjBQUmRIMFZyTFkreDFZSlZnWmlhVjBYR0JJS0w2Q05QbmoraFFU?=
 =?utf-8?B?WUxSL3FEMVNOcWtYSDlka2JBaFNMbFlTWXg2VG1kK2lCcHk0SHBHQXhNSkYr?=
 =?utf-8?B?ZzBQRWVldnlBZGFhcG9PUHRZa3gyaWNVUExZT0pZWUhFTzZINGIxak9PRzhN?=
 =?utf-8?B?dnZqb01lT21yb0dhZEFTTnlRWUNyb2NPVW54bWVKdUo1aldKb3NzU2NrNkVT?=
 =?utf-8?B?N3lSbWRGanZxaFBkV0lEbXhaZ3E0WG9PbVoyVlZWUjUrblY2bTZqVE5OaVNX?=
 =?utf-8?B?Zm9iY3pLQkhWSHEyc3lMd3QwbUFFNnhMUGZrMCtKQ0oweFhxejRPN0lQdHk1?=
 =?utf-8?B?a1J6V3pmS3ZBV1FiNmpobkxvV1NnYjQzNmhvUWF3TUpjZ3hmd2FOWjY5Uld5?=
 =?utf-8?B?TWlBVk1rQklKTzZmYVVEQVZmdjRlaUdjcEhJcm1CWkp4Kyttekg2WGVVbFR4?=
 =?utf-8?B?anlDZkFJOTBxRUZJdjVxQWRSVTVwSDhCeFVCOUprTk4xZ21YTlYxaFlBSkdI?=
 =?utf-8?B?R09VS1RGaE53bXVndkFNMXljaTduVWRGUDAraEk1cEVvVW1uY1RPNytpSFFC?=
 =?utf-8?B?N3BwZUZORHk3RUJ0NGQyK0UwYVdkWFViWTBKMnB4UkVLVXNYczhmdmduMjBo?=
 =?utf-8?B?eFMrTnRSZUp2ZFlNNHEvS0p4bHlVWXFkVi9ncWFuTkJiK0V6NkQyekxpSlFN?=
 =?utf-8?B?czFuNDdsWnE0TmxsYUpiMkRzVzM4dktlQ1V0QzhlcVRxOFp2akpzODlSTU5l?=
 =?utf-8?B?MmJwdDc3QlJBQTE3UE9BOVhFV2U5ZisyYy9kWG9zMW96M29SNDY0anBMd3Rh?=
 =?utf-8?B?ZzROdm9HTHdkcnNKUWNzZ2lWMmF3WUIvbGVTby9mOGFaS2lqclNwNWhyN3dI?=
 =?utf-8?Q?+SOrGW1UF2tCdzUaemdNFrUPj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 497cec1e-1d37-4f45-7c6c-08dac795dc02
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 05:46:08.4856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 79YRyLOMQejTS8JnnqQLyEcRnpEV8u9kjLiTGBVx7NGyLEX0TdJzjO38wcF8ylCPSGY12omV2B1VZL8zyAU5lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6256
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15-Nov-22 10:37 PM, Ian Rogers wrote:
> On Tue, Nov 15, 2022 at 1:39 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>
>> So far, only one pmu was allowed to be registered as core pmu and thus
>> IBS pmus were being registered as uncore. However, with the event context
>> rewrite, that limitation no longer exists and thus IBS pmus can also be
>> registered as core pmu. This makes IBS much more usable, for ex, user
>> will be able to do per-process precise monitoring on AMD:
>>
>> Before patch:
>>   $ sudo perf record -e cycles:pp ls
>>   Error:
>>   Invalid event (cycles:pp) in per-thread mode, enable system wide with '-a'
>>
>> After patch:
>>   $ sudo perf record -e cycles:pp ls
>>   [ perf record: Woken up 1 times to write data ]
>>   [ perf record: Captured and wrote 0.017 MB perf.data (33 samples) ]
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>
> 
> This is awesome!
> Ian

Thanks Ian.

Peter, can we push this along with rewrite patch?

Thanks,
Ravi