Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <88f8d4b3-b144-4d04-a2bc-61ee30dd6ff6@app.fastmail.com>
In-Reply-To: <20221116065335.8823-1-zhuyinbo@loongson.cn>
References: <20221116065335.8823-1-zhuyinbo@loongson.cn>
Date:   Wed, 16 Nov 2022 08:30:54 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Yinbo Zhu" <zhuyinbo@loongson.cn>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "WANG Xuerui" <kernel@xen0n.name>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Juxin Gao" <gaojuxin@loongson.cn>,
        "Bibo Mao" <maobibo@loongson.cn>,
        "Yanteng Si" <siyanteng@loongson.cn>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
        "Arnaud Patard" <apatard@mandriva.com>,
        "Huacai Chen" <chenhuacai@kernel.org>
Cc:     "Jianmin Lv" <lvjianmin@loongson.cn>,
        zhanghongchen <zhanghongchen@loongson.cn>,
        "Liu Peibao" <liupeibao@loongson.cn>
Subject: Re: [PATCH v3 1/2] gpio: loongson: add dts/acpi gpio support
Content-Type: text/plain
Precedence: bulk

On Wed, Nov 16, 2022, at 07:53, Yinbo Zhu wrote:
> The latest Loongson series platform use dts or acpi framework to
> register gpio device resources, such as the Loongson-2 series
> SoC of LOONGARCH architecture. In order to support dts, acpi and
> compatibility with previous platform device resources in driver,
> this patch was added.

I think the support for legacy platform_data should be left out
of this patch. I am working on a series that removes unused
platform_data headers for machines that have DT support and no
longer use static platform_device declarations anywhere in
the kernel, so if you add another instance, that would just
get removed again in the near future.

Just don't add it here. If there are users that use traditional
boardfiles instead of DT, they already need kernel patches to
add the board files, and adding in the driver support can be
part of the same patches.

      Arnd