Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <12285f24-db9d-197b-84e5-e1e296607a04@ti.com>
Date:   Wed, 16 Nov 2022 14:44:25 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Fix the interrupt ranges
 property for main & wkup gpio intr
Content-Language: en-US
To:     Keerthy <j-keerthy@ti.com>, <vigneshr@ti.com>, <nm@ti.com>
CC:     <robh+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <kristo@kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220922072950.9157-1-j-keerthy@ti.com>
From:   Vaishnav Achath <vaishnav.a@ti.com>
In-Reply-To: <20220922072950.9157-1-j-keerthy@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 22/09/22 12:59, Keerthy wrote:
> The parent's input irq number is wrongly subtracted with 32 instead of
> using the exact numbers in:
> 
> https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html
> 
> The GPIO interrupts are not working because of that. The toggling works
> fine but interrupts are not firing. Fix the parent's input irq that
> specifies the base for parent irq.
> 
> Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM.
> 
> Fixes: b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi       | 2 +-
>  arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 34e7d577ae13..c89f28235812 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -60,7 +60,7 @@
>  		#interrupt-cells = <1>;
>  		ti,sci = <&sms>;
>  		ti,sci-dev-id = <148>;
> -		ti,interrupt-ranges = <8 360 56>;
> +		ti,interrupt-ranges = <8 392 56>;
>  	};
>  
>  	main_pmx0: pinctrl@11c000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index 4d1bfabd1313..f0644851602c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -65,7 +65,7 @@
>  		#interrupt-cells = <1>;
>  		ti,sci = <&sms>;
>  		ti,sci-dev-id = <125>;
> -		ti,interrupt-ranges = <16 928 16>;
> +		ti,interrupt-ranges = <16 960 16>;

Reviewed-by: Vaishnav Achath <vaishnav.a@ti.com>

>  	};
>  
>  	mcu_conf: syscon@40f00000 {

-- 
Regards,
Vaishnav