Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 10:49:00 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V5 07/12] arm64: dts: imx8mn-evk: update vdd_soc dvs
 voltage
Message-ID: <20221116094900.52tbr2o3z4hvaw4z@pengutronix.de>
References: <20221115091709.2865997-1-peng.fan@oss.nxp.com>
 <20221115091709.2865997-8-peng.fan@oss.nxp.com>
 <20221115100251.7hwpnodgxzirgpw6@pengutronix.de>
 <DU0PR04MB941782A4B6323FB9405808B588079@DU0PR04MB9417.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DU0PR04MB941782A4B6323FB9405808B588079@DU0PR04MB9417.eurprd04.prod.outlook.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 22-11-16, Peng Fan wrote:
> > Subject: Re: [PATCH V5 07/12] arm64: dts: imx8mn-evk: update vdd_soc dvs
> > voltage
> > 
> > Hi Peng,
> > 
> > On 22-11-15, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Per schematic, BUCK1 is for VDD_SOC&DRAM&PU_0V9. The
> > > nxp,dvs-run-voltage and nxp,dvs-standby-voltage need set for BUCK1, not
> > BUCK2.
> > > BUCK2 is for A53, which is handled by DVFS, so no need dvs property.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > > index 4eb467df5ba7..a5a7d74ec1d5 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > > @@ -47,6 +47,8 @@ buck1: BUCK1{
> > >  				regulator-boot-on;
> > >  				regulator-always-on;
> > >  				regulator-ramp-delay = <3125>;
> > > +				nxp,dvs-run-voltage = <950000>;
> > 
> > One last question on this. According the schematic the max should be
> > 0.88/0.945V and you are going to set it to 0.950V.
> 
> No, my schematic shows the TYP voltage is 0.85/0.95V.

I have the Rev.A2 i.MX8MNano DDR4 SoM schematic and TYP is listed as
0.8/0.9V. Is this different for different ram configurations? Sorry for
asking but the i.MX8MNano LPDDR4 schematic is not available.

> > According the driver the nxp,dvs-run-voltage is just the same as the normal
> > regulator voltage. So I would suggest to just use the nxp,dvs-standby-
> > voltage property to enable the DVS feature since the run voltage is already
> > handled by the regulator-min-microvolt/regulator-max-microvolt. So it
> > would be just:
> It should be fine to not set nxp,dvs-run-voltage, because bootloader already
> set that.

Okay, so leave the voltage as it is right now and just add the
nxp,dvs-standby-voltage seems fine :)

Regards,
  Marco

> 
> Thanks,
> Peng.
> > 
> > > +				nxp,dvs-standby-voltage = <750000>;
> > 
> > Regards,
> >   Marco
> > 
> > >  			};
> > >
> > >  			buck2: BUCK2 {
> > > @@ -56,8 +58,6 @@ buck2: BUCK2 {
> > >  				regulator-boot-on;
> > >  				regulator-always-on;
> > >  				regulator-ramp-delay = <3125>;
> > > -				nxp,dvs-run-voltage = <950000>;
> > > -				nxp,dvs-standby-voltage = <850000>;
> > >  			};
> > >
> > >  			buck4: BUCK4{
> > > --
> > > 2.37.1
> > >
> > >
> > >
>