Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 11:23:51 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Steev Klimaszewski <steev@kali.org>
Cc:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Brian Masney <bmasney@redhat.com>, linus.walleij@linaro.org,
        brgl@bgdev.pl, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        psodagud@quicinc.com, quic_shazhuss@quicinc.com,
        quic_ppareek@quicinc.com, ahalaney@redhat.com, echanude@redhat.com,
        nicolas.dechesne@linaro.org
Subject: Re: [PATCH RFC] gpiolib: ensure that fwnode is properly set
Message-ID: <Y3S6NyPwN8wbwJDI@orome>
References: <20221114202943.2389489-1-bmasney@redhat.com>
 <7420da17-d6d6-10e6-c87e-d3dc37d17ffb@linaro.org>
 <CAKXuJqgckbmikXwFi0g3P3Db5jvyst+xhQBcPoV7mA2XStVVzA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="sDjlB8ktuswCuIRX"
Content-Disposition: inline
In-Reply-To: <CAKXuJqgckbmikXwFi0g3P3Db5jvyst+xhQBcPoV7mA2XStVVzA@mail.gmail.com>
User-Agent: Mutt/2.2.8 (2022-11-05)
Precedence: bulk


--sDjlB8ktuswCuIRX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 15, 2022 at 04:02:38PM -0600, Steev Klimaszewski wrote:
> Hi,
>=20
> Others in the thread pointed to Thierry's patch, but on the Lenovo
> Thinkpad X13s, that patch did *not* fix the issue, and with it
> applied, the X13s still immediately reboots as soon as exiting EFI
> services.  With this patch applied, the X13s does *not* reboot after
> exiting EFI services, so thank you for this patch.
>=20
> Tested-by: Steev Klimaszewski <steev@kali.org> #Lenovo Thinkpad X13s

Do you happen to know what driver the X13s is using? As mentioned in
another email, I don't think overriding gc->fwnode at this point is the
right thing to do, so I suspect this field might be used unexpectedly in
some other place, so I'd like to take a closer look at that.

Thierry

--sDjlB8ktuswCuIRX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmN0ujYACgkQ3SOs138+
s6Ekeg//fsV8Vbkdcv+e3uObyH4LDXM7h9VfB1Faav6WkstVescdfRFUNkrMOUL4
Nihw+XJQPHhacVnR12e1smY2zHeMeMHK1AgzHxQZIhuFIKrDNJ1ygehsKwMWPsSO
wBjpeViQ7LujjK7URvYmzv0mV2ElHDetWwHleY6RmFWuZujrUB895EBPBlyfcYPx
FSsuHc4ll6mVq0JRQBlcSWwaQy1+5svJTeIBv4BFJhDVXH8M5W/sKDT7r6xNfIuI
ciBHrR7J6K1fKKBpJMqFnrxVv247KM7KStmr+CqaL2+SRTeQQgqqlzHhBRxX/MbC
PgsmIV22A8CSrK7QTce8YTdZSYOPNVNEGiD15WhIliLtZ6SiZl7V4u63iEIx6xbF
tca7tdifI5EErHNb32liEmcig8FH7ulkTkZ//glZMR/jFnSzzYozUCa27rT29kvs
g+IMTMxwSfPEONuo00yWPqgRYqE5jJFYxNAEXy59igVe/Vf+GznoIuYT/uoqZqzc
D28ruTziw82/Q2+V1aeE/GdT3G2IBr/ClCoHJP5s9kXuZvRZxjHY7D0T1KkiigXw
47xGGjoS6eY5Ws4JbKNFpLoYLIuhSJ2Zu7K8JO7kHs2t5p3kxvhh8miARVUHLYfg
DDj95W/w4KgFl67HAKGP66FeKrtbjj6s3mNnlZBsEkQuP1cO46w=
=sbMU
-----END PGP SIGNATURE-----

--sDjlB8ktuswCuIRX--