Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 11:26:34 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Marijn Suijten <marijn.suijten@somainline.org>
Cc:     Brian Masney <bmasney@redhat.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips
Message-ID: <Y3S62i7OzocP5QrT@orome>
References: <20221111113732.461881-1-thierry.reding@gmail.com>
 <Y3Kv7XoBytwwy9pC@x1>
 <20221115111800.t6i6fuszhuasvgka@SoMainline.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="t/QMyFVa0+ws/Ltf"
Content-Disposition: inline
In-Reply-To: <20221115111800.t6i6fuszhuasvgka@SoMainline.org>
User-Agent: Mutt/2.2.8 (2022-11-05)
Precedence: bulk


--t/QMyFVa0+ws/Ltf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 15, 2022 at 12:18:00PM +0100, Marijn Suijten wrote:
> On 2022-11-14 16:15:25, Brian Masney wrote:
> > On Fri, Nov 11, 2022 at 12:37:32PM +0100, Thierry Reding wrote:
> > > From: Thierry Reding <treding@nvidia.com>
> > >=20
> > > The OF node store in chip->fwnode is used to explicitly override the =
FW
> > > node for a GPIO chip. For chips that use the default FW node (i.e. th=
at
> > > of their parent device), this will be NULL and cause the chip not to =
be
> > > fully registered.
> > >=20
> > > Instead, use the GPIO device's FW node, which is set to either the no=
de
> > > of the parent device or the explicit override in chip->fwnode.
> > >=20
> > > Fixes: 8afe82550240 ("gpiolib: of: Prepare of_gpiochip_add() / of_gpi=
ochip_remove() for fwnode")
> > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> >=20
> > Reviewed-by: Brian Masney <bmasney@redhat.com>
> > Tested-by: Brian Masney <bmasney@redhat.com>
> >=20
> > I separately sent a similar type of patch to fix the same issue today:
> > https://lore.kernel.org/linux-arm-msm/20221114202943.2389489-1-bmasney@=
redhat.com/T/#u
>=20
> For completeness, your linked patch fixes a synchronous external abort
> on multiple Qualcomm platforms pointed out in [1].  This patch however
> does not, are you sure they fix the exact same issue?
>=20
> [1]: https://lore.kernel.org/linux-arm-msm/20221115110800.35gl3j43lmbxm3j=
b@SoMainline.org/

Can you check if the below fixes the MSM issue that you're seeing
(applied on top of my earlier patch, though with Brian's reverted
temporarily)?

Thanks,
Thierry

--- >8 ---
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 11fb7ec883e9..d692ad5c5a27 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -447,10 +447,11 @@ static unsigned long *gpiochip_allocate_mask(struct g=
pio_chip *gc)
=20
 static unsigned int gpiochip_count_reserved_ranges(struct gpio_chip *gc)
 {
+	struct fwnode_handle *fwnode =3D dev_fwnode(&gc->gpiodev->dev);
 	int size;
=20
 	/* Format is "start, count, ..." */
-	size =3D fwnode_property_count_u32(gc->fwnode, "gpio-reserved-ranges");
+	size =3D fwnode_property_count_u32(fwnode, "gpio-reserved-ranges");
 	if (size > 0 && size % 2 =3D=3D 0)
 		return size;
=20
@@ -471,6 +472,7 @@ static int gpiochip_alloc_valid_mask(struct gpio_chip *=
gc)
=20
 static int gpiochip_apply_reserved_ranges(struct gpio_chip *gc)
 {
+	struct fwnode_handle *fwnode =3D dev_fwnode(&gc->gpiodev->dev);
 	unsigned int size;
 	u32 *ranges;
 	int ret;
@@ -483,7 +485,7 @@ static int gpiochip_apply_reserved_ranges(struct gpio_c=
hip *gc)
 	if (!ranges)
 		return -ENOMEM;
=20
-	ret =3D fwnode_property_read_u32_array(gc->fwnode, "gpio-reserved-ranges"=
, ranges, size);
+	ret =3D fwnode_property_read_u32_array(fwnode, "gpio-reserved-ranges", ra=
nges, size);
 	if (ret) {
 		kfree(ranges);
 		return ret;
--- >8 ---

--t/QMyFVa0+ws/Ltf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmN0utoACgkQ3SOs138+
s6HY+w/9FPuWzbA0QDSng/u8HNj0vDTsWe/g5Yf3zW0pdt8x3f9eIL3hivFA7aT8
qEMPLl8JbcoK0VX8Jx6/i6VviJthgKxwjT0ET39uwHMEac7e0P5zNPLoY3T6L6Nq
EFYUYoiHecionPiKK5DxG6+W08BIVmSM0XnwDvK2INRUQGemxE5qPq35v9NK62Ep
nyFZeL2goKpea3F2wUMqFcUHJqVzCaNc7/bgmnrHaAkJpS0kcupkwM4qjPTp3VHl
Ey+M/BsS+NB7Eu45xHSOnwwL0jRhj4LGsmM/q0sYS1tQ9aHiO75x/y0S7pqdIyM6
V0zopPZttwy0OLGfZQcMgiSLVj0rpVXVxH50O+w+GbycibQBKpY3PNt+se9G5foK
FxsDZcyQuRJwEHYnrLqO+Nlne2795YAQbO4OFakg1DU+DQ3zsL8byWwMKBVCpqdy
R0vfwRcC/Bh8CdCs9n0A6//BZhfnsiyXFqyqHxay9QI83/egha4ek8TPEtA6mgMp
vxu4mLJJ+XHCU3HkE6t1/IKsCjXcJgFoWs+HcDoq1N0r0u9cIS0wC+ncti6JyEoN
r1HmQ4anutzfYz8jATxAR1feMYhtKd3iFWwpmWFbnpMDuj8q6JbGaQVaqmhvbQoU
SFGNbDvpzUCUTfEBUKaHRtoNoox6SBu+gzCwpvpIUa9Ml0/v4aw=
=XuqC
-----END PGP SIGNATURE-----

--t/QMyFVa0+ws/Ltf--