Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58020f64-fbbc-fdc7-2cbc-a2aa40062d74@didichuxing.com>
Date:   Wed, 16 Nov 2022 19:17:18 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH] sched/core: use correct cpu_capacity in
 wake_affine_weight()
To:     Vincent Guittot <vincent.guittot@linaro.org>,
        Honglei Wang <wanghonglei@didiglobal.com>
CC:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        <linux-kernel@vger.kernel.org>
Content-Language: en-US
From:   Honglei Wang <wanghonglei@didichuxing.com>
In-Reply-To: <CAKfTPtCthYY9HxaNDyHYszgJctrjTiWPF=AYaj2dLhcB5X=NYw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/11/16 19:00, Vincent Guittot wrote:
> On Wed, 16 Nov 2022 at 10:12, Honglei Wang <wanghonglei@didiglobal.com> wrote:
>>
>> It seems make more sense to do the load weight calculation with
>> respective cpu_capacity.
>>
>> Signed-off-by: Honglei Wang <wanghonglei@didiglobal.com>
>> ---
>>   kernel/sched/fair.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index e4a0b8bd941c..a9f75040969b 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -6262,13 +6262,13 @@ wake_affine_weight(struct sched_domain *sd, struct task_struct *p,
>>          this_eff_load += task_load;
>>          if (sched_feat(WA_BIAS))
>>                  this_eff_load *= 100;
>> -       this_eff_load *= capacity_of(prev_cpu);
>> +       this_eff_load *= capacity_of(this_cpu);
>>
>>          prev_eff_load = cpu_load(cpu_rq(prev_cpu));
>>          prev_eff_load -= task_load;
>>          if (sched_feat(WA_BIAS))
>>                  prev_eff_load *= 100 + (sd->imbalance_pct - 100) / 2;
>> -       prev_eff_load *= capacity_of(this_cpu);
>> +       prev_eff_load *= capacity_of(prev_cpu);
> 
> we want to test :
>      (cpu_load(this_rq) + task_h_load(p) ) / capacity_of(this_cpu)  <
> cpu_load(prev_rq) / capacity_of(prev_cpu)
> 
> but instead of doing expensive division, we do the below which gives
> the same result
>      (cpu_load(this_rq) + task_h_load(p) ) * capacity_of(prev_cpu)  <
> cpu_load(prev_rq) * capacity_of(this_cpu)
> 
> 

ha, I misunderstand the strategy, thanks for coaching, Vincent.

>>
>>          /*
>>           * If sync, adjust the weight of prev_eff_load such that if
>> --
>> 2.14.1
>>