Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <340c0769-d51f-88df-5cd5-02c3337a24c0@linaro.org>
Date:   Wed, 16 Nov 2022 12:35:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.2
Subject: Re: [PATCH 2/2] soc: qcom: rpmhpd: Add SM8550 power domains
To:     Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20221116111745.2633074-1-abel.vesa@linaro.org>
 <20221116111745.2633074-3-abel.vesa@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20221116111745.2633074-3-abel.vesa@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 16/11/2022 12:17, Abel Vesa wrote:
> Add the power domains exposed by RPMH in the Qualcomm SM8550 platform.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   drivers/soc/qcom/rpmhpd.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 7af68cd720f5..4c2d2c296790 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -372,6 +372,29 @@ static const struct rpmhpd_desc sm8450_desc = {
>   	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
>   };
>   
> +/* SM8550 RPMH powerdomains */
> +static struct rpmhpd *sm8550_rpmhpds[] = {
> +	[SM8550_CX] = &cx,
> +	[SM8550_CX_AO] = &cx_ao,
> +	[SM8550_EBI] = &ebi,
> +	[SM8550_GFX] = &gfx,
> +	[SM8550_LCX] = &lcx,
> +	[SM8550_LMX] = &lmx,
> +	[SM8550_MMCX] = &mmcx_w_cx_parent,
> +	[SM8550_MMCX_AO] = &mmcx_ao_w_cx_parent,
> +	[SM8550_MSS] = &mss,
> +	[SM8550_MX] = &mx,
> +	[SM8550_MX_AO] = &mx_ao,
> +	[SM8550_MXC] = &mxc,
> +	[SM8550_MXC_AO] = &mxc_ao,
> +	[SM8550_NSP] = &nsp,
> +};
> +
> +static const struct rpmhpd_desc sm8550_desc = {
> +	.rpmhpds = sm8550_rpmhpds,
> +	.num_pds = ARRAY_SIZE(sm8550_rpmhpds),
> +};
> +
>   /* QDU1000/QRU1000 RPMH powerdomains */
>   static struct rpmhpd *qdu1000_rpmhpds[] = {
>   	[QDU1000_CX] = &cx,
> @@ -477,6 +500,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
>   	{ .compatible = "qcom,sm8250-rpmhpd", .data = &sm8250_desc },
>   	{ .compatible = "qcom,sm8350-rpmhpd", .data = &sm8350_desc },
>   	{ .compatible = "qcom,sm8450-rpmhpd", .data = &sm8450_desc },
> +	{ .compatible = "qcom,sm8550-rpmhpd", .data = &sm8550_desc },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, rpmhpd_match_table);