Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b715cb83-32f1-a33b-a0c2-b779011151c0@amd.com>
Date:   Wed, 16 Nov 2022 13:01:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3] udmabuf: add vmap and vunmap methods to udmabuf_ops
To:     Lukasz Wiecaszek <lukasz.wiecaszek@googlemail.com>,
        Gerd Hoffmann <kraxel@redhat.com>
Cc:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Lukasz Wiecaszek <lukasz.wiecaszek@gmail.com>,
        kernel test robot <lkp@intel.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20221115200426.4801-1-lukasz.wiecaszek@gmail.com>
Content-Language: en-US
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221115200426.4801-1-lukasz.wiecaszek@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnYrRkZFMHBONUc5Mk1SM3BUVVVJYUZjNHNoVk1RTFlUU1ViZGN3TXJadjA0?=
 =?utf-8?B?VUZ4bFJoRHFSNWFOOEJjWG10YTdhSE5ZcllYemJsOElOMjY2WkNRb3R5Ynl0?=
 =?utf-8?B?Tkh6cmN1UWVubHFnQUpyT1Z2dUlIZGVONERxMkQ4QmZsKzE5YkJlSnJXam82?=
 =?utf-8?B?QjZEVTlRL3FwSU9YMDU5bTNvNS95QUtCZVlsK001eGJ3Q1pjaHBEYThHTXRF?=
 =?utf-8?B?L2VhZWNTeEM3Wm5PRlhnaTJLeDI4K2NaeDJtS2MyL1ArRENzcGRqcDBxeEU4?=
 =?utf-8?B?b2pMU1kvWVNZVmpmeWxJYzB4R3hDd3YvUHRieThnbU5pRWF6UlpTS2tNSC9B?=
 =?utf-8?B?a1JQU0ptQUhGR0VqTTZ2ZEd6MXh6SGxVdDFVOWREZDdJTzdPZDlBYVpucktx?=
 =?utf-8?B?VE05Uk41dzU1bU0xelZZZVV2YVpNVnpnblV0VzdsMjhiT1pwbGROK3RlTWNV?=
 =?utf-8?B?S3FFUFRXUHg0M1N0L1ZmZTVHdExkWnV1UTgweVI2eEF3TFpXQ0ZNRjlDK2la?=
 =?utf-8?B?WXkyR1VCdzNmSSszc25yMUtMME1QRmtmekg3aUhBTE1SUHU4Qkx1VExtcUVv?=
 =?utf-8?B?Rm1YZzQ4WDBjMmt5bWNod2xHRzV4QXEzdTlnN1F1QTFlU1VxWnhtU0w0bWVz?=
 =?utf-8?B?eXdwemErR0xLNVpTcDcycnQzUDR4a3g3dGRrbzUyNjQweDRNd25ITTMwVHpw?=
 =?utf-8?B?SDMvMnJmNDloOHJscVlZZHp5eGZHbExURStIN2grclJDRFN3ZVJxTkFIQnhF?=
 =?utf-8?B?cTlZcFNKQ0gxNTVrUXlZeTdXTWd1TWtHdktOa2pVMlQvSm9OTWhNeS9pakxT?=
 =?utf-8?B?VWQ3dTk5elM3bEVzQUNXN215WXBSM09vWnFjOVFXd1ExQ2lPbVZOMWlwYjRS?=
 =?utf-8?B?S2pUTU9vbGdLdi9UWitTYllleXlFR25KU2dqUWxHV1ZySmVaOTN4c1JqdW94?=
 =?utf-8?B?bUhUU2I1T2VuUnlQT1RqZEtBb0dyU0ZPMkFMYUxZRGZjU0tlQnNHNmM1SGc4?=
 =?utf-8?B?V0VMYmx0eVpjTUpOS1NPRmN0eEExcDVhWHg1N2xqNnJTZUdaMVMxdCszcjdE?=
 =?utf-8?B?N1VaUkthQlNpcHJPS0lFZ2U0bENHVDdVQkZQdW5yZjlDWkhRb1F6bEhUTEdp?=
 =?utf-8?B?SWVxU2svQm0yT3YzNXNxVERTVGsrcXkwN3YwVFI4b3RzUHF4V0IxNzJqa2F3?=
 =?utf-8?B?bXR0aXJmTSsyZkx3L05tS3NFdDB4REE1R2xlYzZnZmRWZG9hNXZjNVcxVytO?=
 =?utf-8?B?Y2VBRjh4TjJpUFVHSXpGYzFpYVA5ZHFBcVIvSHYydmNueGJFUEFBV1dpSkh0?=
 =?utf-8?B?S3ZYYXVZenBYQzRZdk12TzY3TUlCR0ZzZmJCdmw0VE50Q1lpbnhITlRYejRI?=
 =?utf-8?B?amVBL0JJVDM1REU5bUtjdG5UR1pJQ3FET2RIeGRGSitzTDNQQThzOVpLQlh6?=
 =?utf-8?B?Ukl5M244V1lhTUJ6c0lGZFl3c0xwSTFFdzVTMWNjVGRMTDI4Y3pQMkdibkcx?=
 =?utf-8?B?NlplWWsvdFNHTDZ5Q0MwdElQTGVJcnRnekVmd2w2dGh5UEZFSXo3NnhYcGNO?=
 =?utf-8?B?SnBoSHdxTXY4VXljanpSTmR4Wld0UDBlYXpQNHl0dHJUY0ZvdnMvaERIN0hC?=
 =?utf-8?B?a1NWRmFMd0tzWENZZWdIakV5bjF6SWc2emF1UTRHTytkT2luVVBNRnRFb3J2?=
 =?utf-8?B?emgrSHMyY0hGK3BHOUU1SFBtUTN6VXdqeVVEY0Y2akpQenM4ZWFzaSsxdjFm?=
 =?utf-8?B?ZXlNRUNCUjVLMkJ2ZHNjOU1IdGFYVHZ1T3NFM0RROEJ5aVlodUtWYUdUcEY2?=
 =?utf-8?B?ZDdCMHNsS2p6RVlLdVBLdVpPUldqQWpXRGZvUDROYTFPdUVxNW9zck9mZVlN?=
 =?utf-8?B?UUY0YkdUWVA1ditMYnh3eTdnRGpWZVUyUENMTDcwRmh0V0QzVyt5M1ZzNE5p?=
 =?utf-8?B?SWhJWUh0Q3V0bkdWWTZTZlNUTndwK0tpRkhJQkxJSTQ0Sm5UWDNPc2dTR0Yz?=
 =?utf-8?B?akQwQ2dITitBMi94eitnVjVKWW1UMm15eXNnd25YSC9kZEJnZWdMUTNSUjNU?=
 =?utf-8?B?QytxaCtkUnBxTzR6R1V1djZxT21yTjcxdzhQZEFPSzE3V2h5T0U4ZC9YTUFY?=
 =?utf-8?B?SFZlRFlJOVp0ekh1MGxMUlhLYmlJZFhnTGVIQmZpMnVoQWR3WW9UQ2ZuV0p2?=
 =?utf-8?Q?56RoPh8CKpp5AgweytLtEKMhJxicZVHDYpki8yLPOaMn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adcf3cf4-81f6-4d84-04a7-08dac7ca586c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 12:01:50.9954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sXJE7KgMJHQkprm7BCH2y/FOMtxo7dalV+sx9Dsg99oPO5BKXnWEMeEL7V31zYK4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6253
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 15.11.22 um 21:04 schrieb Lukasz Wiecaszek:
> The reason behind that patch is associated with videobuf2 subsystem
> (or more genrally with v4l2 framework) and user created
> dma buffers (udmabuf). In some circumstances
> when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 subsystem
> wants to use dma_buf_vmap() method on the attached dma buffer.
> As udmabuf does not have .vmap operation implemented,
> such dma_buf_vmap() natually fails.
>
> videobuf2_common: __vb2_queue_alloc: allocated 3 buffers, 1 plane(s) each
> videobuf2_common: __prepare_dmabuf: buffer for plane 0 changed
> videobuf2_common: __prepare_dmabuf: failed to map dmabuf for plane 0
> videobuf2_common: __buf_prepare: buffer preparation failed: -14
>
> The patch itself seems to be strighforward.
> It adds implementation of .vmap and .vunmap methods
> to 'struct dma_buf_ops udmabuf_ops'.
> .vmap method itself uses vm_map_ram() to map pages linearly
> into the kernel virtual address space.
> .vunmap removes mapping created earlier by .vmap.
> All locking and 'vmapping counting' is done in dma_buf.c
> so it seems to be redundant/unnecessary in .vmap/.vunmap.
>
> Signed-off-by: Lukasz Wiecaszek <lukasz.wiecaszek@gmail.com>

> Reported-by: kernel test robot <lkp@intel.com>

Please drop this line, the kernel test robot should only be mentioned if 
the original report came from it.

And keep in mind that it might be necessary to implement begin/end cpu 
access callbacks as well.

Apart from that the patch is Acked-by: Christian König 
<christian.koenig@amd.com>.

Regards,
Christian.

> ---
> v1: https://lore.kernel.org/linux-media/202211120352.G7WPASoP-lkp@intel.com/T/#t
> v2: https://lore.kernel.org/linux-media/20221114052944.GA7264@thinkpad-p72/T/#t
>
> v2 -> v3: Added .vunmap to 'struct dma_buf_ops udmabuf_ops'
> v1 -> v2: Patch prepared and tested against 6.1.0-rc2+
>
>   drivers/dma-buf/udmabuf.c | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index 283816fbd72f..740d6e426ee9 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -13,6 +13,8 @@
>   #include <linux/slab.h>
>   #include <linux/udmabuf.h>
>   #include <linux/hugetlb.h>
> +#include <linux/vmalloc.h>
> +#include <linux/iosys-map.h>
>   
>   static int list_limit = 1024;
>   module_param(list_limit, int, 0644);
> @@ -60,6 +62,30 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma)
>   	return 0;
>   }
>   
> +static int vmap_udmabuf(struct dma_buf *buf, struct iosys_map *map)
> +{
> +	struct udmabuf *ubuf = buf->priv;
> +	void *vaddr;
> +
> +	dma_resv_assert_held(buf->resv);
> +
> +	vaddr = vm_map_ram(ubuf->pages, ubuf->pagecount, -1);
> +	if (!vaddr)
> +		return -EINVAL;
> +
> +	iosys_map_set_vaddr(map, vaddr);
> +	return 0;
> +}
> +
> +static void vunmap_udmabuf(struct dma_buf *buf, struct iosys_map *map)
> +{
> +	struct udmabuf *ubuf = buf->priv;
> +
> +	dma_resv_assert_held(buf->resv);
> +
> +	vm_unmap_ram(map->vaddr, ubuf->pagecount);
> +}
> +
>   static struct sg_table *get_sg_table(struct device *dev, struct dma_buf *buf,
>   				     enum dma_data_direction direction)
>   {
> @@ -162,6 +188,8 @@ static const struct dma_buf_ops udmabuf_ops = {
>   	.unmap_dma_buf	   = unmap_udmabuf,
>   	.release	   = release_udmabuf,
>   	.mmap		   = mmap_udmabuf,
> +	.vmap		   = vmap_udmabuf,
> +	.vunmap		   = vunmap_udmabuf,
>   	.begin_cpu_access  = begin_cpu_udmabuf,
>   	.end_cpu_access    = end_cpu_udmabuf,
>   };