Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221116094006.16054-1-lukas.bulwahn@gmail.com>
References: <20221116094006.16054-1-lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
To:     Jason Chen <jason.z.chen@intel.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Shawn Tu <shawnx.tu@intel.com>, linux-media@vger.kernel.org
Date:   Wed, 16 Nov 2022 13:35:12 +0000
Message-ID: <166860571228.50677.2036444260575403904@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Lukas Bulwahn (2022-11-16 09:40:06)
> Commit 9958d30f38b9 ("media: Kconfig: cleanup VIDEO_DEV dependencies")
> removes the config VIDEO_V4L2 as it is merged with config VIDEO_DEV.
>=20
> Long after this change, commit 38fc5136ac16 ("media: i2c: Add ov08x40 ima=
ge
> sensor driver") introduces and refers to the removed config VIDEO_V4L2,
> basically making this driver impossible to build, test and use due to
> dependencies that cannot be met.
>=20
> Refer to config VIDEO_DEV instead to make this driver usable.


Fixes: 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 49c1c27afdc1..4a4ae9c20119 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -366,7 +366,7 @@ config VIDEO_OV08D10
> =20
>  config VIDEO_OV08X40
>         tristate "OmniVision OV08X40 sensor support"
> -       depends on VIDEO_V4L2 && I2C
> +       depends on VIDEO_DEV && I2C
>         select MEDIA_CONTROLLER
>         select VIDEO_V4L2_SUBDEV_API
>         select V4L2_FWNODE
> --=20
> 2.17.1
>