Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <542aa83d-6227-ea7d-2150-a74293cbf59a@igalia.com>
Date:   Wed, 16 Nov 2022 12:42:53 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>, linux-hardening@vger.kernel.org
Cc:     Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Paramjit Oberoi <pso@chromium.org>,
        Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
References: <20221011200112.731334-1-keescook@chromium.org>
 <20221011200112.731334-6-keescook@chromium.org>
From:   "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <20221011200112.731334-6-keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/10/2022 17:01, Kees Cook wrote:
> Update pstore to better reflect reality of active contributors:
> 
> - Remove Anton and Colin (thank you for your help through the years!)
> - Move Tony to Reviewer
> - Add Guilherme as Reviewer
> - Add mailing list
> - Upgrade to Supported
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  MAINTAINERS | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Hi Kees, sorry to revamp this thread for a "tangential" topic, but it
feels a "kinda" proper thread.

Since I was added as a reviewer on pstore (in linux-next so far), I
started to receive a bunch of emails from ARM device-tree folks; they're
adding ramoops entries to their DTs and looping pstore folks.

Examples:

https://lore.kernel.org/linux-hardening/20221111120156.48040-1-angelogioacchino.delregno@collabora.com/

https://lore.kernel.org/linux-hardening/20221116145616.17884-1-luca@z3ntu.xyz/


Personally, I have no knowledge of these HW to evaluate if the ramoops
setting is appropriate, so they're nop from my side, I just delete them.
But that raises the question - are you/Tony reviewing this kind of
change? It's not related to pstore/ramoops code, it's just users setting
ramoops in their DTs, so seems to me a bit far from the purpose of the
pstore entry.

What do you/Tony think about that? Likely the DT folks are following
this entry in the MAINTAINERS to send these emails:

PSTORE FILESYSTEM
M:      Kees Cook <keescook@chromium.org>
[...]
F:      include/linux/pstore*
K:      \b(pstore|ramoops) <------

Should this be kept? Maybe only the ramoops entry could be removed?

Again, totally fine be me to keep'em, it's just that I'm receiving and
ignoring the emails, so if everybody else is doing the same, better to
just remove this entry from MAINTAINERS.

Thanks,


Guilherme