Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 08:02:24 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        <linux-pci@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        <linuxppc-dev@lists.ozlabs.org>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 03/39] iommu/amd: Remove bogus check for multi MSI-X
Message-ID: <Y3UJkEb7ejrxbW22@a4bf019067fa.jf.intel.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122013.772447165@linutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221111122013.772447165@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jEFvEqdV8vhhcpxNm7B9fEluG9Bnxseo8sCBx2kEXMrSzV4uXTfxKKNkW+7X?=
 =?us-ascii?Q?WuTKvGWg804ey64Yag91dfLMpTlO4MN3dhbuIUabPU05sDlSNLnW15B8C81Z?=
 =?us-ascii?Q?hxGtgiNsFuyBzTMS5mFPSZo6x3O03y4ZNHPXH09LvUqtvptUOLLCE2WLt+KE?=
 =?us-ascii?Q?qTbt0rehEEd5jCJID8FSbi4TGz/8UkrOk9uxNFfy+VmCeC1FcqCU1EG3sLUB?=
 =?us-ascii?Q?IF/g1Thy3DkmJFEqhqY1K5iQFhkiNj3uWegAGx2532ojucXuIifIgRU8lXPo?=
 =?us-ascii?Q?nLnyi7NmYo/JOcKTS/XOzlltfPbCI3u2CGRAznYpXtqnTiQ6oAX5Y8HGzTIq?=
 =?us-ascii?Q?YbhxzZNBfrhgR7VYHtwqx1Lx7u/ikv92fD+erp1hSfe255HFoeR/0zju6IUN?=
 =?us-ascii?Q?9ffCFRm/VbQzGawbSY+/T3bQapRf2fnN73AmwJGr/tRmX7ELOrCprqaVNH5b?=
 =?us-ascii?Q?85CpkU1KJt8Jxve65fiaE+r85H1aWNVJBypxHkgFYkLwhHk41mIJ91CojTvt?=
 =?us-ascii?Q?Ar1jCJeRblyvNMXZVG2idXt6FTojIZlUCkjR6o1aFF8+cmAieceHi6Kv5284?=
 =?us-ascii?Q?u3do3YZNemgvMFUxm8Y6K7kgzE1HcE5OEX/dnxGJlbDal6urWmdxF/0XcAd+?=
 =?us-ascii?Q?2s4xtGlTy5u5wEEwP7bfhmhK+n15mD+OEIHq0qoaRCfuVGeuLmNHIRNXXNvf?=
 =?us-ascii?Q?/6AM1KRvTfNtmnnIAMpzLHps0VdAx0o2YdubzJRfVlzl+bBmwhSGqA7Prgtb?=
 =?us-ascii?Q?V9Fjy3M1W4gV8eJDaAuA+9Q9H91zRsyWdmxPV/Hpn/p6h9IQ7x1PZesJ4hOq?=
 =?us-ascii?Q?mjxVDyKzFEmywBOvCVOvIx/bqicRHZhYNsDRn+DZjBPir4GcBiLpbWWob5f4?=
 =?us-ascii?Q?EFzPAQIn/fCnoUd/Pzgdv5OCXCPowDjS9ANkJlsOti0LA6sABEA2dtlEF0za?=
 =?us-ascii?Q?d01o8GAoBqO2OBwWeQMjs37ifwPeKMbkEggjvYPIVvfj5W4FvDO5cd/6ELcH?=
 =?us-ascii?Q?m1/kATS5RQo+MGRsYLIH/jGJfrO9cULf4WomDWlxgXp+RM2kdBoCbGMbYf2z?=
 =?us-ascii?Q?ekKt+YnxEk34CAcGj1aYFkreCySwtiA5fcsYEO7jDTmc9UWedoi7VR4YmH2r?=
 =?us-ascii?Q?ysjEEuBw0ANy/yI/HMAExBcbbT17XwO7phE0MpjzNjJgP1UOlHtzRP5DIOBw?=
 =?us-ascii?Q?F3hs2543k3KZ/vLmYFNNX8WoykfJzf+n8bX2ZOmYJYxa6WjJbnZH7hG75Cgj?=
 =?us-ascii?Q?7+LpVbQGcdbWrj1SvJ7T+5wAAXDPF6OK34Nz3ppni0qYwKwKHO1IxflPWr7p?=
 =?us-ascii?Q?oFleuHvUfYFUpq8zMBv0BdH9+y0ghCFyqoBYi4qJn7G3gBQuA5CzKc1NA01T?=
 =?us-ascii?Q?gXd++3KpqVWahee2dlYhYtKUA+mubXHamqsT3FrXkhLH2syh1sKw85noxwvg?=
 =?us-ascii?Q?X2J/2SqnMXD9GEC9eS/BXPF1uutXcjOFzTUJllKEsQKc/a5yQOI+8IScotWD?=
 =?us-ascii?Q?C4TXPCUyN5F1vHAtQOCk+UpE6ohM7L+EQnHpZpa4IvByHqziEBAGRCF49LPM?=
 =?us-ascii?Q?8hCkdkYbnVIbjyq1WCe6FcZof2MLyHejf7D2OQjefgHxCdtO48Mrooa5AXvk?=
 =?us-ascii?Q?Sw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 425fd910-2f71-4103-4613-08dac7ebf5cb
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 16:02:30.0905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gPI0UBRwmYuuogxHN8baTpVvWiN8lIwSFkPyPQ6+7y1WCtrORDQ0I3weutbSb5yB3ylvBORP0vMxga015NkMjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6832
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:19PM +0100, Thomas Gleixner wrote:
> PCI/Multi-MSI is MSI specific and not supported for MSI-X
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/iommu/amd/iommu.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -3294,8 +3294,7 @@ static int irq_remapping_alloc(struct ir
>  
>  	if (!info)
>  		return -EINVAL;
> -	if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI &&
> -	    info->type != X86_IRQ_ALLOC_TYPE_PCI_MSIX)
> +	if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI)
>  		return -EINVAL;
>  
>  	/*
> 

nit:

maybe better to merge patch2/3 since both seem related?