Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 07:52:52 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        <linux-pci@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        <linuxppc-dev@lists.ozlabs.org>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 02/39] iommu/vt-d: Remove bogus check for multi MSI-X
Message-ID: <Y3UHVGptkWZnIEgI@a4bf019067fa.jf.intel.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122013.713848846@linutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221111122013.713848846@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/UCQHGbF2Yoti2eipVvlZSxNSnp6giUR30ymsXQRpqy8DPesGY6qVZ2Mp9Sw?=
 =?us-ascii?Q?h+tbpaqGzekgmWJ6Fz15b169Jbl9awta/8xqlBvseV7MKBK+maYTbxuU5qsn?=
 =?us-ascii?Q?pB+LobnqYDf77VqSXAP9iPkMXtOFThG+OFVsJTmrhxQKE/P+SM4FVCejd+Kc?=
 =?us-ascii?Q?aGIKsaX0re6WsEMCkB5smgDbsbyXUZa2ZW1w6UAVMJem4F/dmiLXlKonUulx?=
 =?us-ascii?Q?ysXO3iCkAE9RWT0NNSUxhqxzlZMLSsY0Njv3+HLwBKYiAli6k6nDwL9jeo7Q?=
 =?us-ascii?Q?0BOESG4niEMbPy7ryaRhR5eTtIZiO0Wh5xhKCFKxTK7v3xsU6w6shI4rvERz?=
 =?us-ascii?Q?AopHJKlARKbPVQYpBEhFNA+7y7+EvA5+vSyJWKD3KgtgLBCKB0Kb6At/gikw?=
 =?us-ascii?Q?Jjv8vKqtFwAn+gy7PZE7iqaSUYXMthsUmCuwX3jF3xaZ0ueXsGGyKUFxz5UE?=
 =?us-ascii?Q?brLO9/tq98e+t4hlXP/0rDSAwOK+ZKxek09KL/IsEBmzoJqgmgKKhq6GhAdy?=
 =?us-ascii?Q?mjdXm0hfI6icq00ZBoZ7GiZ/QTHc6IEsw2vUYnx4g1gIdTbEd71qAuv3Xcxt?=
 =?us-ascii?Q?9+LXKZigVSr3j2pfO8JoqkfwvJVosyIkjMhJC0gIKhlFnsrxR1fjKmCZuneO?=
 =?us-ascii?Q?FMFE5lVnaN567+fA2q6v59rkLZjPw5XLgBhjtR8kL49Of+oIv2HLzXYes1hl?=
 =?us-ascii?Q?PEPXEL8lWi/ys+2ZlHZtMa9A6ZsSWJdbLKrD6H6fynub4MG8hRceA/uuHD5W?=
 =?us-ascii?Q?VrSrU7Ps/H0eloqkleyV9DxfK1N/KVk3kNp74hM7LGoYiyFH3+B+CLUWNxh2?=
 =?us-ascii?Q?kDkEjcqrg0vuNuD3TaeajhomSXLx0gR19XYqa0OmpWxabFHRkCrWKTvtn6cD?=
 =?us-ascii?Q?tdlVDcDOpg2465VExuB4C3AHGhIE82Cfw0dzA6Epe+ueXd+boc2YyIOT8uzv?=
 =?us-ascii?Q?9andhIU7Znq9tSqT68asw4v5+hDB8nAzD/ENAO1dsaYxIs4AJ/TRJCQld4wB?=
 =?us-ascii?Q?Xq8gduvaGOwLDpBpQUTLdAQ2dT3u9iW8y+jV+kB4idE9w6nB1w8I/i6FP+FA?=
 =?us-ascii?Q?wqkQ6PnalR5gFTzxdtuMOdpnfsDU4xfp8qjUMi6W7MVTm8u3T0oyKssT60sw?=
 =?us-ascii?Q?9PMzOIszmH7RxWByDUjzfzLX2jxTHhkjba1CmPXayxMLV6Aq8oM+FWkq+k8B?=
 =?us-ascii?Q?CWkDKMiu8BRfNzdI5izFMZXU8vQpNUyZxgQDY3C158gdqal4CiG99cNmoYGA?=
 =?us-ascii?Q?yif5So6BF9RbP1TucWSfs5FiVvqsUT0+kbZ6cLDG964WgpOBVLj+KCstyJ3H?=
 =?us-ascii?Q?o9Bh6i7BkBsV5dfJJw8OYq/qaFA92B4+JkMiVRBrU4UONi6jqm4d1znKfB5u?=
 =?us-ascii?Q?D1ryKrjetfBqhxJYH30rGHYGkSqszhtghLXe2D37w36mwqeo09iEP3XqUdwY?=
 =?us-ascii?Q?RqHcY9e+DEHFg3OD4TR85J8WDMG0eMqjBq0fRl3C1X81/HJKxnZzg49nogks?=
 =?us-ascii?Q?pw0tuOPwS1A3R3AsADYg2ieaJXiNHoJg/sxeUdl9wLP9VIAB7421UN3WhA7h?=
 =?us-ascii?Q?v8fWTIwRr5qbFYzhnUHj8pmvl+fTtGJYqMYwr5c8luWKhU0wBeok5NSCeUzS?=
 =?us-ascii?Q?7g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1917dd24-de18-4d92-a23d-08dac7eaa20c
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 15:52:58.2302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b0+Qs0R3avDukFSO4bMIXW5Ir8LhdAKq6ZE5mGSAbwbP5eV0+u1NSWUll2qJifdUgMmOFBQ5UDsMxuRr9fg+xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5145
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:17PM +0100, Thomas Gleixner wrote:
> PCI/Multi-MSI is MSI specific and not supported for MSI-X.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/iommu/intel/irq_remapping.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/iommu/intel/irq_remapping.c
> +++ b/drivers/iommu/intel/irq_remapping.c
> @@ -1334,8 +1334,7 @@ static int intel_irq_remapping_alloc(str
>  
>  	if (!info || !iommu)
>  		return -EINVAL;
> -	if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI &&
> -	    info->type != X86_IRQ_ALLOC_TYPE_PCI_MSIX)
> +	if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI)
>  		return -EINVAL;
>  
>  	/*
> 

This check is only making sure that when multi-msi is requested that the
type has to be either MSI/MSIX. 

Wouldn't this change return -EINVAL when type = MSIX?