Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 08:12:26 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        <linux-pci@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        <linuxppc-dev@lists.ozlabs.org>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 04/39] genirq/msi: Use MSI_DESC_ALL in
 msi_add_simple_msi_descs()
Message-ID: <Y3UL6t5FCdCOIxaS@a4bf019067fa.jf.intel.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122013.831151822@linutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221111122013.831151822@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dj+qjh1kgIy2er7wXAbdY3lVLSZDY7NTXmOlVsR0nNml3zwsVYnLbiOIXs9s?=
 =?us-ascii?Q?awShNcLP+WCi5s57IwLWH1x/50fhJnkBEfWc9iqoHgIdgxKCj5h60ba7S4g8?=
 =?us-ascii?Q?pZjCmHASr1HC8upejf8l/m1J3q6vLNOHAOg0sSYjEim+J2tqtUH0ZGJVPmyj?=
 =?us-ascii?Q?VPjzywDhjgHcK+lZ4AfmZQ7Frv9V3/YpSgPVucmsXrJ2cGYkpXZxvIMYijZx?=
 =?us-ascii?Q?Wjj0wen4dIhECDJRq/8fAr5/lrUhiainPnIQ8WOz+khQzfiBlgEv2/34RQiU?=
 =?us-ascii?Q?Qz9/XsODFvF5RPweR9cv1COqlgADkk45xVV4Q6QPvU/AQq7dkk0vAHBmY9hM?=
 =?us-ascii?Q?1ZZQQxysYvMLoMMRaFGfpvN6aTsuOpapLlJvsdGZMQET8n8puLfB95EnXXsR?=
 =?us-ascii?Q?r85WdA8uAYVeTBbuuBNu7a+OAswZzjo4uDxCrVnJoOLcVZFCWjQY7Ps3lftr?=
 =?us-ascii?Q?PbpDznX9MRKKjeNg8UK3KeCY19qhhPsfgBS4Wz4Dj2o+7X6mslIUtZw6Y7oS?=
 =?us-ascii?Q?6TI3AgtXMhL/1M9wCAfc5xmaCdvJK8psvYYuJQM0tM+Hu5pYxDObCtXec8HN?=
 =?us-ascii?Q?rwzWpi4sUdfQQKhfE/kos8bxiJd37NPuculmG25JrqG3QGXsWPKy/paWvsDe?=
 =?us-ascii?Q?XZcJrXNY2pluPJHDRD6Pl6ADW1Y7B7W1ssnbWPJMW9mdx4ojSqYdGokVmxdS?=
 =?us-ascii?Q?/ipTukw4zTMEeQAKgA+3m+1IwnN4aXKIEzvDBH6KazJxNCgIaGHxCwaqplaq?=
 =?us-ascii?Q?HudFRxOTqi0XTg+KRaRE0CEK0Gdp9uVmNe1b8X3G0+lCQRiAm46+jfAMVok+?=
 =?us-ascii?Q?G2OmnOim49sMugd1hxu3ItQpGR07gRQip5feAbd59YHkkfMN7k8GXkUgyh8q?=
 =?us-ascii?Q?Imqvej8BAlP5yI3RxWD9cwqNFMCZOo0uqRvaManYOzIDaoxgF+7r/mS3dYXf?=
 =?us-ascii?Q?NmWebUDvR8naLcT81Zgqbx17ksLsDkjp7o40xMNTSLooUrl/SKlXTdLMIBtB?=
 =?us-ascii?Q?NJ4rNAc9uq+KrgyyH9yaifhg81urcrtKIEJkCIiI3O9XbpO7TNWN5NKrz4Zk?=
 =?us-ascii?Q?Ao5VnI30/a0UP+8+iD81aBAigwLarFYlkEgivqFVa7qV4Ncd8OUlGM9XKqoN?=
 =?us-ascii?Q?tngwXcyTWweCezhBjDzG/uYCt3L8evQze6SLtE0le+Dy1yCzT9scnriIzeTA?=
 =?us-ascii?Q?HWfUQxVzOWRJuXpWP2jfELRa4fFNIw7si+SbxqKbEtSGVSzY2G47fbuyROVU?=
 =?us-ascii?Q?FdWJnWQZKZEXYQ9C+L43Mb0+mMbXv89cTziv1TQlGrttE4j40nlv8TnfFp7W?=
 =?us-ascii?Q?DkuKL35MWV/B+XgsoXDRlyqZq+btJLyT4GrmTvfS4f+JJLmpIkc40GwwVm2F?=
 =?us-ascii?Q?9p6zUMsoFD3xIaTNr/wc67npmAlqvr37GAeNXORtY/ZFG6i3lcugXZwisEjn?=
 =?us-ascii?Q?4hNGHX0oVb53CAACEYxiAzzMhKZ8JNlJ5y8Q2R+xJNYp7TEqRrKWhmLaVFN9?=
 =?us-ascii?Q?iGDU1uPOeOSwtCNuT7Czv05YfBBYWFAIXbUjwyK7NGwGfsSDTRivo20ZZmrj?=
 =?us-ascii?Q?57fLRdkkDgpkiCA9LZ/e2mzyNX4Qzv70HuPziUunX4v+jReuTX21RqC9l3+c?=
 =?us-ascii?Q?xQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a521c564-fc9d-4f45-322f-08dac7ed5e2e
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 16:12:32.8546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yfAK6R+frDp1FI5XAGRzcdY1mq1VvZcHOyD/wTEj0EjK8KdBNpZ04kjhBdrC+T90LzNmJSIaQpCyUU9MW04v+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5810
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:20PM +0100, Thomas Gleixner wrote:
> There are no associated MSI descriptors in the requested range when the MSI
> descriptor allocation fails. Use MSI_DESC_ALL as the filter which prepares
> the next step to get rid of the filter for freeing.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  kernel/irq/msi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -120,7 +120,7 @@ static int msi_add_simple_msi_descs(stru
>  fail_mem:
>  	ret = -ENOMEM;
>  fail:
> -	msi_free_msi_descs_range(dev, MSI_DESC_NOTASSOCIATED, index, last);
> +	msi_free_msi_descs_range(dev, MSI_DESC_ALL, index, last);
>  	return ret;
>  }
>  
> 
Reviewed-by: Ashok Raj <ashok.raj@intel.com>