Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp942156rwb; Wed, 16 Nov 2022 09:38:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf703dT9/aoKjPA+NbwWOtzQBMALW8OYE6Xd8T+3oIfnHrIkzgx8pu0WXFW9vVHeSEZGrtXk X-Received: by 2002:a17:90b:b04:b0:213:c04:42be with SMTP id bf4-20020a17090b0b0400b002130c0442bemr4753930pjb.61.1668620311225; Wed, 16 Nov 2022 09:38:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668620311; cv=none; d=google.com; s=arc-20160816; b=Ab5J2JeGy12GWj/yaZOaFJ/9sDPnwM57UQmtvlRkp58TMZOYcvlFLp4P0nIrHRX2LJ caqv+7kPg+gmdGJmbdqurakUcIQOhIQG794mRlnh2tPdRr9uqmGvb8eZ5xD4Nei8jHVh 3BIfQWV1QLgDgeTKh47N9/2vWgAmme6XH/HUEcCY+gXJlGx9xODQnBteBiIGLRG0GVdQ 6fhKM/J6Xs3tr1duY6jkQ/Dj6HplBW0gm4kprQ3UZnb3jTNs5hSuy2kTep4qv/i/7vlI 5KzjlVVwXSczZOlGMm13c0zmeSdsp38ZNmTOf5ak0mS8T5TtBPDffPc50H8lE/L1CQeu 2DDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=gMtjvKuzan+EitBOPG6mbHkFHraigrEr8V57kF2xOHg=; b=DlNyfw8mdDmijhtCOOtXl2s+ZKWq0EzVDlNzYtaSkNHb7hwbVMEv0mZQibHjnsM1u4 QfpSIt9SPiX84i6PWkb0TwmIco+aNVnWgqpWgKAPr9g0ymRtud27XpuBsra36cZy7H91 g3yuyVnKKblrIk2MLmlANImaIQndDcP94i7Pm5cTlo8Le71/jpBuNYA7QID4IpTlx9Hh erxB0XVEiFM6D/2PX9hUYAa+Lpym3ZSPpyoBnroQTr2fxUquZwN8hGd7NMWM3evw9R7L Q4s+O43icYeh0I2mTEkjreMox9VMn34fHIW7zbYK+pKtiOvPSvDl71Hp/mwJdqRYrfj3 K9tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=GSlVYVS8; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 38-20020a631066000000b0046fc9e82c99si14330747pgq.206.2022.11.16.09.38.18; Wed, 16 Nov 2022 09:38:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=GSlVYVS8; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237359AbiKPRHf (ORCPT + 90 others); Wed, 16 Nov 2022 12:07:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239017AbiKPRHE (ORCPT ); Wed, 16 Nov 2022 12:07:04 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A5F59871; Wed, 16 Nov 2022 09:06:32 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gMtjvKuzan+EitBOPG6mbHkFHraigrEr8V57kF2xOHg=; b=GSlVYVS8cqCCkAtiXSIgcwB7/v7yViOvR7AfIcmAkV1Fwnf9lQi1GBcnX5Y4Ju4s3TqUax SI7kdSMfFe52kUeFZogQm5vYXUYsQ711qOhOf6n+5fDc1uCT2j8ibEPRae5U0lLpGIs97Z +oTWClBQtsJ9RI/Y/awt0yHaTJkylyAH9nm54r3Ao4AcyOugeX6hASbTTKB68eZNNoG09O aOApii33W8z8RhuR+jxUJIV+zaXsWeYkc9ZbH4P9J+xTs3XRmTsdliMVoYaHNewOYjAErU Bshc1/9AxWWYhLyd7h5nzJ+ZgqVXWfEPoFB0udtJOlGokuJapopWZ46yQfZLQA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gMtjvKuzan+EitBOPG6mbHkFHraigrEr8V57kF2xOHg=; b=llOgpdV3hMHSBIhQev8a/HMzrlttd0KuM/S/oask7Lf5ArUR3Gu3hdMmAW6RHbysShpDRH fHUSj6rq+ZuC3FDw== To: Bjorn Helgaas Cc: LKML , x86@kernel.org, Joerg Roedel , Will Deacon , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Marc Zyngier , Greg Kroah-Hartman , Jason Gunthorpe , Dave Jiang , Alex Williamson , Kevin Tian , Dan Williams , Logan Gunthorpe , Ashok Raj , Jon Mason , Allen Hubbe , "Ahmed S. Darwish" , Reinette Chatre , Michael Ellerman , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 22/39] PCI/MSI: Move pci_alloc_irq_vectors() to api.c In-Reply-To: <20221116162210.GA1115315@bhelgaas> References: <20221116162210.GA1115315@bhelgaas> Date: Wed, 16 Nov 2022 18:06:30 +0100 Message-ID: <87k03uq161.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16 2022 at 10:22, Bjorn Helgaas wrote: >> + * Allocate up to @max_vecs interrupt vectors on device. MSI-X irq > > s/irq/IRQ/ > >> + * vector allocation has a higher precedence over plain MSI, which has a >> + * higher precedence over legacy INTx emulation. >> + * >> + * Upon a successful allocation, the caller should use pci_irq_vector() >> + * to get the Linux IRQ number to be passed to request_threaded_irq(). >> + * The driver must call pci_free_irq_vectors() on cleanup. >> + * >> + * Return: number of allocated vectors (which might be smaller than >> + * @max_vecs), -ENOSPC if less than @min_vecs interrupt vectors are > > s/less/fewer/ (also in some previous patches, IIRC) Will fix.