Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp947374rwb; Wed, 16 Nov 2022 09:43:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf51Cyu/e5EVRFjwgu4gtmxNwu2mCzJctgc2BggzuC/JljDVPIppvAEYHFInTBlNKiziKbuL X-Received: by 2002:a17:907:961d:b0:78d:9582:dfbb with SMTP id gb29-20020a170907961d00b0078d9582dfbbmr18401195ejc.612.1668620595378; Wed, 16 Nov 2022 09:43:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668620595; cv=none; d=google.com; s=arc-20160816; b=iY3eegDgfwXmC9ntKwiPQacIVzlPCjcJnyvzFMjzkFvxI5zPQWVsDMkaxKm9kVgTOH lOI2dJ3rmyHMhfIkK/54XmJAy7T+t+xSdtdXCcQUxDZeUDm6ZomjJN3F/vRIE8zyIOq2 aWNetb+TjNLXuekR5/8ygo0A34xJbChvwjb1Y0Bg6JEiMAso6lQHHeBaBe+2n5gLnMGi G9BP5FbCEL72nkHgiiVdvs8EfmVuacbLg4PMA/ct7SJjQ26oocfcLlynwH8W0B6u5hsP 5VEhu0vBXn1Yz7vWc27oKFNO7C0JkeLhbN7fklya99phRSZc/qqSQJCNzo4E0r284Hxg yLYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WKnzWnJFg2fZWH4ykB0KcBBgSiXQB71+bWbEP95juoM=; b=bTItcEsZ7i4R5v4ZgAIPX18CsKyerl0O9Vj7BMPOdffAzRu7LSbs8Xqp5iLFlfOzju qmzDW7rYMnUZqCfdwXT6zkINCz8lLnqvqYny6uHTJHgJWWhsgjHJfefYGUFCS4xOjWdI cNRi8Gv3NU3el5Cis51uMSjB0EYmlqaUEVdkfkvGrfuHtWQvpmpsud7ANsDok6EMZqaj Ab0yv8C3payqqqhfzvEqazvr6TSgStzxcB+sBQ6JpIoaB2PC02/G/pAG+vYDXh3Jlik9 4Uruep2HTqnRIecsWG7FiNrV2+aaQmJQAmNP+JUBmjEQG3MOU2hwiOeFp5vHeUQ/NNu+ MUjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nNZkd+9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds5-20020a170907724500b00770872942d8si15623486ejc.958.2022.11.16.09.42.54; Wed, 16 Nov 2022 09:43:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nNZkd+9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234016AbiKPQtz (ORCPT + 90 others); Wed, 16 Nov 2022 11:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233206AbiKPQta (ORCPT ); Wed, 16 Nov 2022 11:49:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A6C6E41; Wed, 16 Nov 2022 08:47:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4583FB81DFD; Wed, 16 Nov 2022 16:47:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 635BFC433C1; Wed, 16 Nov 2022 16:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668617230; bh=Ma1zaxWQ8C5IEvymQzwpG86FF0hqFrdFIAMGPNWoyfc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nNZkd+9c+i31Y+eNwKIMECW6q0wcNHKvGcyMv95cUwC5EJDsNdUznGA3K3/DVYYCV 7qpwF8TAk+YTswLasgXAQKFwnqeNU4WtiXNP68eS08xsufAVDhYjEVglr2+VoUczPk pyzhA/WigMJeaUAOl5R57ivD1uSsq384w00nADSRExImk1XsCMZCNpoMhdylF83uui /z39QOTw7FM4UlO0RtgR/t+z4hDIIo32XZbXaN2+USyQvp6tV6PM9n6+HwzMYhK5/P O+JK8Xt+tGBq/RbUtnetnsMKZt4FDIbkCtHkkP5SQU+0a9lgTqx4GssTdwTFpeHeyZ 7MXLEY+v6IKRw== Date: Wed, 16 Nov 2022 08:47:09 -0800 From: Jakub Kicinski To: Shenwei Wang Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v5 0/3] net: fec: add xdp and page pool statistics Message-ID: <20221116084709.6b7eeaea@kernel.org> In-Reply-To: <20221115204951.370217-1-shenwei.wang@nxp.com> References: <20221115204951.370217-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2022 14:49:48 -0600 Shenwei Wang wrote: > Changes in V5: > - split the patch into two: one for xdp statistics and one for page > pool > - fix the bug to zero xdp_stats array > - use empty 'page_pool_stats' when CONFIG_PAGE_POOL_STATS is disabled. Hi, IIUC there was a previous revision of this set which got applied too hastily. Unfortunately that means you need to rebase on top of what's already applied, or add a revert to your series. Otherwise the patches won't apply cleanly.