Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp965691rwb; Wed, 16 Nov 2022 10:01:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7NSX8xkhIPy/WOKP0dr69tckaXo3RxWf2pNdZvzUjur2JzmjHXMfY/G42UJY3gm854Up2m X-Received: by 2002:a17:906:bc4b:b0:7ae:37a8:9b5c with SMTP id s11-20020a170906bc4b00b007ae37a89b5cmr18323440ejv.241.1668621664917; Wed, 16 Nov 2022 10:01:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668621664; cv=none; d=google.com; s=arc-20160816; b=NybnQxTCdbTTke/fOgHGJzkRZeqlpbYuqVNS46Jwq+xwfcZK6lqFsTHVF3S0cjxK4M P2yHmaGJv/GFx54fTadyjiofKXNWmhzSwY0DKTaBX3OwsVHaQPJ0osGLHyatJaHA7/PT x9k//x2VK70Oy9r/oiVQFLY21T4tp4sQyCSDz4/pzYOTA9+hoCHIKKfG95dQY0s4ik7S YsZK0ulwU9H/agrcC/yjFUgWowGWwgReLWApH71X+SqB1NyrKOvZnLutp8igCdLHwHt4 yYfySjI788AAI6j75h6ca9G3+M6pz88aEDzCSIax2LmiZWF/V67yAc3/uzGXO5OqOuxa 1Muw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=73/k+Pqe+eIdLrX5pigBKT2S4Kr0WftEUmk46mQSZq4=; b=WWBCHKl839f7nhXJ2CxrHsxV5YLwfqCDyVZ8azpJTLGKq/SaVy8a7jToY2mSXU4Ve+ d7kQFcdSTHL77Am1ppXmRRbNjSclRnI5WEUPqoPjnmQz0S+pO3N07bzmiIKbyKSrjXYX lT44Vo3QOurjBQqiUhsHzDrPWhNQBdbaeb8dkIFs1coKgGTU8ouLo/qm4LA+Xz3dobJ1 t9OuH+ajRZR4TZ1lEVS0n7V1h/jg3BSfvTwVsZU1TEN2P/MH7hTe2eV/oGgrJ3VKuR5o HKWjN7dymbzEHIXsbeRhoMBOCwRk2AtWGp0NnYbaXmVXiN2AWIFau7+VWXJEd0HTD2t8 Mjyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KDnklEjx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="/lLRXLA6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bj10-20020a170906b04a00b0078dc5c888f1si13292622ejb.135.2022.11.16.10.00.38; Wed, 16 Nov 2022 10:01:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KDnklEjx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="/lLRXLA6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233779AbiKPRCf (ORCPT + 90 others); Wed, 16 Nov 2022 12:02:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbiKPRCc (ORCPT ); Wed, 16 Nov 2022 12:02:32 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355771B799; Wed, 16 Nov 2022 09:02:32 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=73/k+Pqe+eIdLrX5pigBKT2S4Kr0WftEUmk46mQSZq4=; b=KDnklEjxF7By95INYq+dtxZdCdY/C01Z76Y3GVUU4F3KTF6wB9npHtyJk3/UAgAb2A+Kl2 OO8l0ogbhCgtGOzGSm278d7Ntq9gnX5OWX3a6rnZ4IXbyxowohL3X/waIh8pZdLxNBb0T6 AL5Ba0JCMIs8eN7MF+cdBQIMfREMbj5b283h9U+0gizZueBJ2TbopR81DOJDkA+yLscvLG 5FHYQIDq160F+/ffXyNSwf1Pr1MYqKx6AnPF4ABlFzMU4zcMo5Y3U2X2+lhW6JuSf+6b83 w3dIwnYYAiAmM5Vry7hYiK9ZrD8cGZlRqSpgOZrAqzDh3QEn/1udH8Sv89Gl7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=73/k+Pqe+eIdLrX5pigBKT2S4Kr0WftEUmk46mQSZq4=; b=/lLRXLA6lsq9XHJeSKJip6VCUSvS/TfY12kAhlPgvsYIqLFWJcn73WeC2hRsndLX2l+7Fj tgC7oNEGsKmJLACQ== To: Ashok Raj Cc: LKML , x86@kernel.org, Joerg Roedel , Will Deacon , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Marc Zyngier , Greg Kroah-Hartman , Jason Gunthorpe , Dave Jiang , Alex Williamson , Kevin Tian , Dan Williams , Logan Gunthorpe , Jon Mason , Allen Hubbe , Michael Ellerman , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, "Ahmed S. Darwish" , Reinette Chatre , Ashok Raj Subject: Re: [patch 02/39] iommu/vt-d: Remove bogus check for multi MSI-X In-Reply-To: References: <20221111120501.026511281@linutronix.de> <20221111122013.713848846@linutronix.de> Date: Wed, 16 Nov 2022 18:02:30 +0100 Message-ID: <87wn7uq1cp.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16 2022 at 07:52, Ashok Raj wrote: > On Fri, Nov 11, 2022 at 02:54:17PM +0100, Thomas Gleixner wrote: >> PCI/Multi-MSI is MSI specific and not supported for MSI-X. >> >> Signed-off-by: Thomas Gleixner >> --- >> drivers/iommu/intel/irq_remapping.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> --- a/drivers/iommu/intel/irq_remapping.c >> +++ b/drivers/iommu/intel/irq_remapping.c >> @@ -1334,8 +1334,7 @@ static int intel_irq_remapping_alloc(str >> >> if (!info || !iommu) >> return -EINVAL; >> - if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI && >> - info->type != X86_IRQ_ALLOC_TYPE_PCI_MSIX) >> + if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI) >> return -EINVAL; >> >> /* >> > > This check is only making sure that when multi-msi is requested that the > type has to be either MSI/MSIX. MSI-X does not support multi vector allocations on a single entry. > Wouldn't this change return -EINVAL when type = MSIX? Rightfully so. MSIX vectors are allocated one by one. Has been that way forever. Thanks, tglx