Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 13:53:54 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 15/39] PCI/MSI: Get rid of PCI_MSI_IRQ_DOMAIN
Message-ID: <Y3UjsjX0T6+03RzL@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122014.467556921@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122014.467556921@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tNwFY6BYuLhArcCcpmOSe51jpoRfyXRZjUlcD6X5LfZREH/di95ydUJMsEyy?=
 =?us-ascii?Q?kKGtbnc1uGgxutuTOfxTc8t5NjIROCGmsN7nA30PW4B+tIrSOkYmLE1prtCS?=
 =?us-ascii?Q?SFyH11RM1H8DpjEvwL8GX6KdHpJfhREjdbDYhdgxsmeb9UlSUlOvw5ZKZ9dN?=
 =?us-ascii?Q?cmxgo1tN4Dt74p8+jZRlNCPbtVriFG0OWXLMAijryFsQg/FyhgDP9VP3BEud?=
 =?us-ascii?Q?D6+i9Ty8vzB6K2Ke3c7jGkbx4LUGktuWTQz2JUMaKUXVCeksGQp0jTAx20Oa?=
 =?us-ascii?Q?vA8u3h/c+gppGjVirbM6jk0uWUi5GL3t1zBHNTRc1nCrHg6O0Oi1pzcD/O1Q?=
 =?us-ascii?Q?0V78c+w6xC0iTe1CzfqhjG+hM7bhU4AHrw3sv6XPMO2YLkBdb2AVtKmiXUKa?=
 =?us-ascii?Q?0ChA6BaRCzXQyWHDbjKpTauNi/Miu21mPTQWNu51NFgZ4wiLsADhw5lsge20?=
 =?us-ascii?Q?yi+sS5Yyj6cUiLIhiCCcr0KRbB7xBCzNWP/z3jgt81EaQA4gC/uVoEmPP+Vf?=
 =?us-ascii?Q?bsvLZOiRJ5eY9dnFqby0dnZaiKtSb9936snRn3Q5JhwiQo3BlweIQ35pHY0i?=
 =?us-ascii?Q?yJQvsN5I/nKXJajKRCuuo50/VZCsxlt0IYtJew/hRuYXEFMlmHz3UmQKPHwA?=
 =?us-ascii?Q?R5ov2JArsv3bSK0DShMr64DNJyoi0xHkQ1zOPLJ1asGi+sUBA7iLLcGszRHT?=
 =?us-ascii?Q?2s8XbgrEXEMnKyG2UVQXdCdW1aacoPZMJCLRK8lc+DHCpq8M811kYDTJQwP7?=
 =?us-ascii?Q?4z4UoNmgQWgn/DC5SrJnQKnXF5LKmAB5tmvc5HuCul+/y2SiPmH/zdGaQ0CU?=
 =?us-ascii?Q?0DskMeBNHgCLJnBCDt8w6e3uGdP0K5ez/5mMx3VOa8Pn2z9Gx2n67Pz5Ii/n?=
 =?us-ascii?Q?NfA5BPW5kcpcunKn49sfV/xPiWv1H/VYya1NHFT35TiZP6E3smEUqpsz6mSk?=
 =?us-ascii?Q?TBCk3hfwM8srYD6DYGoT2KbcqB8t6V2vPCkSH5Waw7FlL8yQGKKWqv5qqow3?=
 =?us-ascii?Q?JVu1hmd3oKcDCMx8u7L/e+WbivrfEYfgmQeI6HjN3bB2eLMJ1EyMLmc5Nda/?=
 =?us-ascii?Q?6+EAMlNZSxJtEtGFL1u/91VAQbyD7FvgU9utHsJDGbdn7ecePI7ruo09wqF1?=
 =?us-ascii?Q?A9mDK8LpXv5qcX8f3McLeY/V0sQgyhPnUoyYgs04ch1jgTvJBVKEI+qfzoA8?=
 =?us-ascii?Q?98vO1PphF/RDoqPkMpBkH8XWwRbR0MXfg7JKBN9amrvGzkUydropDOpvn7Wl?=
 =?us-ascii?Q?ampE6Vx8VqmNZhalCBLB2JaU0+S5aIJZq7mwB8bX5SSyZ+ElCh7Bh2qu4+45?=
 =?us-ascii?Q?Lp3OHZB756o247nbM000I8UXDkVEN05r8BJdSLcMThFV1BH1edDbPFdAKw6P?=
 =?us-ascii?Q?PXBI97zEmgrMZl5V7Um/4mvJse2cPzd57bErZ8EMikIpHvqRozdy2q6iXKvk?=
 =?us-ascii?Q?uTgIqDePYerWaZRG3fj9YYrg4Me5Js5r0WEQDewpEECeGjlw2L0GoebQk4fn?=
 =?us-ascii?Q?jWGzC18P5sjQ50iV/txfI2GcEjRxJDGah7P+imWpEmQ6F0tPq4VL7MCpfslO?=
 =?us-ascii?Q?NPaivbmtCAQY91K3oSn/XP9JqFQGksPiid43BsqM?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5196369-b94f-4963-f1fd-08dac7fb8805
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:53:56.1432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bD8qOJ55SNPLDsCaQABFJqzlCovuYGKSUnA8iXvq4ENjhe59QHyS0V8zFPUyxhhi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5395
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:38PM +0100, Thomas Gleixner wrote:
> What a zoo:
> 
>      PCI_MSI
> 	select GENERIC_MSI_IRQ
> 
>      PCI_MSI_IRQ_DOMAIN
>      	def_bool y
> 	depends on PCI_MSI
> 	select GENERIC_MSI_IRQ_DOMAIN
> 
> Ergo PCI_MSI enables PCI_MSI_IRQ_DOMAIN which in turn selects
> GENERIC_MSI_IRQ_DOMAIN. So all the dependencies on PCI_MSI_IRQ_DOMAIN are
> just an indirection to PCI_MSI.
> 
> Match the reality and just admit that PCI_MSI requires
> GENERIC_MSI_IRQ_DOMAIN.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/um/drivers/Kconfig                 |    1 
>  arch/um/include/asm/pci.h               |    2 -
>  arch/x86/Kconfig                        |    1 
>  arch/x86/include/asm/pci.h              |    4 +-
>  drivers/pci/Kconfig                     |    8 +----
>  drivers/pci/controller/Kconfig          |   30 +++++++++-----------
>  drivers/pci/controller/dwc/Kconfig      |   48 ++++++++++++++++----------------
>  drivers/pci/controller/mobiveil/Kconfig |    6 ++--
>  drivers/pci/msi/Makefile                |    2 -
>  drivers/pci/probe.c                     |    2 -
>  include/linux/msi.h                     |   32 ++++++---------------
>  11 files changed, 56 insertions(+), 80 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason