Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 11:09:49 -0700
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     MD Danish Anwar <danishanwar@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Suman Anna <s-anna@ti.com>, Roger Quadros <rogerq@kernel.org>,
        "Andrew F . Davis" <afd@ti.com>, nm@ti.com, vigneshr@ti.com,
        srk@ti.com, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings
Message-ID: <20221116180949.GC61935@p14s>
References: <20221116121634.2901265-1-danishanwar@ti.com>
 <20221116121634.2901265-2-danishanwar@ti.com>
 <20221116160948.GA169555-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221116160948.GA169555-robh@kernel.org>
Precedence: bulk

On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> > From: Suman Anna <s-anna@ti.com>
> > 
> > Add DT schema binding for PRU consumers. The binding includes
> > all the common properties that can be used by different PRU consumer
> > or application nodes and supported by the PRU remoteproc driver.
> > These are used to configure the PRU hardware for specific user
> > applications.
> > 
> > The application nodes themselves should define their own bindings.
> > 
> > Co-developed-by: Tero Kristo <t-kristo@ti.com>
> > Co-developed-by: Suman Anna <s-anna@ti.com>
> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> > Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> Run checkpatch.pl and fix the warnings with the tags.

My bad - I asked Danish to remove the SoBs to lighten the changelog
presentation.  Danish, do you absolutely need to list everyone that touched that
patchset?  If so I suppose just listing the SoBs would be a compromise.

> 
> You didn't add review/ack tags either.

Those are important.  

Please send another patchset that clears checkpatch with review/acks and I'll
look at it.

Thanks,
Mathieu

> 
> > ---
> >  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml