Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 13:57:25 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 33/39] PCI/MSI: Sanitize MSI-X checks
Message-ID: <Y3UkhR1a4K0tZe6O@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122015.516946468@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122015.516946468@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LXVkSsxsXawRQDOhcdoFSuFtEB0StFwHWRacci+8/Yukax0xQIUPTQQqNE/j?=
 =?us-ascii?Q?iFhD6wjSa6PfXOZQth8RLl5b78BGLGn6h8SKsYsXrNGaVdFmGaJlVChZIbq+?=
 =?us-ascii?Q?LQ/8HY1S/vwvNuF7PuNYdWEzDrlusJRiwwGisOk2DdPbPhw5ET6sobUKkbXr?=
 =?us-ascii?Q?oRrEs6l0LEyV0RB1U/KZewrTrhMP/nIq8Des6PQ0EngjqoK68TkPX02qgo2r?=
 =?us-ascii?Q?HmESuJDcbivozH+9e84uLCM+82u+MdWSg2G7OTHWq82701lbAfjiukA0bN4S?=
 =?us-ascii?Q?FJ1eO2hmGn7UEo8gRS5XmMdLjO3Syr13WKpM3E1npK8e8eRILi2DE/lNCl73?=
 =?us-ascii?Q?XinzBH2y5swx8WCc3wadE15K6sL5yZRP7Jxg8PHHt6rZLeF9rpg3phH3K4dy?=
 =?us-ascii?Q?9HlVZQCYhRH4OOU4NU7PoOZAcCbqWTfwDWNwIS2gSOACWdE3RPIdWuMxrTWB?=
 =?us-ascii?Q?h7EkKo/ccQ6BiyOwvMRY0gH05hJDUMbpiQtw2+4Db6gI0tRleadReYsWyqWt?=
 =?us-ascii?Q?PRqfSq95n+5DWbf/nL0tOdFg8SFy6vEXdfVE7cQNVWan7vD7/mFi9+28QIhj?=
 =?us-ascii?Q?uTpjGGfjUBElOWXxUr4Vy90+aI7UcWcU8htvE5gRxwk4XCxvQMybNnzXLC+K?=
 =?us-ascii?Q?5cgq8dnhmZ5ySCVGAf8tNRlgjxI5y1vXHO06KeBkzE17r5nK+A+PuaEPjmyQ?=
 =?us-ascii?Q?t4BYELrrbgim51P+whFnWRcP/3EhFbEWLKDSOdq7TMzkPkYrC6Lv0+UlY4bb?=
 =?us-ascii?Q?kkIdG1HXrVXklRx98xLAIs1gELP+SE37eN96kZQt95SaGteTSQysoQ4h0rm5?=
 =?us-ascii?Q?Mf18eE0tZEP6d+iH3WZhUP5WdkfMVf9JHIttaOk1XQjI8h4k370KRduDjuFn?=
 =?us-ascii?Q?Nn1Sh33Ey6UC2MsqbB5QCmmWJ9fNLvLoWhzeHOEXryzhJkXFZqoE8yno+NgI?=
 =?us-ascii?Q?V3lGiyZb7OiEo+dtCppFbcJ9LmCW/CmmkqyVAnyn/VRNBWIMxEoptngFERoQ?=
 =?us-ascii?Q?cp2WvMJD1H5IVITOxUGZYzPmtRr062D7VaHXlK8yqckbVU7YpsqF5h1qH/xW?=
 =?us-ascii?Q?GiwQC+uwfpRThPa9q4BWKMoCrwnsLB14nW3FW2TYBHFy1Cm16KDOpejaOv/0?=
 =?us-ascii?Q?/boeBRVn06q7hpfq7I6suEvQfrvwTTnwwd+46rQMJs8X1UUMVmho4fBMyX1x?=
 =?us-ascii?Q?S8G4ZDHj2nDuyJSo1Vxsm+QuVr0kgeYLw7KdNLTA1ZEtN+4AOCSBMDxyGGQI?=
 =?us-ascii?Q?0EDrcbEPQQlAdYwOTD+QzUbn7gg4Y6p0X1+bLXJRCUnIBr1Hq37Ia7egyWG+?=
 =?us-ascii?Q?UGfCkLl0fDqhbFJ2FqBNvpx47n/mF3bYf/dbPGbi0W+M8TONDuk3piINcqSF?=
 =?us-ascii?Q?L4ZtawtyMC+kmjHUlfW5Ls/lPMVusVsXFEAk7UE0zuXeEWb3t7Km2QYHoXIt?=
 =?us-ascii?Q?936xUpuL/anrEetIGe14coaE5GM2SPFxLTiHUMeJcXYF5YbeJzaXDctOL1KW?=
 =?us-ascii?Q?Sr0CocNw/ioxImzFM6OcliW2MwdNsjmdGyV0cU/oDU2I6VltwBk4NV1vxStm?=
 =?us-ascii?Q?oommJ2r6dLbqNldIOT68HMhqJzmueN9/nklmXwFM?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e82a1af-094a-4e8d-5226-08dac7fc05ef
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:57:27.3946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 91xFEbDjsHO9iivsIcgksGkp/NOg5Ai+zKypKy4F+cMdi+WIAokXpFq2/B38zMdb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6024
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:55:07PM +0100, Thomas Gleixner wrote:
> There is no point in doing the same sanity checks over and over in a loop
> during MSI-X enablement. Put them in front of the loop and return early
> when they fail.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/pci/msi/msi.c |   67 +++++++++++++++++++++++++-------------------------
>  1 file changed, 34 insertions(+), 33 deletions(-)

> +	/* PCI_IRQ_VIRTUAL is a horrible hack! */

New comment too :)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason