Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 14:22:00 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 02/20] genirq/irqdomain: Rename irq_domain::dev to
 irq_domain::pm_dev
Message-ID: <Y3UqSOGDHl+vnlo9@nvidia.com>
References: <20221111131813.914374272@linutronix.de>
 <20221111132706.163937407@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111132706.163937407@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UVxpYz0oJJTlPLkeF6VqbdkDXibYjNw3mkTVOhCz/wi1PCwInbkCxMM+gSf1?=
 =?us-ascii?Q?luvNHAtjNvLsjJrxcm9MrXAB56MDjAzkqHYX/FV1GjTZnpT4/9r8BhUBTYv9?=
 =?us-ascii?Q?VqJzpMMIjZuQo3ZjkEGSngnHExOG3oKuoZWyScephs+nIcbAHWvIgOqxokSf?=
 =?us-ascii?Q?haYaxF9J20/wtTnkj4xUl/N1ywkES/E2cIjOVQu6xUYhFoJwqMuSFzEHE8u5?=
 =?us-ascii?Q?OvrB9ypHqLiQ1VI9ei0y9Zt91JRnrVnAZCcbQlchO93+xRKqBnEl3S4W8p0B?=
 =?us-ascii?Q?tv1uO6gjvmuGFy32mPd4UTjTppz0dIWj0LpqjtiNwi3cy36+F01itvq+Rpna?=
 =?us-ascii?Q?31zO98IjdTKEhTcln4aHug2A0mLHjSMW3d+SiGFYzBQCcw+sY60YHnazb0Fg?=
 =?us-ascii?Q?Eu7U+1KVfKoG+wwj36oGbdZaXpbpsHyLtCwrHjdp4dH7Qsbw73sut38dCakG?=
 =?us-ascii?Q?vC1T7NKPyDmuvsvmq7J+lMparKKGIN4oTKi6XP4kEGhv4un/50/qf7uGBLcI?=
 =?us-ascii?Q?YqKjTjcyrOwhEa7Q3R7ws58AoZPwnURgx2w2gHvWQ5Y68Xx2d8opqNiVRTdd?=
 =?us-ascii?Q?cydktcxQFUTe+kR7MJQg7HO5xuoHqsQB1BxUV0kqTYHV+TtYTiSlw3Fn2oq/?=
 =?us-ascii?Q?kNuhTpwGq0k2/I53WyY3z5AGbZkuEEzdNMbN5/DlfwimKQ87UQb7dDPSNrbF?=
 =?us-ascii?Q?fMJnC4jQvVHYwaQNIjzg0rlMhNHceruklN4STRHIjAlKx1pGL04UwTqfhsbU?=
 =?us-ascii?Q?He3qqKFizsE9UrKNu8aSnkClqDgZMzQDCnt9CvLaDkCdHBEkT55GHtiqgdq8?=
 =?us-ascii?Q?/KmF4z2hT10QsXhGqh5NbVMahyxsd9SnvNpwlgVhIxMaiCCrndmRzRjZUvFd?=
 =?us-ascii?Q?CuIKgIFytqF+KeW9D9sZw6Dq+MpxX10tkhXe9wdjkV/4cfAYNAsnOxZ1wRm2?=
 =?us-ascii?Q?wd5IUnH4tx3W1jU4EHWjQtXaf4o6AKJjmGVe7hFs4wYXmxJuXfsI9UFQcH+R?=
 =?us-ascii?Q?u6XqPsSwWhrWyQSiBCv3Od9O6KFB0OcaOXxy9Hl3KkkySPdL4o0gEUNT5RKW?=
 =?us-ascii?Q?pnwG90tNcT6PsCP6d62D9BzBBTfwP8TCuaOecCJGFbZgUWYiQX1OmMLmRE0F?=
 =?us-ascii?Q?T2DoCXlARM7KCprKTPHZY5Aq9zDi/YjVHLC01slb9KJMNmQ7HKdWJ7t2FhH+?=
 =?us-ascii?Q?WyW850luqemNugYoWXkUYySkTsvBRBy3xObeMYTviF6qFBfcKKRfuijaXfRQ?=
 =?us-ascii?Q?k/pz3Akh4NnEf14oU8TMEO+/Ji2TldprEEgTvAW4t5zL7dLcIJFTnQx4K6Fc?=
 =?us-ascii?Q?4n3tVA/2Y9JqP7W8OxbBMyjJIbCTSqOd0sq/B10jINq5pTMHkHTPn0s835E3?=
 =?us-ascii?Q?7t+ZkRH38FUdPHNRA6yYPDZdpms4iSe7xcrIphgFtanvrGoNBEYADX5I7Ufy?=
 =?us-ascii?Q?l+hZdrwBefHre057qIkSifOJ3Eq1O0MtlW379X2b47Z1W13cw7lB5WNc4RF3?=
 =?us-ascii?Q?FDctvJ8LzPkXUMXxXQPRp6E2uT7A2aquleWAWklcb3W2A2e4xAHK88LzkVEq?=
 =?us-ascii?Q?wx8MnStcA9car3Gl9SJKBtjytQOkAwAjmUK7JLsr?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48a56dfd-95ee-45cc-9922-08dac7ff7586
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 18:22:03.0564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZz3NRdzkgkhnxK2m7rbsPlk3iCiahGu6kGFwJf0JDbtkyfQ/FdbXRoQqnbAS+P4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5269
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:56:40PM +0100, Thomas Gleixner wrote:
> irq_domain::dev is a misnomer as it's usually the rule that a device
> pointer points to something which is directly related to the instance.
> 
> irq_domain::dev can point to some other device for power management to
> ensure that this underlying device is not powered down when an interrupt is
> allocated.
> 
> The upcoming per device MSI domains really require a pointer to the device
> which instantiated the irq domain and not to some random other device which
> is required for power management down the chain.
> 
> Rename irq_domain::dev to irq_domain::pm_dev and fixup the few sites which
> use that pointer.
> 
> Conversion was done with the help of coccinelle.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/irqchip/irq-gic.c |    4 +-
>  include/linux/irqdomain.h |   76 +++++++++++++++++++++++-----------------------
>  kernel/irq/chip.c         |    8 ++--
>  3 files changed, 44 insertions(+), 44 deletions(-)
> 
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -401,8 +401,8 @@ static void gic_irq_print_chip(struct ir
>  {
>  	struct gic_chip_data *gic = irq_data_get_irq_chip_data(d);
>  
> -	if (gic->domain->dev)
> -		seq_printf(p, gic->domain->dev->of_node->name);
> +	if (gic->domain->pm_dev)
> +		seq_printf(p, gic->domain->pm_dev->of_node->name);

This looks a bit odd now? I guess it still prints something meaningful
to debugfs but I suppose this would someday make more sense to be the
::dev version?

> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -117,53 +117,53 @@ struct irq_domain_chip_generic;
>  
>  /**
>   * struct irq_domain - Hardware interrupt number translation object
> - * @link: Element in global irq_domain list.
> - * @name: Name of interrupt domain
> - * @ops: pointer to irq_domain methods
> - * @host_data: private data pointer for use by owner.  Not touched by irq_domain
> - *             core code.
> - * @flags: host per irq_domain flags
> - * @mapcount: The number of mapped interrupts
> + * @link:	Element in global irq_domain list.
> + * @name:	Name of interrupt domain
> + * @ops:	Pointer to irq_domain methods

Maybe all this whitespace change would like to be in its own patch?

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason