Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 14:01:24 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 37/39] PCI/MSI: Remove redundant msi_check() callback
Message-ID: <Y3UldEe3x7WZe1K4@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122015.749446904@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122015.749446904@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xj39xdBPof7A1OW+MZi90fZ7/2SKHGp+4hpNGNncAOm15u/LKlIPjhujKhjP?=
 =?us-ascii?Q?und1ZxsM1bte5JKx0nxXS7AnvdkBscEVjk/Rhu/JVtRsv7Pe75+PGRpH2dS3?=
 =?us-ascii?Q?zKb6KsKmXOcOWwlTdGsn75lvGlAF3vEww6ka2/73EOpEydCFHU9pq/0EePd4?=
 =?us-ascii?Q?+k4Y4iLgZPONb3dch219KHdwDpV5+5qeU5EhaJ5JRFg4n/AsqDujiyFm7wqj?=
 =?us-ascii?Q?M0OuNPV3SO78katFvzqmTKp4BFgvJOvLv2wEPG4bHFnvgPerWjonjvLiiXLT?=
 =?us-ascii?Q?UxI7Gksp5zdKme6nV5asivuCxq2Ix5drPbCsGZrijClRZadbjPvG+0W+ELo+?=
 =?us-ascii?Q?GjdOanMQd5Qgvwk2GL/2wrz+WnJlFUrxjoFQg77+1hIZyvL6Q2c3rfQnwPpm?=
 =?us-ascii?Q?WdHrIUBy9wVpKFLzGTKU1ik5e0MixFAVCloF61Xzm+5lR1qTE0IsusPL17Wu?=
 =?us-ascii?Q?8Or3mJaOnEwTscJsV3IDH5QpOC7RqdHj5nSjUNRWmrHcBTxlahPkwir/t1z7?=
 =?us-ascii?Q?k58TWq1prSbMf2bqe1R13VbWfxYTDRrHcFZiSn8mFoqEivSuTVy8mhy7GQRE?=
 =?us-ascii?Q?GhhYXj0OXEf4XZZgpzy1+RKwsTY5utOC49jPunMeil6SjeC9KxhaArqMvKpd?=
 =?us-ascii?Q?ARCuLIee+ZR77seLHVGB6UCaUMA9RMRa2qvvb2uKo0TboLmfJTjMuYZPqvGh?=
 =?us-ascii?Q?c1ywHxpMKsUbswVfL3T4GJagYg1El7zl02UEGzt872Ax+Oj1PS3iMOB0wUL9?=
 =?us-ascii?Q?tbZZapbS75uwowjajZBK0CsEdQJsoW8KsoMyVDOGng+sTqCQl0gnz+6eWoaT?=
 =?us-ascii?Q?IA25BgClPuvkSPmY2QTC9x2a0j8MDIj9zq7xYjpKINI9MeTNdYryDwr9kpcL?=
 =?us-ascii?Q?FvdRSOVf5HtkVFEiuSM0mPcCz7Z47FrWeEWApb5DCgR0sfHrclqv5MsiZNTV?=
 =?us-ascii?Q?EavjjwTlr5LW1EGOUTDsQ2iBffcE/+Zmn4KcDoAr3UEQ08SiXiZ8C7KLpoJf?=
 =?us-ascii?Q?ge9OwoPBW1p20mA5Jpus/CL7N5UZirAt+qQ1pZB/QQqIMOgU3ldte9uLJiM6?=
 =?us-ascii?Q?UibSE46qq9rGU2QM/N6xKt/T5F0/24zs8HNyA9/nZXyKXUWQaY34UHTZAqMs?=
 =?us-ascii?Q?2rzuqDvWItXZzRt5pxSrZ+R0gAgq+Osotp7f5+EIhuE0w7pgTuPN81OFW1jS?=
 =?us-ascii?Q?v0HpfoiJRo7zkIFAVXWuWCmlm9Tahj6hOqx81rW0nIDW8IOQx6A+7cnDTRWU?=
 =?us-ascii?Q?95c7t1U1pSjdokvbo6ev3Vuk+YQqZ09MYJOYfdQ+pAAM+Riwx8tWTvVgkI26?=
 =?us-ascii?Q?hKVBjvhytu5q2PNrwjNGQ5Ztg9+Z81S7TWeuvcdfqTu9UurQKJugW6nYsW6y?=
 =?us-ascii?Q?q5I0FYPRvQ6OSp/omwRw9GSEVGun9H9FaRhcMbtElrugiQx22NB7xvT6GzOV?=
 =?us-ascii?Q?OH7zO8t/QJ8HneMxjpydBjnWC7z+ZR4gJrLuiSsIwLk3OrQL95o3i0cEMohT?=
 =?us-ascii?Q?MzzP8Hte3Ye16EBhwB98fTFcZzwgO1wPyZoJF7Ei0CXNSgMbDgBiO+eFsCtv?=
 =?us-ascii?Q?CwFraHf8o9z7Vxnb6Tm2LJwkNPPNU5rZQF9jrRKu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffcf3829-41b1-4728-ebcd-08dac7fc94cd
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 18:01:27.0899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: saSQRht4UbVwZgv8kB+oKfKt/XqW+lsxlXdMnNsfMaL1dxQPMRJjSpWV1okgUFr1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6243
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:55:14PM +0100, Thomas Gleixner wrote:
> All these sanity checks are now done _before_ any allocation work
> happens. No point in doing it twice.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/pci/msi/irqdomain.c |   48 --------------------------------------------
>  1 file changed, 48 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Much clearer this way

Jason