Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 13:49:15 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [patch 12/39] genirq/msi: Add bus token to struct msi_domain_info
Message-ID: <Y3Uim3pC3hy3HwH8@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122014.294554462@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122014.294554462@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mI5rTn1F412KO9ruMqqTp7ydn5TBX5j8B1r4JO/I3kEixuP819WWJctxBE1M?=
 =?us-ascii?Q?KEY8k+OJbhY7IwRO8L+4nN4TJ6+p5PvE5Tv+03ZSv8ilV53lz7UqJqUcFhsU?=
 =?us-ascii?Q?Hfjhk9ND1p2/NVfVFLdJNtYWWQTZjJCOiiMnSnSlArHekKWMnmsWduRlZoCC?=
 =?us-ascii?Q?e4BkCyw8TnsanGtPfQY+Besaq5QGhHgkFRhnsQjs1wLFurcgKdYHXU6D15+b?=
 =?us-ascii?Q?mUdGXkofm21s1gwI8v5vo/LgrvITLA5KRpE4CnpPJCh/EBR2lraFKrZZXkA3?=
 =?us-ascii?Q?+pC8fko5r4aDKBkhJs9l1rPlwXKO/eVVMRjYZBZe8YnLMzG1FKVzaQ6B7gjI?=
 =?us-ascii?Q?iwz9Yqh9dYUESuV+CAWFP/bi/Lx1UTsihiJNAfS8Z69G1or0tOm/lhh+PI0F?=
 =?us-ascii?Q?ScDI48Z2e2NEGd1blrIxLWzQ2bS8vBEJXMVoY3N4OMUbiSYItkWzUnursjbT?=
 =?us-ascii?Q?aUeQctuH3TvyYhZgoDG8wf7qkAhaMvyr430HkdfAhbTYL/N+nN+CywxGNpGd?=
 =?us-ascii?Q?QSuzFtyL50u4pMzzGhqFaCbrM0Vx42kY3xA/x5g9+Mw14K8g4F7G775WYmbD?=
 =?us-ascii?Q?e+bqWa3HA8VhByTxXX6elkriUqkgF5fgb8ctGdFDMVIdIvLUHvfRJPKd19zq?=
 =?us-ascii?Q?IZtbrBvH3AAZVX/d30Gv8oZVHN/i58ULZW0tHI6Ym4NIH4c68YufEbUBiT5S?=
 =?us-ascii?Q?HpRP0vZZ20aZAK8SQ6M0N79vVUTR+DwwkHm73bQMSxL4U3bN1g8mND8YO78+?=
 =?us-ascii?Q?x2gZ7zjlqC0T9A+1nSt+YQSJdffZm7h3aUIG1A75nq3tuvs28ocsyoCeh737?=
 =?us-ascii?Q?KIwQjS0PdFgM4cl5XTYBxOc8Oixz+6FXam94BCh78XojaIfvuMCiif9cKaZ4?=
 =?us-ascii?Q?YOCCiYNDgR41hRgzf0/x9QBlP36sKfaIkSxZRIEP3EOmQ7S/l9NCM1SOmb0Z?=
 =?us-ascii?Q?fomZCjx/0OpwE8b70M7pk5aI5pnIM0y8jjS7egUJ+Fl6iLpDto7VKsgUf3dl?=
 =?us-ascii?Q?8vr7wZNCq3FaZYqy9PVr+YY947buA9a0+J1b7fZLKraWcilcpynHd4gIWigY?=
 =?us-ascii?Q?ZVa04y3NRlikDb6XBJjViyC9HATIgIlF4Olytzyy7T6c0ZcqjvSiaGLMwZEi?=
 =?us-ascii?Q?u+vOG+6D/XPRKj7gTD7bE8smFjuzX8jCzcZhgYdXe5V9/oX56zWHrYn0TwWS?=
 =?us-ascii?Q?ONzZm4K9Nk9dsjHTghX37OtN+cqfjcph58iteIyRjM7BFKxk6dFoZgn2bsak?=
 =?us-ascii?Q?RsEgOHSXU25PxVP4uRYw95KA17gfZH2D1UuDMQbxt2+wMgjkqgqM7qOlbu+Q?=
 =?us-ascii?Q?FZ2O1IHhOvVWjOyyY2UPhm63OKXDdLmwOlrr5HRwrRaly+aGEAlyfzDDkK6A?=
 =?us-ascii?Q?4rinZ8tbcAqjm2zdBv/EkoJw/bbf2B28SiMMXNQ0xaJoblizy3ZHrMPttF/p?=
 =?us-ascii?Q?6E8tsN0Kkct2Re6AaFaOB1ztjXHPQwUiFYlZF0ldnQNjF+1Zm8Xj9l4SvAi1?=
 =?us-ascii?Q?00+Zawa6yDhfZ5f0r6kug5SshDSuClTKF3/qJ6A7NFWmDx7NVL27lgC4UeAi?=
 =?us-ascii?Q?61qkf3tQHC4fL2onBiusGagApotr6FMIhvHPMyGw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff9e9fa-0196-4346-705f-08dac7fae1e4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:49:17.4129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Bv0P43cr4j2KiXUugb01rjekYovhjUYiORhcqoTegYWIjo59bOAFgoFocNwor85
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8145
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:33PM +0100, Thomas Gleixner wrote:
> From: Ahmed S. Darwish <darwi@linutronix.de>
> 
> Add a bus token member to struct msi_domain_info and let
> msi_create_irq_domain() set the bus token.
> 
> That allows to remove the bus token updates at the call sites.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  include/linux/msi.h |   19 +++++++++++--------
>  kernel/irq/msi.c    |    7 +++++--
>  2 files changed, 16 insertions(+), 10 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

>  struct msi_domain_info {
> -	u32			flags;
> -	struct msi_domain_ops	*ops;
> -	struct irq_chip		*chip;
> -	void			*chip_data;
> -	irq_flow_handler_t	handler;
> -	void			*handler_data;
> -	const char		*handler_name;
> -	void			*data;
> +	u32				flags;
> +	enum irq_domain_bus_token	bus_token;
> +	struct msi_domain_ops		*ops;
> +	struct irq_chip			*chip;
> +	void				*chip_data;
> +	irq_flow_handler_t		handler;
> +	void				*handler_data;
> +	const char			*handler_name;
> +	void				*data;
>  };

This is why I've been frowning on horizontal alignment :(

Jason