Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 13:53:37 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [patch 14/39] PCI/MSI: Let the MSI core free descriptors
Message-ID: <Y3UjofjdGh0TyP5o@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122014.409654736@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122014.409654736@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0MnaQPUruXXbrorVlmyqj2p0fmL0lLXgfb42mZyPf56SfHOJd0pqu68VPpFe?=
 =?us-ascii?Q?mbSVus+rS+v/aFW63BauXdjdsRYCK922COrGGBN9T8MjQEsm58PY5DR1vBJu?=
 =?us-ascii?Q?lPYS/4BOJDW6uuLanBEC3fYH01tD7Ygn24XTQlirgso4NtOz5ITCYV067AGS?=
 =?us-ascii?Q?zcxl6r2/3VAcNmzbGl/yLDn6ljpQDW9TnU+7NbQQRxoW2YKxFYOraBDZxoV4?=
 =?us-ascii?Q?5zovMsKZmtyKmjlg+vhUPlqSIhgunZHdSBDNFh8gQq1JSrVgJwMKkhQnliDu?=
 =?us-ascii?Q?jrnMeled3OL80Gj/qpRqHnwYs+YEOsPyJ/MC0hyHYW60lbeUWiX81StSSxsS?=
 =?us-ascii?Q?u6krAdH4eiNJw4vecXOW/NmuFZaW4GAAvu+6rmaNi6uRqpOWubdgvnRfEtnY?=
 =?us-ascii?Q?dEwQMuilEAMzyrlCkE+o7N3dNYymHHGGjjNkKL069Y2L80XUZ9t3ArPcWDrg?=
 =?us-ascii?Q?uc9Ozme2WtVh5t5PrgBkfg67GNrc0pYQ6qH12F1C+swJOE0FDzrRTwCO+Rd5?=
 =?us-ascii?Q?mzcNXpxT48i0VBeDGrBbtSF1eC33Et/YCkuKEJTOBzNAeRz6hhMwpH/0M4ar?=
 =?us-ascii?Q?MgwpEum1mdPGj8suReXLr7sjFYmr8qwpMMrkxOdQolYzcMijK2arNbtLieA+?=
 =?us-ascii?Q?JhaX6+BbNABe7ETrfXB1mG4XMz82NNrp2QI4VEMqm45SepHAD403bPl5d/6Q?=
 =?us-ascii?Q?EELeps2zYe3xnnzRxB3Yk1FSN2xyK7m/wAwvT0zdM+L20k4FZtZodQ98umGB?=
 =?us-ascii?Q?3Dn3u5788s35Ve1I0PuXGIhXVeJPTCEDDhMDX7A8fb4txiUKH5sD1FMUXeL1?=
 =?us-ascii?Q?C19A07uU/iglzirnBAMIJj4NA/s5GvoT+oj44FMrW6ids/LqDIKtRRRWtb8k?=
 =?us-ascii?Q?TEEidGxmfFcGojTIDcECz/WiF37J3q4tSulCyjW1g8T9U0OYUzJrzLl3ME1p?=
 =?us-ascii?Q?tW+h6LF/6lRFWliF7fgxe5Tf95W05v2nBBZejk1WG6r9qnYrFKPp9aHfk8hh?=
 =?us-ascii?Q?r+/02S5MwCl5UQksU+eSJFy45myKzze1sPDq75SNzIZ/eHklUOk44bCMi2fU?=
 =?us-ascii?Q?kIupCkkpEGJjXlnhrk5oVTyE2fsJ48ct36348k1IqaBPVzWMq6/sR/raDIP5?=
 =?us-ascii?Q?vlnxtb+hhHJmJWgcA0emH89JI+tvoWTfTRqh/4onkrcuCsjIH0g4wQunM9gT?=
 =?us-ascii?Q?B+i4xVUpp5XYY4uji6BZ8AuY5xXB/Xd/pmkZWnNH61gPFn+oqPJv48t7CkS+?=
 =?us-ascii?Q?6bBDpuvZDlL7bp3mLBrv/cSUJ56xIpaffWnGwDf2E+3y3EiHikcioQjdPDsz?=
 =?us-ascii?Q?NxSBbMZ7u/CaONKkh8SPJdME1srJwFEbWYFZhuFfgLQvOUMfajWBKZg3zjif?=
 =?us-ascii?Q?oXmcJxMNaDe32YFreohdSn6baIgVofIc15ZXxQ2nceYRHS/gez48Z0NFtQSu?=
 =?us-ascii?Q?+UedPyi1Hz5VI2zGj+JExmiPG5RvVfVdp9cC2Ju/Mqrlo163Va3k5VOeVcug?=
 =?us-ascii?Q?d/0AOtosiOjVQsnHjOu1kqO43oFICpa6HbR969p6FIdal6rTYd/lxhclGtv5?=
 =?us-ascii?Q?4cA93vbAY1a2b7LQIlrtRCgDIrQFeVjPGrJAuFuW?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c1c8dac-b1df-458e-03b3-08dac7fb7d7a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:53:38.4379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u2X2BSZRbLY7S1HBX4mQWcq4cSM0hU7ZPq6n3daG574/XdGsnyeptHG7xKqZUOQN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7946
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:37PM +0100, Thomas Gleixner wrote:
> From: Ahmed S. Darwish <darwi@linutronix.de>
> 
> Let the core do the freeing of descriptors and just keep it around for the
> legacy case.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/pci/msi/irqdomain.c |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -24,11 +24,12 @@ void pci_msi_teardown_msi_irqs(struct pc
>  	struct irq_domain *domain;
>  
>  	domain = dev_get_msi_domain(&dev->dev);
> -	if (domain && irq_domain_is_hierarchy(domain))
> +	if (domain && irq_domain_is_hierarchy(domain)) {
>  		msi_domain_free_irqs_descs_locked(domain, &dev->dev);
> -	else
> +	} else {
>  		pci_msi_legacy_teardown_msi_irqs(dev);
> -	msi_free_msi_descs(&dev->dev);
> +		msi_free_msi_descs(&dev->dev);
> +	}
>  }
>  
>  /**
> @@ -170,6 +171,9 @@ struct irq_domain *pci_msi_create_irq_do
>  	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
>  		pci_msi_domain_update_chip_ops(info);
>  
> +	/* Let the core code free MSI descriptors when freeing interrupts */
> +	info->flags |= MSI_FLAG_FREE_MSI_DESCS;

Comment repeats the one on the enum declaration?

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason