Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 13:43:16 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 01/39] PCI/MSI: Check for MSI enabled in
 __pci_msix_enable()
Message-ID: <Y3UhNGosBbucAL+g@nvidia.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122013.653556720@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111122013.653556720@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P3gT6vu5PsYoUwqgg+T51oIRrv+W0nnLdGSGmbCoZibD8UGKj6SBybZvjIlV?=
 =?us-ascii?Q?TJ21l36536DcyV+VEJVlFHt3UfwVz6zWUm7ZE+HSce2vu1TXHPH5Lkk9lZ4l?=
 =?us-ascii?Q?ZSKhy5eFx9KUjP0CpgWDYMIlV/iYx8aXINn4xgcc8Impi1o8D3rZIpxG7EvS?=
 =?us-ascii?Q?t8izvw9b4nXXSN2/KjVI7WvB68V8O/1obSedSiKGj7UZHGzhmwHxB7vCZvfa?=
 =?us-ascii?Q?PKImWdtcPj6ffFuACnZ9AxmMDsW8IfzO0JTZpMTGHR2HyWKy2H2IuE6ilFRc?=
 =?us-ascii?Q?AKCteFkvshaZTxGfyujAEQWu2LBbLW+YO3xNPiNxpuuP/1BYnsyp2B7jIjfF?=
 =?us-ascii?Q?EcldNSOzqZDvxUAL/C21cu7SQPD7kTyq5axqVjpPa9RTrwLPaD4haob82/7+?=
 =?us-ascii?Q?ELnmeD4XAF2L4IrEw6F81XvqqTIb9gL+8+YnvmebwPBcZeGirSF7S33wrrxz?=
 =?us-ascii?Q?0rleFtcINNI06p3Hh/cCwbu0R6zo/iasNdN/OsLlHT7w0sFbuLbjPL9xGsu1?=
 =?us-ascii?Q?qo/vVWoMCgzE40QqfUl/gYXb3Swpw8mytrESaHmWYzG7rs473YP1InSkk8P3?=
 =?us-ascii?Q?dDKMp73qpl4o0tX5S99x8m793G7m3lE7NNq6KnzG+ASsxNQ0sovbk0YbuJ+u?=
 =?us-ascii?Q?QEcqmPr9VFW4mL+uPNJyiw2Uyx54HRg50uiIVY0oaIGWDOBXJZa96cr9qsRx?=
 =?us-ascii?Q?BB1T/LpPWGGo6xo4air6eALT+PlonA+6mv5hu0H5jj/73/14ZF2Bk/Gdae/x?=
 =?us-ascii?Q?n20WKDOgvIGwQCux/pr4GukWG48eqQ3cVH7CPNAZHYJns9SNiykumNHsKqAA?=
 =?us-ascii?Q?uFWrZADrzE+z72y7m2a71UvyA8OCJ3TATe1GrVQgavh0XkKZbxxTnkEAFZB5?=
 =?us-ascii?Q?VnFa8claIUAI4CIxmMkMoWRnoplET/vRfy659eaSu4cGWSt5Fp0L6ewYtOfb?=
 =?us-ascii?Q?hg6kc/ndu9GgNbkYQ5NNopFTQwhP82W2zV78XS9olNxCNqyIM85ZVGVpzNrn?=
 =?us-ascii?Q?gWEUGsirxvRFhjCfcyIpPVZjEeCl0mvn7nTfANf4PGvpBWeIuU3C0s8YVKt/?=
 =?us-ascii?Q?p5B0xuhPvyTKNcqoYqZcy3sAbsbAANRb+KDdAvYYdylHIV8ZEq2y9vgyChPT?=
 =?us-ascii?Q?zP1yYyrXocaXSKr94IMYZi9bo7KHAYljYBb0WcO/PVIsIc0HMjBAEH2P+6YS?=
 =?us-ascii?Q?9oVWbjj/9MiNOOCo/Y3WXVbqlTdm8eRLWfK/hmCkRlxyCADFKLqOw+RDBrJN?=
 =?us-ascii?Q?DWoaOjvnINKhdVoiJUMpX2bA7iv0Xpc2kd2ayAWpTVYoO+O50xDmbLZhshI9?=
 =?us-ascii?Q?12ke1HA+jh6nw3oa3GWT07u/eH/V6nLRARjQKKh0+Uu7qLDzIDb42fOivwUY?=
 =?us-ascii?Q?FQO1kU6cnaLRnmuZixT6rrxGpIRpmLwSgSVnGqQhPEiMmEJ6tSgY6+L5xAB+?=
 =?us-ascii?Q?yBXCfgZnwu9Q+PbFd4jKJWYxeejzMzaKvEQaL3f1R1gbaZGa7SWJSQpK6FUu?=
 =?us-ascii?Q?hH0ttuOVEsFgTDPRLQMLPbW15jMQh+j5ndi/LiADYgBPzPYtj91Lud8yxOsH?=
 =?us-ascii?Q?szAkTlmGiLN+Or3zHyAc65iszHRlnXdw1otj+MwR?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28cabb79-6a33-4014-f63f-08dac7fa0b49
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:43:17.3681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3mKtgOQocqS+9tMlAdrwnUfdlhnsf19q3vQSLqs5r075zA8PKzlEK/wMCNgxMHrt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5945
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:54:15PM +0100, Thomas Gleixner wrote:
> PCI/MSI and PCI/MSI-X are mutually exclusive, but the MSI-X enable code
> lacks a check for already enabled MSI.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/pci/msi/msi.c |    5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason