Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 15:28:07 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 19/33] genirq/msi: Provide msi_desc::msi_data
Message-ID: <Y3U5xwujkZvI0TEN@nvidia.com>
References: <20221111133158.196269823@linutronix.de>
 <20221111135206.346985384@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111135206.346985384@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6Ar4BO+megp0FcbkEw2OlfNPsho8/1L3J0yUsc+J11SMu1M5A1NhVLWBFpNn?=
 =?us-ascii?Q?AKrg9WkmGxl9vqp4GMaxQHGraYiEOI9x0aGN7PQCZDHjybCGU9RjAW6lMVdu?=
 =?us-ascii?Q?Lq5PsPGhTnVhy0WKmKSXOrAEsi1BvPWc22xwnch7J7IfiuGG+StSoGUEF7IA?=
 =?us-ascii?Q?wbOW05tHyGQeGDsZRWP0XQgicn2RG6OS3RW5E3Wfy5xMacSXwm4C1fd38koh?=
 =?us-ascii?Q?JFPPeJioxY07NF98NP+pUWNytv9z/oiz1PAMzGlNoP4/nYPFQP8SZMeAUAJR?=
 =?us-ascii?Q?drzrVV3lEMms4DoKrtCHL6rFm8j2+miiau1RCWe3G1u/DuTYofIylRPKI4Yf?=
 =?us-ascii?Q?W1OG7VqSuG5zvhIldnk/JYPy6We18XspWJeHqZGh0Demai4YgBdI6bwkGeXW?=
 =?us-ascii?Q?TlvqMa1Z3mpX6+xEARauoVCBAah2dngKb2UOZHc5UFhpoDagOaYL2PDd1x0A?=
 =?us-ascii?Q?lvzD/YlIEUo2zZYkpZXSafcVOuHs1exaf0A0RBHsD6joooIO0N5ahHhoBWze?=
 =?us-ascii?Q?QFn9qfYagY4jK2Zv5rQ7FbSrau1nHgwK7ALacKzdPV4T+jiL1HWn+VgNSAPo?=
 =?us-ascii?Q?j6oFJcs6iaDnssXbfk6wEONzTyytf5+ChuM0dBVT72fQOM3yK3ey19kz2A1X?=
 =?us-ascii?Q?sCmhkLKD+p282GAB+ANIfu3QQid+sRshjCXQqOAwo2ZzdMvTtN4cbwWCUJ+H?=
 =?us-ascii?Q?QAmYs2ZxvaBgWhR1dO0KwV6gzYE4WHIAezYf36XT1eZe2aQ9jZFzV0MTQnSH?=
 =?us-ascii?Q?C8GbOJstWINhpcKzSzlxNyk0eH8CtH/3qY7W0yGA6V1tB1lBbDVuq3BYplQO?=
 =?us-ascii?Q?/q9EBqBdEhdbidDv0K0MwFgzIAu0QkHfsp4PT7C82k9g3eHFmU2sPAydljd7?=
 =?us-ascii?Q?0N20zqyNdC/P2l++IbcwdDVfbSRoKdVK0u4Bhcx5JK/8yaBOrJjlIh8k166X?=
 =?us-ascii?Q?HtnoMOLwBuiQHjmu6t8IsTPl90NPVTpVh5i9qEqmWNjFCgQZxhJDEVusrstw?=
 =?us-ascii?Q?b6jiWZgAClrJrRb08LDQp8dnNRKvxob85BZ90nsPlRWsMK4WrLYttMBayu6D?=
 =?us-ascii?Q?7BZJzvk3QpX7lJ0ro99tAZIX6+c60SeSs70dzcE08ITy0WZW2IyC2uhaTmXB?=
 =?us-ascii?Q?5OEGn7gLK9j36dZcpBOJWxBLHtjIP3NYbQDVIrAI9ROhZNt8ddeHZfdeqnGL?=
 =?us-ascii?Q?KsWnqk8xaENVGSMdpfb8b7DzYqRVfTqhLBiM5PoYq4EQVeaskFt9dlMskp4G?=
 =?us-ascii?Q?Wr03gccewDFo5Mk2VUTJcfcAqpC1106mP39YGgDfInT2/t6/owF2UtBbkA9K?=
 =?us-ascii?Q?NXNcOeghYWQBDu3x8TQf2dLUL0EtLvlZuhCevWSNEXNuGuL+jTTa74k+nV4+?=
 =?us-ascii?Q?Ijwm90QDrz3SW4n8CiyecTCUDmscg4diM+LP9G3A6FZdqIgOko/U5yWFMEsv?=
 =?us-ascii?Q?rMfRxx+TDdgCO1p4TNX/ubKTRjQpyPsgGvqDh2PhFyQ3kTWZrm4Ux9qLfCSI?=
 =?us-ascii?Q?KmT88zRrviginNdAnrKhstWDYMiAIawx+6sjn4YDnVrZe2GQ6dS17anAgmIa?=
 =?us-ascii?Q?eHGOxjKfAtOvhZYgqtp9TzEn11lkJN2QymMzZwVB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65af350a-d8ce-470e-588c-08dac808b18b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 19:28:09.2370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ubr9LO2gd9UYrv5RNOgnSQJYx/3PUaQHepr67XeiodD0Qw03tXxIOpWQb6baknew
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6458
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 02:58:41PM +0100, Thomas Gleixner wrote:

> +/**
> + * struct msi_desc_data - Generic MSI descriptor data
> + * @iobase:     Pointer to the IOMEM base adress for interrupt callbacks
> + * @cookie:	Device cookie provided at allocation time
> + *
> + * The content of this data is implementation defined, e.g. PCI/IMS
> + * implementations will define the meaning of the data.
> + */
> +struct msi_desc_data {
> +	void			__iomem *iobase;
> +	union msi_dev_cookie	cookie;
> +};

It would be nice to see the pci_msi_desc converted to a domain
specific storage as well.

Maybe could be written

struct msi_desc {
   u64 domain_data[2];
}

struct pci_msi_desc {
		u32 msi_mask;
		u8	multiple	: 3;
		u8	multi_cap	: 3;
		u8	can_mask	: 1;
		u8	is_64		: 1;
		u8	mask_pos;
		u16 default_irq;
}
static_assert(sizeof(struct pci_msi_desc) <= sizeof(((struct msi_desc *)0)->domain_data));

struct pci_msix_desc {
		u32 msix_ctrl;
		u8	multiple	: 3;
		u8	multi_cap	: 3;
		u8	can_mask	: 1;
		u8	is_64		: 1;
		u16 default_irq;
		void __iomem *mask_base;
}
static_assert(sizeof(struct pci_msix_desc) <= sizeof(((struct msi_desc *)0)->domain_data));

ideally hidden in the pci code with some irq_chip facing export API to
snoop in the bits a few places need

We've used 128 bits for the PCI descriptor, we might as well like
everyone have all 128 bits for whatever they want to do

Jason