Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 12:34:09 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Stuart Hayes <stuart.w.hayes@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] cpufreq: ACPI: Remove unused variables
 'acpi_cpufreq_online' and 'ret'
Message-ID: <Y3U7MWezkc8aizuo@dev-arch.thelio-3990X>
References: <20221108170103.3375832-1-nathan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221108170103.3375832-1-nathan@kernel.org>
Precedence: bulk

Hi all,

Small ping, was there an issue with this change? It seems pretty
straight forward to me and it is wreaking havoc on our build matrix due
to -Werror.

Cheers,
Nathan

On Tue, Nov 08, 2022 at 10:01:03AM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
>   drivers/cpufreq/acpi-cpufreq.c:970:24: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>           acpi_cpufreq_online = ret;
>                                 ^~~
>   drivers/cpufreq/acpi-cpufreq.c:960:9: note: initialize the variable 'ret' to silence this warning
>           int ret;
>                 ^
>                   = 0
>   1 error generated.
> 
> Both ret and acpi_cpufreq_online are now unused so they can be safely
> removed, clearing up the warning.
> 
> Fixes: 13fdbc8b8da6 ("cpufreq: ACPI: Defer setting boost MSRs")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1757
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index c8fdfcf659e6..74ef0e05ff7b 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -953,12 +953,8 @@ static struct cpufreq_driver acpi_cpufreq_driver = {
>  	.attr		= acpi_cpufreq_attr,
>  };
>  
> -static enum cpuhp_state acpi_cpufreq_online;
> -
>  static void __init acpi_cpufreq_boost_init(void)
>  {
> -	int ret;
> -
>  	if (!(boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA))) {
>  		pr_debug("Boost capabilities not present in the processor\n");
>  		return;
> @@ -966,8 +962,6 @@ static void __init acpi_cpufreq_boost_init(void)
>  
>  	acpi_cpufreq_driver.set_boost = set_boost;
>  	acpi_cpufreq_driver.boost_enabled = boost_state(0);
> -
> -	acpi_cpufreq_online = ret;
>  }
>  
>  static int __init acpi_cpufreq_init(void)
> 
> base-commit: 21cdb6c18f85fe538ca8740bc79f11fbe08d0197
> -- 
> 2.38.1
>