Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 22:07:25 +0100
From:   Martin Botka <martin.botka@somainline.org>
To:     Lee Jones <lee@kernel.org>
CC:     martin.botka1@gmail.com, ~postmarketos/upstreaming@lists.sr.ht,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Jami Kettunen <jamipkettunen@somainline.org>,
        Paul Bouchara <paul.bouchara@somainline.org>,
        Yenda <jtrmal@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC
User-Agent: K-9 Mail for Android
In-Reply-To: <Y3UGc//UuuinJcbE@google.com>
References: <20221114162334.1801137-1-martin.botka@somainline.org> <Y3UGc//UuuinJcbE@google.com>
Message-ID: <671D1BC5-589B-4AFF-B026-1810F48522FD@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk


On November 16, 2022 4:49:07 PM GMT+01:00, Lee Jones <lee@kernel.org> wrote:
>On Mon, 14 Nov 2022, Martin Botka wrote:
>
>> AXP1530 is a PMIC chip produced by X-Powers and an be connected via
>> I2C or RSB bus.
>> Where AXP313A seems to be closely related so the same driver can be used and
>> seen it only paired with H616 SoC.
>> 
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
>> ---
>>  drivers/mfd/axp20x-i2c.c   |  2 ++
>>  drivers/mfd/axp20x-rsb.c   |  1 +
>>  drivers/mfd/axp20x.c       | 63 ++++++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/axp20x.h | 34 ++++++++++++++++++++
>>  4 files changed, 100 insertions(+)
>
>No major concerns.
>
>> +static struct mfd_cell axp1530_cells[] = {
>> +	{
>> +		.id = 0,
>> +		.name = "axp20x-regulator",
>> +	},
>> +};
>
>Why .id = 0?
>

Oh good eye. Yea thats just left over. Will be removed in V2 :)